Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File
gerrit-hooks has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7:
(4 comments)
thanks for the early review
https://gerrit.ovirt.org/#/c/53101/7//COMMIT_MSG
Martin Polednik has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7:
(4 comments)
Some quick glance details.
https://gerrit.ovirt.org/#/c/53101/7//COMMIT_MSG
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/53101/7/lib/vdsm/libvirtconnection.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7: Code-Review-1
(5 comments)
there are rebase glitches.
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7:
In PS7 I'm still playing with different names (vmstore vs vmdict vs vms.Dict)
and I've
gerrit-hooks has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53101/6/lib/vdsm/virt/vmdict.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/6/lib/vdsm/virt/vmdict.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6:
(7 comments)
https://gerrit.ovirt.org/#/c/53101/6/lib/vdsm/virt/vmdict.py
File
Martin Polednik has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6: Code-Review-1
(8 comments)
There is one issue hard for me to get over - vmdict is a
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/6//COMMIT_MSG
Commit Message:
Line 4:
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6: Code-Review-1
still missing docstrings
--
To view, visit https://gerrit.ovirt.org/53101
gerrit-hooks has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
20 matches
Mail list logo