Francesco Romani has uploaded a new change for review.
Change subject: vm: abort vm start if can't read pid
..
vm: abort vm start if can't read pid
If for whatever (quite unlikely) cause
the PID can't be read, or it is invalid,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13418/ : FAILURE
htt
Dan Kenigsberg has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/36129/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/36129/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2704:
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36129/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2704:
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 2:
addressed Dan's comment. Highlights:
- avoid exception translation
- avoid getPid alltogether in recovery
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13461/ : FAILURE
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13462/ : FAILURE
htt
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
version 3 fixes a logic bug
--
To view, visit http://gerrit.ovirt.org/36129
To unsubscribe, visit http:
Michal Skrivanek has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36129
To unsubscribe, visit http://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
verified using tests.
Verification using running VM:
- creation, happy path. PID is reported - OK
- recov
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
hibernation flow seems OK - pid changes across freeze/unfreeze.
dehibernation took something like 30 minu
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3: Verified+1
did an handful of migration back and forth from a patched VDSM, seems OK. V+1.
--
To view, v
Dan Kenigsberg has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36129/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4355:
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36129/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4355:
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 4: Verified+1
only the error path was changed. Manually verified that ValueError is now
correctly formed (h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: abort vm start if can't read pid
..
vm: abort vm start if can't read pid
If for whatever (quite unlikely) cause
the PID can't be read, or it is inv
Dan Kenigsberg has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36129
To unsubscribe, visit https://gerrit.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/714/ :
FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16404/ : SUCCESS
http://j
automat...@ovirt.org has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 5:
* Update tracker::#1128458::OK
* Set MODIFIED::bug 1128458#1128458IGNORE, not oVirt prod but
automat...@ovirt.org has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
..
Patch Set 4:
* Update tracker::#1128458::OK
* Check Bug-Url::OK
* Check Public Bug::#1128458::OK, public bug
* Che
22 matches
Mail list logo