Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40961/5//COMMIT_MSG Commit Message: Line 22: unprotect_passwords

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 6: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 6: Verified+1 Verified by running vdsm and checking whether parameters for protected methods are secured. --

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 5: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 5: Jenkins job failure not related to this change. -- To view, visit https://gerrit.ovirt.org/40961 To

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40961 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40961 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 9: * Update tracker::#1220039::OK * Check TR::#1220039::OK * Set MODIFIED::bug 1220039#1220039OK

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 8: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40961 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40961 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: jsonrpc: Prevent password logging .. jsonrpc: Prevent password logging Vdsm should not expose passwords in log messages. We have code in HSM,

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 8: Verified+1 Renamed method as suggested in one of the comments. Copying verify flag. -- To view, visit

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 8: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40961/4//COMMIT_MSG Commit Message: Line 23:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40961/4//COMMIT_MSG Commit Message: Line 23:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40961/4//COMMIT_MSG Commit Message: Line 23:

Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

2015-05-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Prevent password logging .. Patch Set 4: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check