Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: Continuous-Integration+1 Run tests locally ion RHEL7.2 and fc23, everything looks OK. -- To view, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-17 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: hostdev: add is_assignable flag .. hostdev: add is_assignable flag is_assignable is new flag that uses underlying PCI_HEADER_TYPE. We can only

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 5: * #1303160::Update tracker: OK * Set MODIFIED::bug 1303160#1303160OK -- To view, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: Verified+1 make check works, is_assigned present, 2 platforms tested (x86, ppc) -- To view, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 4: * #1303160::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303160::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Verified-1 would break the tests, fixing (with proper test verification this time) -- To view, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Code-Review-1 (4 comments) the logic is good, but missed jenkins verification let slip in some style

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: * #1303160::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303160::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: Verified+1 only dead code removal -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 3: * #1303160::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303160::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 2: Code-Review+2 looks good and safe. Please get one other ACK. -- To view, visit

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 2: reason for jenkins failure: DEBUG util.py:399: Yum command has been deprecated, use dnf instead. DEBUG

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 2: Verified+1 tested on both x86_64 & ppc64le -- To view, visit https://gerrit.ovirt.org/57506 To unsubscribe,

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view,

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 2: -Verified * #1303160::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303160::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required

Change in vdsm[ovirt-3.6]: hostdev: add is_assignable flag

2016-05-16 Thread mpolednik
Hello Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/57506 to review the following change. Change subject: hostdev: add is_assignable flag .. hostdev: add is_assignable flag