Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-04-01 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: clean and modernize the destroy() path .. virt: clean and modernize the destroy() path cleanup the destroy path with no changes in behaviour.

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-04-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 3: * #1309884::Update tracker: OK * Set MODIFIED::bug 1309884#1309884IGNORE, not oVirt

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-04-01 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55534 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 2: Verified+1 verified running destroy() from Engine - also injecting failures -- To view, visit

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55534 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 2: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug *

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 1: Code-Review+1 Oh, it's a backport. -- To view, visit https://gerrit.ovirt.org/55534 To

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/55534/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: clean and modernize the destroy() path .. Patch Set 1: * #1309884::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1309884::OK, public bug *

Change in vdsm[ovirt-3.6]: virt: clean and modernize the destroy() path

2016-03-31 Thread fromani
Hello Dan Kenigsberg, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/55534 to review the following change. Change subject: virt: clean and modernize the destroy() path .. virt: