Warnings in undo.o

2016-02-16 Fir de Conversatie Axel Bender
Compiling gvim (Windows 7, gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 4.8.4) the following warning appears in undo.c: gcc -c -Iproto -DWIN32 -DWINVER=0x0500 -D_WIN32_WINNT=0x0500 -DHAVE_PATHDEF -DFEAT_BIG -DMS_WIN64 -DHAVE_GETTEXT -DHAVE_LOCALE_H -DDYNAMIC_GETTEXT -DFEAT_OLE

Re: [vim] Patch 1222 doesn't apply (#637)

2016-02-16 Fir de Conversatie Christian Brabandt
On Di, 16 Feb 2016, Gary Johnson wrote: > On 2016-02-16, mattn wrote: > > could you please quote diff with triple backticks like below? > > > > ``` > > *** ../vim-7.4.1221/src/version.c 2016-01-31 14:36:53.419217174 +0100 > > --- src/version.c 2016-01-31 14:49:11.627530146 +0100 > > --- 222,226

[patch] tiny build broken

2016-02-16 Fir de Conversatie Christian Brabandt
Bram, this patch fixes a tiny build link problem, by adding some ifdefs Also I just noticed there is another problem with the windows builds: https://ci.appveyor.com/project/chrisbra/vim-win32-installer/build/21/job/2245l7loh1lefoc9#L479 eval.obj : error LNK2001: unresolved external symbol

make_cyg_ming.mak contains trailing spaces

2016-02-16 Fir de Conversatie Axel Bender
Just a "cosmetical" change: make_cyg_ming.mak contains trailing spaces. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message

Re: [vim] Compile Vim 7.4.1342 Error (#641)

2016-02-16 Fir de Conversatie Cesar Romani
It has no effect. Even with the above patch I get the same error: objZi386/eval.o:eval.c:(.text+0x356b): undefined reference to `get_job_options' collect2.exe: error: ld returned 1 exit status make: *** [vim.exe] Error 1 Error by compiling vim.exe

Re: [vim] Patch 1222 doesn't apply (#637)

2016-02-16 Fir de Conversatie Gary Johnson
On 2016-02-16, mattn wrote: > could you please quote diff with triple backticks like below? > > ``` > *** ../vim-7.4.1221/src/version.c 2016-01-31 14:36:53.419217174 +0100 > --- src/version.c 2016-01-31 14:49:11.627530146 +0100 > --- 222,226 > ... content ... > ``` Why? Regards, Gary --

Re: [vim] Vim cryptmethod is not authenticated (#638)

2016-02-16 Fir de Conversatie Tony Mechelynck
On Tue, Feb 16, 2016 at 10:27 PM, Matthew Winn wrote: > On 16/02/16 16:43, Aaron Toponce (Vim Github Repository) wrote: >> >> The goal with this issue, is to provide authenticated encryption to the >> ciphertext, so not only is data integrity maintained, but also

Re: Patch 7.4.1341

2016-02-16 Fir de Conversatie Andrei Olsen
Console version fails to compile. eval.c:14539: undefined reference to `get_job_options' because it's defined inside #ifdef FEAT_CHANNEL -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information,

I am really impressed

2016-02-16 Fir de Conversatie Elimar Riesebieter
Hi Bram, hi vim devalopers, I am really impressed about how our project is moved forward. VIM can claim that it is in a good shape towards the vim-dev community. And I want want so say thanks to all who are anticipating the development and a really respectful thank to Bram, who coordinates all

Re: [vim] Vim cryptmethod is not authenticated (#638)

2016-02-16 Fir de Conversatie Matthew Winn
On 16/02/16 16:43, Aaron Toponce (Vim Github Repository) wrote: The goal with this issue, is to provide authenticated encryption to the ciphertext, so not only is data integrity maintained, but also prevents external modification without knowledge of the authentication key to produce a new

Patch 7.4.1342

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1342 Problem:On Mac OS/X the waittime must be > 0 for connect to work. Solution: Use select() in a different way. (partly by Kazunobu Kuriyama) Always use a waittime of 1 or more. Files: src/eval.c, src/channel.c, src/testdir/test_channel.vim ***

Patch 7.4.1341

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1341 Problem:It's difficult to add more arguments to ch_sendraw() and ch_sendexpr(). Solution: Make the third option a dictionary. Files: src/eval.c, src/structs.h, src/channel.c, src/os_unix.c, src/os_win32.c, src/proto/channel.pro,

Re: Patch 7.4.1339

2016-02-16 Fir de Conversatie John Marriott
On 17-Feb-2016 6:12 AM, Bram Moolenaar wrote: Patch 7.4.1339 Problem:Warnings when building the GUI with MingW. (Cesar Romani) Solution: Add type cats. (Yasuhiro Matsumoto) Files: src/edit.c, src/gui_w32.c, src/gui_w48.c, src/os_mswin.c, src/os_win32.c I get an error

[BUG] Put contents of dot register in visual mode

2016-02-16 Fir de Conversatie Bart Malanczuk
In the following code snippet I'm trying to replace parameter name from param to value, using dot register (last inserted text): function execute(param){ var result = param.paramProcessing(); 1. I place the cursor on the in first occurence of param (in the brackets) 2. I type `ciwvalue` to

Patch 7.4.1339

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1339 Problem:Warnings when building the GUI with MingW. (Cesar Romani) Solution: Add type cats. (Yasuhiro Matsumoto) Files: src/edit.c, src/gui_w32.c, src/gui_w48.c, src/os_mswin.c, src/os_win32.c *** ../vim-7.4.1338/src/edit.c 2016-02-09 21:24:40.988610334

Re: Patch 7.4.1334

2016-02-16 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > Thanks. Could you please take a look this too. > > https://gist.github.com/mattn/e20e0a38d46f52b3dd92 > > still warnings with GUI=yes. Thanks! -- Facepalm statement #2: "If there is a country without immigrants I'm going to move there" /// Bram Moolenaar --

Re: Error on building vim.exe with latest pull

2016-02-16 Fir de Conversatie Bram Moolenaar
Cesar Romani wrote: > On 16/02/2016 10:48 a.m., Cesar Romani wrote: > > On 16/02/2016 10:10 a.m., mattn wrote: > > > https://gist.github.com/8b6c478ca91e985452b8 > > > > > > This will fix your problem maybe. > > > > Yes, it does it. Thanks, > > > > Regards, > > > > It compiles fine,

Patch 7.4.1338

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1338 (after 7.4.1336) Problem:Another part of the change is missing. Solution: Type os_unix.c right this time. Files: src/os_unix.c *** ../vim-7.4.1337/src/os_unix.c 2016-02-15 23:08:57.263566140 +0100 --- src/os_unix.c 2016-02-16 18:42:10.799729795 +0100

Patch 7.4.1337

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1337 (after 7.4.1336) Problem:Part of the change missing. Solution: Add changes to eval.c Files: src/eval.c *** ../vim-7.4.1336/src/eval.c 2016-02-16 15:06:54.657635357 +0100 --- src/eval.c 2016-02-16 18:54:11.952235823 +0100 *** *** 7535,7541 /*

Patch 7.4.1336

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1336 Problem:Channel NL mode is not supported yet. Solution: Add NL mode support to channels. Files: src/channel.c, src/netbeans.c, src/structs.h, src/os_unix.d, src/os_win32.c, src/proto/channel.pro, src/proto/os_unix.pro, src/proto/os_win32.pro,

Re: Upcoming incompatible change

2016-02-16 Fir de Conversatie Christian J. Robinson
On Tue, 16 Feb 2016, Bram Moolenaar wrote: I hope the change won't cause too much trouble. It's better to change it now, the longer we wait the more problems the change causes. My view is that it's a feature in development and subject to change until it's working well and finalized. When

Re: Patch 7.4.1334

2016-02-16 Fir de Conversatie mattn
Thanks. Could you please take a look this too. https://gist.github.com/mattn/e20e0a38d46f52b3dd92 still warnings with GUI=yes. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

2016-02-16 Fir de Conversatie Charles Campbell
Josh Reichardt wrote: > > OS: |OS X 10.11.3| > vim version: |7.4 (2013 Aug 10, compiled Feb 11 2016 11:34:55)| > Info for filetype: |sh| > > To reproduce: > > |#!/usr/bin/env bash if ! which "xcode-select" > /dev/null; then echo > "No xcode" else xcode-select --install fi | > > The select in

Re: Error on building vim.exe with latest pull

2016-02-16 Fir de Conversatie Cesar Romani
On 16/02/2016 10:48 a.m., Cesar Romani wrote: > On 16/02/2016 10:10 a.m., mattn wrote: > > https://gist.github.com/8b6c478ca91e985452b8 > > > > This will fix your problem maybe. > > Yes, it does it. Thanks, > > Regards, > It compiles fine, but I have some warnings: [...]

Re: Channel & job design

2016-02-16 Fir de Conversatie Bram Moolenaar
赵启明赵 wrote: > I've tried these simple code for job control > > let job = job_start('echo abc', {'waittime': 1}) > let channel = job_getchannel(job) > let output = ch_readraw(channel) > call setline(1, output) > > And I got NULL character inserted at the end of first line, I thought > is should

Upcoming incompatible change

2016-02-16 Fir de Conversatie Bram Moolenaar
Currently ch_sendexpr() and ch_sendraw() have a third argument that is the callback function. If we want to add more options, such as a timeout, we would need to add more arguments. I think it's better if we make the third argument a dictionary with options. Like we have it in a few other

Re: Error on building vim.exe with latest pull

2016-02-16 Fir de Conversatie Cesar Romani
On 16/02/2016 10:10 a.m., mattn wrote: > https://gist.github.com/8b6c478ca91e985452b8 > > This will fix your problem maybe. Yes, it does it. Thanks, Regards, -- Cesar -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying

Patch 7.4.1335

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1335 Problem:Can't build on MS-Windows with +job but without +channel. (Cesar Romani) Solution: Add #ifdefs. (Yasuhiro Matsumoto) Files: src/os_win32.c *** ../vim-7.4.1334/src/os_win32.c 2016-02-16 15:06:54.669635233 +0100 --- src/os_win32.c 2016-02-16

Re: Error on building vim.exe with latest pull

2016-02-16 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > https://gist.github.com/8b6c478ca91e985452b8 > > This will fix your problem maybe. Thanks! -- Bravely bold Sir Robin, rode forth from Camelot, He was not afraid to die, Oh Brave Sir Robin, He was not at all afraid to be killed in nasty ways

Re: Error on building vim.exe with latest pull

2016-02-16 Fir de Conversatie mattn
https://gist.github.com/8b6c478ca91e985452b8 This will fix your problem maybe. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this

Re: remove many many compilation warnings on mingw

2016-02-16 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > After Patch 7.4.1323, mingw vomit too many compilation warnings which is > hidden by -w flag. Below is a patch to remove them. > > https://gist.github.com/mattn/6542c52e98dce6923fc3 Thanks. There are a few where I don't understand what the warning would be: ---

Patch 7.4.1334

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1334 Problem:Many compiler warnings with MingW. Solution: Add type casts. (Yasuhiro Matsumoto) Files: src/channel.c, src/dosinst.h, src/eval.c, src/ex_cmds2.c, src/ex_getln.c, src/fileio.c, src/if_cscope.c, src/if_perl.xs, src/if_python.c,

Re: [vim] Vim cryptmethod is not authenticated (#638)

2016-02-16 Fir de Conversatie Mosh
I think the vim-crypt is secure and safe as is implemented; the only reason someone would want it removed is because they are unable to bruteforce crack it without a MAC to check if they succeeded. On Tue, Feb 16, 2016 at 9:44 AM, Aaron Toponce wrote: > When using

Patch 7.4.1333

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1333 Problem:Channel test fails on non-darwin builds. Solution: Add the "osx" feature and test for that. (Kazunobu Kuriyama) Files: runtime/doc/eval.txt, src/eval.c, src/testdir/test_channel.vim *** ../vim-7.4.1332/runtime/doc/eval.txt2016-02-13 17:04:08.426819018

Re: [Patch] Run test_channel successfully for non-darwin Vim on OS X

2016-02-16 Fir de Conversatie Bram Moolenaar
Kazunobu Kuriyama wrote: > Thanks to many, Vim now passes test_channel successfully on OS X. > > Unfortunately, this is not the case when Vim is built with the option > --disable-darwin. > > This is not because darwin-disabled Vim is inherently incapable of the > channel feature, but just

[Patch] Run test_channel successfully for non-darwin Vim on OS X

2016-02-16 Fir de Conversatie Kazunobu Kuriyama
Hi, Thanks to many, Vim now passes test_channel successfully on OS X. Unfortunately, this is not the case when Vim is built with the option --disable-darwin. This is not because darwin-disabled Vim is inherently incapable of the channel feature, but just because there's no has() variable to

Patch 7.4.1332

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1332 Problem:Problem using Python3 when compiled with MingW. Solution: Define PYTHON3_HOME as a wide character string. (Yasuhiro Matsumoto) Files: src/Make_cyg_ming.mak *** ../vim-7.4.1331/src/Make_cyg_ming.mak 2016-02-15 22:45:05.998588485 +0100 ---

Re: [patch] remove unused save-cursor statement in matchparen plugin

2016-02-16 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > Bram, > I assume, this line was added by accident. It is not used and I think it > can be removed (also indentation is wrong). It might be, that I caused > this from a previous patch, so let's just remove it for now. That was a leftover from testing the curswant

Re: python3 crash on mingw

2016-02-16 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > in if_python3.c > --- > #ifdef PYTHON3_HOME > # ifdef DYNAMIC_PYTHON3 > if (mch_getenv((char_u *)"PYTHONHOME") == NULL) > # endif > Py_SetPythonHome(PYTHON3_HOME); > #endif > --- > >

Patch 7.4.1331

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1331 Problem:Crash when closing the channel in a callback. (Christian J. Robinson) Solution: Take the callback out of the list before invoking it. Files: src/channel.c, src/testdir/test_channel.vim *** ../vim-7.4.1330/src/channel.c 2016-02-16

Re: Patch 7.4.1322

2016-02-16 Fir de Conversatie Bram Moolenaar
Christian J. Robinson wrote: > On Mon, 15 Feb 2016, Bram Moolenaar wrote: > > > Christian J. Robinson wrote: > > > >> On Mon, 15 Feb 2016, Bram Moolenaar wrote: > >> > >>> Patch 7.4.1322 > >>> Problem:Crash when unletting the variable that holds the channel in a > >>>callback

Re: Patch 7.4.1324

2016-02-16 Fir de Conversatie Bram Moolenaar
Yasuhiro Matsumoto wrote: > > > This is trival fixes. > > https://gist.github.com/mattn/baec9ece5749d2d90368 Thanks! However, I don't think we need this change: @@ -381,7 +381,8 @@ channel_gui_register_one(channel_T *channel, int which) # ifdef FEAT_GUI_W32 /* Tell Windows we are

Patch 7.4.1330

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1330 Problem:fd_read() has an unused argument. Solution: Remove the timeout. (Yasuhiro Matsumoto) Files: src/channel.c *** ../vim-7.4.1329/src/channel.c 2016-02-16 12:44:21.994282583 +0100 --- src/channel.c 2016-02-16 13:07:40.027754420 +0100 *** ***

Re: Crash with channel

2016-02-16 Fir de Conversatie Bram Moolenaar
Yukihiro Nakadaira wrote: > Steps to reproduce: > :" 1 > :echo ch_open("noserver") > > :" 2 > :let c = ch_open("noserver") > :let d = c > > > There is no NULL check for fail channel. > And two typos in message. Thanks! -- This sentence is not sure that it exists, but if it does,

Patch 7.4.1329

2016-02-16 Fir de Conversatie Bram Moolenaar
Patch 7.4.1329 Problem:Crash when using channel that failed to open. Solution: Check for NULL. Update messages. (Yukihiro Nakadaira) Files: src/channel.c, src/eval.c, src/testdir/test_channel.vim *** ../vim-7.4.1328/src/channel.c 2016-02-15 22:37:33.843330641 +0100 ---

Re: Channel & job design

2016-02-16 Fir de Conversatie 赵启明赵
I've tried these simple code for job control let job = job_start('echo abc', {'waittime': 1}) let channel = job_getchannel(job) let output = ch_readraw(channel) call setline(1, output) And I got NULL character inserted at the end of first line, I thought is should be trimmed by vim. -- --

remove many many compilation warnings on mingw

2016-02-16 Fir de Conversatie mattn
After Patch 7.4.1323, mingw vomit too many compilation warnings which is hidden by -w flag. Below is a patch to remove them. https://gist.github.com/mattn/6542c52e98dce6923fc3 - mattn -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text