Re: [patch] Fix quickfix handling of long lines

2016-04-30 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sat, Apr 30, 2016 at 10:50 AM, Bram Moolenaar wrote: > > Anton Lindqvist wrote: > >> > > I managed to crash Vim yesterday due to a off-by-one allocation bug >> > > related to the quickfix changes. Fixed in the attached patch. >> > >> > Well, if I run test_quickfix after including this patc

Re: Patch 7.4.1784

2016-04-30 Fir de Conversatie Kazunobu Kuriyama
2016-04-30 22:17 GMT+09:00 Bram Moolenaar : > > Kelvin Lee wrote: > > > Patch 7.4.1784 is problematic. > > > > On both FreeBSD (10.3) and Linux (Ubuntu 16.04), the follow error would > happen upon starting gvim: > > > > X Error of failed request: BadValue (integer parameter out of range for > ope

Re: [patch] Fix quickfix handling of long lines

2016-04-30 Fir de Conversatie Bram Moolenaar
Anton Lindqvist wrote: > > > I managed to crash Vim yesterday due to a off-by-one allocation bug > > > related to the quickfix changes. Fixed in the attached patch. > > > > Well, if I run test_quickfix after including this patch, Vim crashes. > > I found that a statement was missing, setting lin

Re: [vim/vim] patch 7.4.1806 (8e3d1b6)

2016-04-30 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > 2016-4-30(Sat) 22:43:49 UTC+9 h_east: > > Hi Bram, > > > > 2016-4-30(Sat) 22:26:32 UTC+9 h_east: > > > &gcol? maybe &tgc. > > > > Patch attached. > > Please check it. > > Other related document patch attached. > Please check it out. Thanks. -- It is illegal for a d

Patch 7.4.1811

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1811 Problem:Netbeans channel gets garbage collected. Solution: Set reference in nb_channel. Files: src/eval.c, src/netbeans.c, src/proto/netbeans.pro *** ../vim-7.4.1810/src/eval.c 2016-04-29 22:58:25.618876680 +0200 --- src/eval.c 2016-04-30 17:57:27.996792806 +0200

Patch 7.4.1810

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1810 Problem:Sending DETACH after a channel was closed isn't useful. Solution: Only add DETACH for a netbeans channel. Files: src/channel.c, src/testdir/test_channel.vim *** ../vim-7.4.1809/src/channel.c 2016-04-30 16:07:18.607060334 +0200 --- src/channel.c 2016-

Patch 7.4.1809

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1809 (after 7.4.1808) Problem:Using wrong short option name for 'termguicolors'. Solution: Use the option name. Files: runtime/optwin.vim *** ../vim-7.4.1808/runtime/optwin.vim 2016-04-30 16:13:06.811224602 +0200 --- runtime/optwin.vim 2016-04-30 16:47:38.356211520 +0200 *

Test failure, 7.4.1808, OS X

2016-04-30 Fir de Conversatie Manuel Ortega
Alas, `make test` fails on OS X now: Executing Test_strcharpart() "test_alot_utf8.res" [New] 0L, 0C written "messages" 248L, 6829C written VIMRUNTIME=../../runtime; export VIMRUNTIME; ../vim -f -u unix.vim -U NONE --noplugin --not-a-term -u NONE -U NONE -S runtest.vim test_alot.vim Test results:

Patch 7.4.1808

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1808 (after 7.4.1806) Problem:Using wrong feature name to check for 'termguicolors'. Solution: Use the right feature name. (Ken Takata) Files: runtime/optwin.vim *** ../vim-7.4.1807/runtime/optwin.vim 2016-04-30 15:17:06.949150618 +0200 --- runtime/optwin.vim 2016-04-30 16

Re: Patch 7.4.1806

2016-04-30 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2016/4/30 Sat 22:17:39 UTC+9 Bram Moolenaar wrote: > > Patch 7.4.1806 > > Problem:'termguicolors' option missing from the options window. > > Solution: Add the entry. > > Files: runtime/optwin.vim > > > + if has("termtruecolor") > > Should be "termguicolors". Of

Patch 7.4.1807

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1807 Problem:Test_out_close_cb sometimes fails. Solution: Always write DETACH to out, not err. Files: src/channel.c, src/testdir/test_channel.vim *** ../vim-7.4.1806/src/channel.c 2016-04-26 20:30:03.360916990 +0200 --- src/channel.c 2016-04-30 16:00:42.391467986

Re: [vim/vim] patch 7.4.1806 (8e3d1b6)

2016-04-30 Fir de Conversatie h_east
Hi Bram, 2016-4-30(Sat) 22:43:49 UTC+9 h_east: > Hi Bram, > > 2016-4-30(Sat) 22:26:32 UTC+9 h_east: > > &gcol? maybe &tgc. > > Patch attached. > Please check it. Other related document patch attached. Please check it out. -- Best regards, Hirohito Higashi (a.k.a. h_east) -- -- You received t

Re: [patch] Fix quickfix handling of long lines

2016-04-30 Fir de Conversatie Anton Lindqvist
On Sat, Apr 30, 2016 at 01:17:22PM +0200, Bram Moolenaar wrote: > > Anton Lindqvist wrote: > > > I managed to crash Vim yesterday due to a off-by-one allocation bug > > related to the quickfix changes. Fixed in the attached patch. > > Well, if I run test_quickfix after including this patch, Vim

Re: [vim/vim] patch 7.4.1806 (8e3d1b6)

2016-04-30 Fir de Conversatie h_east
Hi Bram, 2016-4-30(Sat) 22:26:32 UTC+9 h_east: > &gcol? maybe &tgc. Patch attached. Please check it. -- Best regards, Hirohito Higashi (a.k.a. h_east) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more info

Re: Patch 7.4.1806

2016-04-30 Fir de Conversatie Ken Takata
Hi Bram, 2016/4/30 Sat 22:17:39 UTC+9 Bram Moolenaar wrote: > Patch 7.4.1806 > Problem:'termguicolors' option missing from the options window. > Solution: Add the entry. > Files: runtime/optwin.vim > + if has("termtruecolor") Should be "termguicolors". Regards, Ken Takata -- -- Yo

Re: Patch 7.4.1784

2016-04-30 Fir de Conversatie Bram Moolenaar
Kelvin Lee wrote: > Patch 7.4.1784 is problematic. > > On both FreeBSD (10.3) and Linux (Ubuntu 16.04), the follow error would > happen upon starting gvim: > > X Error of failed request: BadValue (integer parameter out of range for > operation) > Major opcode of failed request: 91 (X_Quer

Patch 7.4.1806

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1806 Problem:'termguicolors' option missing from the options window. Solution: Add the entry. Files: runtime/optwin.vim *** ../vim-7.4.1805/runtime/optwin.vim 2016-04-21 14:05:16.299162032 +0200 --- runtime/optwin.vim 2016-04-30 15:15:35.778200904 +0200 *** ***

Patch 7.4.1805

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1805 Problem:Running tests in shadow dir fails. Solution: Link the samples directory Files: src/Makefile *** ../vim-7.4.1804/src/Makefile2016-04-30 12:32:47.995276733 +0200 --- src/Makefile2016-04-30 15:07:11.272048617 +0200 *** *** 2608,2613

Re: Patch 7.4.1784

2016-04-30 Fir de Conversatie Kelvin Lee
Patch 7.4.1784 is problematic. On both FreeBSD (10.3) and Linux (Ubuntu 16.04), the follow error would happen upon starting gvim: X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 91 (X_QueryColors) Value in failed request:

Re: [patch] Fix `make uninstall`

2016-04-30 Fir de Conversatie Kazunobu Kuriyama
2016-04-30 19:31 GMT+09:00 Bram Moolenaar : > > Kazunobu Kuriyama wrote: > > > Recently `make uninstall` hasn’t been done well, leaving `$prefix/vim/*` > > behind after it is executed. > > > > In fact, `make uninstall_runtime` doesn’t take account of `rgb.txt` which > > has been installed at place

Patch 7.4.1804

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1804 Problem:Can't use Vim as MANPAGER. Solution: Add manpager.vim. (Enno Nagel, closes #491) Files: runtime/doc/filetype.txt, runtime/plugin/manpager.vim *** ../vim-7.4.1803/runtime/doc/filetype.txt2013-08-10 13:24:53.0 +0200 --- runtime/doc/filetype.txt201

Re: [patch] Fix `make uninstall`

2016-04-30 Fir de Conversatie Kazunobu Kuriyama
2016-04-30 19:31 GMT+09:00 Bram Moolenaar : > > Kazunobu Kuriyama wrote: > > > Recently `make uninstall` hasn’t been done well, leaving `$prefix/vim/*` > > behind after it is executed. > > > > In fact, `make uninstall_runtime` doesn’t take account of `rgb.txt` which > > has been installed at place

Re: [patch] Fix undrawn menu item separators for GTK+ 3.20

2016-04-30 Fir de Conversatie Bram Moolenaar
Kazunobu Kuriyama wrote: > IIRC and IIUC :), there has been a convention that menu items having no > label were interpreted as menu separators and drawn as such things on menu > panes. > > Actually, the gtk2 code has made use of that convention (gui_gtk.c:784). > > Now we have gtk 3.20 which se

Patch 7.4.1803

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1803 Problem:GTK3 doesn't handle menu separaters properly. Solution: Use gtk_separator_menu_item_new(). (Kazunobu Kuriyama) Files: src/gui_gtk.c *** ../vim-7.4.1802/src/gui_gtk.c 2016-02-27 18:07:39.652009479 +0100 --- src/gui_gtk.c 2016-04-30 13:23:17.740681068

Patch 7.4.1802

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1802 Problem:Quickfix doesn't handle long lines well, they are split. Solution: Drop characters after a limit. (Anton Lindqvist) Files: src/quickfix.c, src/testdir/test_quickfix.vim, src/testdir/samples/quickfix.txt *** ../vim-7.4.1801/src/quickfix.c 2016-04

Re: [patch] Fix quickfix handling of long lines

2016-04-30 Fir de Conversatie Bram Moolenaar
Anton Lindqvist wrote: > I managed to crash Vim yesterday due to a off-by-one allocation bug > related to the quickfix changes. Fixed in the attached patch. Well, if I run test_quickfix after including this patch, Vim crashes. I found that a statement was missing, setting linelen to len. I did s

Patch 7.4.1801

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1801 Problem:Make uninstall leaves file behind. Solution: Delete rgb.txt. (Kazunobu Kuriyama) Files: src/Makefile *** ../vim-7.4.1800/src/Makefile2016-04-22 12:24:44.559573688 +0200 --- src/Makefile2016-04-30 12:31:50.423936615 +0200 *** *** 2535,

Re: [patch] Fix `make uninstall`

2016-04-30 Fir de Conversatie Bram Moolenaar
Kazunobu Kuriyama wrote: > Recently `make uninstall` hasn’t been done well, leaving `$prefix/vim/*` > behind after it is executed. > > In fact, `make uninstall_runtime` doesn’t take account of `rgb.txt` which > has been installed at place since Patch 7.4.1775. > > Attached is a patch for fixing

Re: Patch 7.4.1799

2016-04-30 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2016/4/30 Sat 5:59:42 UTC+9 Bram Moolenaar wrote: > > Patch 7.4.1799 > > Problem:'guicolors' is a confusing option name. > > Solution: Use 'termguicolors' instead. (Hirohito Higashi) > > Files: runtime/doc/options.txt, runtime/doc/term.txt, > > runtime/d

Patch 7.4.1800

2016-04-30 Fir de Conversatie Bram Moolenaar
Patch 7.4.1800 (after 7.4.1799) Problem:Unnecessary #ifdef. Solution: Just use USE_24BIT. (Ken Takata) Files: src/syntax.c *** ../vim-7.4.1799/src/syntax.c2016-04-29 22:58:25.626876587 +0200 --- src/syntax.c2016-04-30 12:24:29.496977356 +0200 *** *** 7795,7

Re: [vim/vim] propose vim as manpager that syntax highlights and follows symlinks (#491)

2016-04-30 Fir de Conversatie Enno
Ok, got it. The documentation should now reflect this. Now on FreeBSD (and perhaps Amiga OS, BeOS, ...), another approach is needed to start :Man. Your suggestion, `MANPAGER = env MAN_PN=1 vim +...` is an elegant work around. Instead of $MAN_PN, the manpage and section seems, by a superficial c

Re: [patch] Fix quickfix handling of long lines

2016-04-30 Fir de Conversatie Anton Lindqvist
I managed to crash Vim yesterday due to a off-by-one allocation bug related to the quickfix changes. Fixed in the attached patch. -- :wq -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit

[patch] Fix undrawn menu item separators for GTK+ 3.20

2016-04-30 Fir de Conversatie Kazunobu Kuriyama
Hi, IIRC and IIUC :), there has been a convention that menu items having no label were interpreted as menu separators and drawn as such things on menu panes. Actually, the gtk2 code has made use of that convention (gui_gtk.c:784). Now we have gtk 3.20 which seemingly breaks it. The attached pat

[patch] Fix `make uninstall`

2016-04-30 Fir de Conversatie Kazunobu Kuriyama
Hi, Recently `make uninstall` hasn’t been done well, leaving `$prefix/vim/*` behind after it is executed. In fact, `make uninstall_runtime` doesn’t take account of `rgb.txt` which has been installed at place since Patch 7.4.1775. Attached is a patch for fixing the issue, which I hope goes well w