Re: Patch 8.0.0389

2017-02-28 Fir de Conversatie Christian Brabandt
On Di, 28 Feb 2017, James McCoy wrote: > Is view_util.vim a new file that was supposed to be committed? As just mentioned to me yesterday by you ;) https://github.com/neovim/neovim/pull/5878#discussion_r103526718 it was 8.0.0311: https://github.com/vim/vim/releases/tag/v8.0.0311 Best, Christian

Re: Patch 8.0.0275

2017-02-28 Fir de Conversatie Christian Brabandt
Hi Bram! On Di, 28 Feb 2017, Bram Moolenaar wrote: > > Christian Brabandt wrote: > > > On Di, 31 Jan 2017, Bram Moolenaar wrote: > > > > > Patch 8.0.0275 > > > Problem:When checking for CTRL-C typed the GUI may detect a screen > > > resize > > > and redraw the screen, causing

Re: suspicious integer overflow in src/spellfile.c:1607

2017-02-28 Fir de Conversatie Nikolay Aleksandrovich Pavlov
2017-02-28 23:30 GMT+03:00 Vekktone Official : > On Tuesday, February 7, 2017 at 9:36:20 PM UTC-6, shqking wrote: >> Hi all. >> >> Suspicious integer overflow is found in >> src/spellfile.c:1607.(https://github.com/vim/vim/blob/master/src/spellfile.c#L1607) >> >> Signed integer overflow might occu

Re: suspicious integer overflow in src/spellfile.c:1607

2017-02-28 Fir de Conversatie Vekktone Official
On Tuesday, February 7, 2017 at 9:36:20 PM UTC-6, shqking wrote: > Hi all. > > Suspicious integer overflow is found in > src/spellfile.c:1607.(https://github.com/vim/vim/blob/master/src/spellfile.c#L1607) > > Signed integer overflow might occur for len * sizeof(int) at line 1607, if > len can h

Re: Patch 8.0.0389

2017-02-28 Fir de Conversatie Dominique Pellé
James McCoy wrote: > On Tue, Feb 28, 2017 at 10:51:29PM +0100, Bram Moolenaar wrote: >> >> Patch 8.0.0389 >> Problem:Test for arabic does not check what is displayed. >> Solution: Improve what is asserted. (Dominique Pelle, closes #1523) >> Add a first shaping test. >> Files:

Re: Patch 8.0.0389

2017-02-28 Fir de Conversatie James McCoy
On Tue, Feb 28, 2017 at 10:51:29PM +0100, Bram Moolenaar wrote: > > Patch 8.0.0389 > Problem:Test for arabic does not check what is displayed. > Solution: Improve what is asserted. (Dominique Pelle, closes #1523) > Add a first shaping test. > Files: src/testdir/test_arabic.v

Patch 8.0.0389

2017-02-28 Fir de Conversatie Bram Moolenaar
Patch 8.0.0389 Problem:Test for arabic does not check what is displayed. Solution: Improve what is asserted. (Dominique Pelle, closes #1523) Add a first shaping test. Files: src/testdir/test_arabic.vim *** ../vim-8.0.0388/src/testdir/test_arabic.vim 2017-02-27 21:48:06.217

Patch 8.0.0388

2017-02-28 Fir de Conversatie Bram Moolenaar
Patch 8.0.0388 Problem:filtering lines through "cat", without changing the line count, changes manual folds. Solution: Change how marks and folds are adjusted. (Matthew Malcomson, from neovim #6194. Files: src/fold.c, src/testdir/test_fold.vim *** ../vim-8.0.03

Re: [patch] neovim patches

2017-02-28 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > Another one: > https://github.com/neovim/neovim/pull/6194 > > I think the test case can be easily converted to a new style test. It > should be run once with fdm=manual and once with fdm=marker to see the > difference. Thanks. Yes, converting the test isn't diffic

Re: Patch 8.0.0275

2017-02-28 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Di, 31 Jan 2017, Bram Moolenaar wrote: > > > Patch 8.0.0275 > > Problem:When checking for CTRL-C typed the GUI may detect a screen > > resize > > and redraw the screen, causing trouble. > > Solution: Set updating_screen in ui_breakcheck(). > > Fi

Re: [patch] TeX: avoid indent after one-line environment (runtime/indent/tex.vim)

2017-02-28 Fir de Conversatie Charles E Campbell
Eisuke Kawashima wrote: > Dear DrChip, > >> I suggest sending your patch to the indent/tex.vim maintainer. It might >> even get incorporated that way! >> >> Chip Campbell >> >> P.S. Look at $VIMRUNTIME/indent/tex.vim and you'll see YiChao's email >> address. > I put the maintainer's address in CC

Patch 8.0.0387

2017-02-28 Fir de Conversatie Bram Moolenaar
Patch 8.0.0387 Problem:compiler warnings Solution: Add type casts. (Christian Brabandt) Files: src/channel.c, src/memline.c *** ../vim-8.0.0386/src/channel.c 2017-02-06 21:56:04.996335436 +0100 --- src/channel.c 2017-02-28 21:17:38.970334357 +0100 *** *** 1966,

Re: fix some warnings

2017-02-28 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > While looking at the appveyor build log, I noticed some warnings for the > 64bit builds. This patch fixes them: Thanks! -- Tips for aliens in New York: Land anywhere. Central Park, anywhere. No one will care or indeed even notice. -- Douglas Adams,

Re: [patch] TeX: avoid indent after one-line environment (runtime/indent/tex.vim)

2017-02-28 Fir de Conversatie Eisuke Kawashima
Dear DrChip, > I suggest sending your patch to the indent/tex.vim maintainer. It might > even get incorporated that way! > > Chip Campbell > > P.S. Look at $VIMRUNTIME/indent/tex.vim and you'll see YiChao's email > address. I put the maintainer's address in CC noted in the file, as you describ

Re: [patch] neovim patches

2017-02-28 Fir de Conversatie Christian Brabandt
Another one: https://github.com/neovim/neovim/pull/6194 I think the test case can be easily converted to a new style test. It should be run once with fdm=manual and once with fdm=marker to see the difference. Best, Christian -- Sobald einer in einer Sache Meister geworden ist, sollte er in ein

fix some warnings

2017-02-28 Fir de Conversatie Christian Brabandt
While looking at the appveyor build log, I noticed some warnings for the 64bit builds. This patch fixes them: diff --git a/src/channel.c b/src/channel.c index d2439a95d..0dab895da 100644 --- a/src/channel.c +++ b/src/channel.c @@ -1966,7 +1966,7 @@ channel_parse_json(channel_T *channel, ch_part_T

Re: Patch 8.0.0275

2017-02-28 Fir de Conversatie Christian Brabandt
On Di, 31 Jan 2017, Bram Moolenaar wrote: > Patch 8.0.0275 > Problem:When checking for CTRL-C typed the GUI may detect a screen resize > and redraw the screen, causing trouble. > Solution: Set updating_screen in ui_breakcheck(). > Files: src/ui.c Either this patch or 274¹ b

Re: make v:shell_error writable

2017-02-28 Fir de Conversatie Justin M. Keyes
On Tue, Feb 28, 2017 at 11:09 AM, Christian Brabandt wrote: > On Di, 28 Feb 2017, Justin M. Keyes wrote: > >> To further emphasize the case against writable v:shell_error in particular: >> >> https://github.com/tpope/vim-fugitive/issues/648#issuecomment-282515016 >> >> Because the legacy "shell_er

Re: make v:shell_error writable

2017-02-28 Fir de Conversatie Christian Brabandt
On Di, 28 Feb 2017, Justin M. Keyes wrote: > To further emphasize the case against writable v:shell_error in particular: > > https://github.com/tpope/vim-fugitive/issues/648#issuecomment-282515016 > > Because the legacy "shell_error" variant (which lacks v: prefix) is > still supported for "very

Re: make v:shell_error writable

2017-02-28 Fir de Conversatie Justin M. Keyes
On Wed, Dec 7, 2016 at 8:55 PM, Gary Johnson wrote: > On 2016-12-07, Christian Brabandt wrote: >> Hi Gary! >> >> On Mi, 07 Dez 2016, Gary Johnson wrote: >> >> > On 2016-09-28, Christian Brabandt wrote: >> > >> > > Let me just withdraw the patch. I use async feature now to workaround. >> > >> > I r