Bug: Highlighting of finished terminal window does no take into account number column

2017-07-29 Fir de Conversatie Nazri Ramliy
With 'number' / 'relativenumber' set, the coloring of the finished terminal is not done correctly: https://asciinema.org/a/1mAcCnu9hmnVbZ57txlaHEluz Also there seem to be a little delay (as can be seen in the asciinema link) between exiting the shell and vim realizing that the shell has exited. n

Re: terminal buffer input ctrl-c

2017-07-29 Fir de Conversatie Nikolay Aleksandrovich Pavlov
2017-07-30 0:27 GMT+03:00 Bram Moolenaar : > > Christian wrote: > >> Hi, >> running a terminal buffer and pressing CTRL-C disturbs the statusline >> and the tabline. When running with vim-airline, I see this in the >> statusline: >> >> airline#statusline(1) which is exactly, what the statusline opt

Re: terminal buffer input ctrl-c

2017-07-29 Fir de Conversatie Bram Moolenaar
Christian wrote: > Hi, > running a terminal buffer and pressing CTRL-C disturbs the statusline > and the tabline. When running with vim-airline, I see this in the > statusline: > > airline#statusline(1) which is exactly, what the statusline option is > set to (minus the %!). Same holds for th

Re: Error compiling libvterm/src/pen.c

2017-07-29 Fir de Conversatie Bram Moolenaar
Christian wrote: > Oh, and what would be the way, to detect, whether the current window > shows a terminal (still running or already finished)? Or is it a > terminal buffer? Not implemented yet. You can use term_getjob() and check if you get back a job. But that's clumsy. I suppose we could

Patch 8.0.0809

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0809 Problem:MS-Windows: tests hang. Solution: Delete the XfakeHOME directory. Files: src/testdir/Make_dos.mak, src/testdir/Make_ming.mak *** ../vim-8.0.0808/src/testdir/Make_dos.mak2017-03-16 14:04:47.690789247 +0100 --- src/testdir/Make_dos.mak2017-07-29 23:01:42.

Re: Error compiling libvterm/src/pen.c

2017-07-29 Fir de Conversatie Christian Brabandt
On Sa, 29 Jul 2017, Bram Moolenaar wrote: > Sure. Thanks, that was quick. > Once it really works. I see. When is it considered "works" and will we have a new major version then? Best, Christian -- Die meisten Menschen verwenden mehr Zeit und Kraft daran, um die Probleme herumzureden, als si

Re: Error compiling libvterm/src/pen.c

2017-07-29 Fir de Conversatie Bram Moolenaar
Christian wrote: > Hi, > I haven't followed the development of the terminal feature closely. But > today I got interested and just tried it. Unfortunately, compiling > failed: > > libvterm/src/pen.c: In function ‘setpenattr’: > libvterm/src/pen.c:110:46: error: macro "DEBUG_LOG" passed 4 argum

Patch 8.0.0808

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0808 Problem:Cannot build with terminal feature and DEBUG defined. (Christian Brabandt) Solution: Use DEBUG_LOG3(). Files: src/libvterm/src/pen.c *** ../vim-8.0.0807/src/libvterm/src/pen.c 2017-07-26 21:29:29.124507597 +0200 --- src/libvterm/src/pen.c

Patch 8.0.0807

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0807 Problem:Terminal window can't handle mouse buttons. (Hirohito Higashi) Solution: Implement mouse buttons and many other keys. Ignore the ones that are not implemented. Files: src/terminal.c *** ../vim-8.0.0806/src/terminal.c 2017-07-29 20:07:00.7649404

Patch 8.0.0806

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0806 Problem:Tests may try to create XfakeHOME twice. Solution: Avoid loading setup.vim twice. Files: src/testdir/setup.vim *** ../vim-8.0.0805/src/testdir/setup.vim 2017-07-29 20:39:49.066978764 +0200 --- src/testdir/setup.vim 2017-07-29 22:13:48.446808833 +020

Re: openSUSE Leap 42.3 was released yesterday

2017-07-29 Fir de Conversatie tooth pik
On Wed, Jul 26, 2017 at 11:13 PM, Tony Mechelynck < antoine.mechely...@gmail.com> wrote: > openSUSE Leap 42.3 (Linux) was released yesterday at noon GMT (1pm > BST, 2pm CEST, etc.). I installed it, and it works "reasonably well". > > As always, if you compile your own Vim, I recommend running "mak

Re: [patch] Dust is output to terminal window with 'set mouse=a`

2017-07-29 Fir de Conversatie Bram Moolenaar
Hirohito Higashi wrote: > How to repro.: > - Start vanilla Vim with :terminal. (--enable-terminal is required for > configure.) > $ vim --clean +term > - Left mouse click on terminal window. > > Expected behavior: > - Nothing happens. > > Actual behavior: > - Dust is output. > > > I wrote

terminal buffer input ctrl-c

2017-07-29 Fir de Conversatie Christian Brabandt
Hi, running a terminal buffer and pressing CTRL-C disturbs the statusline and the tabline. When running with vim-airline, I see this in the statusline: airline#statusline(1) which is exactly, what the statusline option is set to (minus the %!). Same holds for the tabline, it shows: airline#ext

Re: Error compiling libvterm/src/pen.c

2017-07-29 Fir de Conversatie Christian Brabandt
On Sa, 29 Jul 2017, Christian Brabandt wrote: > On a related note, should --with-terminal be by default enabled in huge > builds? Oh, and what would be the way, to detect, whether the current window shows a terminal (still running or already finished)? Or is it a terminal buffer? Best, Chris

Error compiling libvterm/src/pen.c

2017-07-29 Fir de Conversatie Christian Brabandt
Hi, I haven't followed the development of the terminal feature closely. But today I got interested and just tried it. Unfortunately, compiling failed: libvterm/src/pen.c: In function ‘setpenattr’: libvterm/src/pen.c:110:46: error: macro "DEBUG_LOG" passed 4 arguments, but takes just 1

Patch 8.0.0805

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0805 Problem:GUI test fails with gnome2. Solution: Set $HOME to an existing directory. Files: src/testdir/setup.vim, src/testdir/runtest.vim *** ../vim-8.0.0804/src/testdir/setup.vim 2017-07-08 17:03:15.369760968 +0200 --- src/testdir/setup.vim 2017-07-29 20:34:

Patch 8.0.0804

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0804 Problem:Running tests fails when stdin is /dev/null. (James McCoy) Solution: Do not bail out from getting input if the --not-a-term argument was given. (closes #1460) Files: src/eval.c, src/evalfunc.c *** ../vim-8.0.0803/src/eval.c 2017-07-27 22:14:55.30596

Patch 8.0.0803

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0803 Problem:Terminal window functions not yet implemented. Solution: Implement several functions. Add a first test. (Yasuhiro Matsumoto, closes #1871) Files: runtime/doc/eval.txt, src/Makefile, src/evalfunc.c, src/proto/evalfunc.pro, src/proto/terminal

[patch] Dust is output to terminal window with 'set mouse=a`

2017-07-29 Fir de Conversatie h_east
Hi Bram and list, How to repro.: - Start vanilla Vim with :terminal. (--enable-terminal is required for configure.) $ vim --clean +term - Left mouse click on terminal window. Expected behavior: - Nothing happens. Actual behavior: - Dust is output. I wrote a patch. The implementation of this

Re: GUI-enabled builds fail test_cmdline tests

2017-07-29 Fir de Conversatie James McCoy
On Sat, Jul 29, 2017 at 03:14:29PM +0200, Bram Moolenaar wrote: > I don't think this change is good when not running tests. We have the > --not-a-term argument specifically for dealing with the situation that > Vim is run without a terminal. How about doing this: That does work. Thanks. Cheers

Patch 8.0.0802

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0802 Problem:After a job exits the last line in the terminal window does not get color attributes. Solution: Fix off-by-one error. Files: src/terminal.c *** ../vim-8.0.0801/src/terminal.c 2017-07-29 15:53:34.761242943 +0200 --- src/terminal.c 2017-07-29

Re: Error in configure argument in src/Makefile comment

2017-07-29 Fir de Conversatie Bram Moolenaar
Tony Mechelynck wrote: > Unlike what is said at line 343 of src/Makefile, --enable-gnome2-check > is not recognized by configure. Nor does (AFAICT) --enable-gnome-check > (without the 2) have any effect. It is possible to compile with Gnome2 > though, but AFAICT this requires --enable-gui=gnome2,

Re: Compile warning -Wmaybe-uninitialized in terminal.c at or maybe before 8.0.798

2017-07-29 Fir de Conversatie Bram Moolenaar
Tony Mechelynck wrote: > gvim with GTK3 GUI was so untractable recently on my new openSUSE 42.3 > system that I decided to "downgrade" to GTK2, which of course means > running "make reconfig" on the new set of configure parameters. > > This "full" compile gave the following warning, which did no

Patch 8.0.0801

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0801 Problem:The terminal window title sometimes still says "running" even though the job has finished. Solution: Also consider the job finished when the channel has been closed. Files: src/terminal.c *** ../vim-8.0.0800/src/terminal.c 2017-07-29 14:52:38.01

Re: GUI-enabled builds fail test_cmdline tests

2017-07-29 Fir de Conversatie Bram Moolenaar
James McCoy wrote: > Since Debian Stretch released, I've been catching up on Vim patches > however everything after 8.0.0314 was failing to build. The GUI-enabled > Vim builds were failing this part of Test_getcmdtype. > > call feedkeys(":call input('Answer?')\", "t") > call feedkeys("MyCmd

Patch 8.0.0800

2017-07-29 Fir de Conversatie Bram Moolenaar
Patch 8.0.0800 Problem:Terminal window scrollback contents is wrong. Solution: Fix handling of multi-byte characters (Yasuhiro Matsumoto) Handle empty lines correctly. (closes #1891) Files: src/terminal.c *** ../vim-8.0.0799/src/terminal.c 2017-07-28 23:16:09.70019371