GTimeVal warning

2020-09-13 Fir de Conversatie tooth pik
is anyone else getting these when they build? [image: image.png] -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sun, Sep 13, 2020 at 6:40 PM Prabir Shrestha wrote: > Actually key_cb won’t make sense since it can be nested key or some > computation with function. It is more of value_cb or can use something like > filtertext_cb or text_cb to align with lsp. > > > I have changed the name to 'text_cb'

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sun, Sep 13, 2020 at 3:45 PM Prabir Shrestha wrote: > Should it be called map_cb instead of callback to align with channels? > > > As this function returns the name of the key, should we call this key_cb instead? - Yegappan -- -- You received this message from the "vim_dev" maillist.

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sun, Sep 13, 2020 at 2:44 PM Prabir Shrestha wrote: > Would it be possible to take a dict but instead of using key or callback > name it map or something else but make the inner implementation smarter? > > let result = matchfuzzy(items, 'search', { 'map': 'v:val["word"]' }) > > If map is

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Sun, Sep 13, 2020 at 12:55 PM Bram Moolenaar wrote: > > > > > > > >> On Sat, Sep 12, 2020 at 1:09 PM Prabir Shrestha < > > > > >> vim-dev-git...@256bit.org> wrote: > > > > >> > > > > >>> +1 for adding fuzzy match. > > > > >>> > > > > >>> A bit late to this. But few questions. > > >

Re: [vim/vim] Fix use after free when autocmd changes the location list (#6946)

2020-09-13 Fir de Conversatie Bram Moolenaar
> > > > Can you turn the example into a test? I gave it a try but it didn't > > > > trigger the error. > > > > > > > > > > > > > > > I am able to reproduce this error with the following function: > > > > > > === > > > func Test() > > > call

Patch 8.2.1678

2020-09-13 Fir de Conversatie Bram Moolenaar
Patch 8.2.1678 Problem:Crash when using ":set" after ":ownsyntax". (Dhiraj Mishra) Solution: Make sure 'spelloptions' is not NULL. (closes #6950) Files: src/syntax.c, src/testdir/test_syntax.vim *** ../vim-8.2.1677/src/syntax.c2020-07-10 20:30:10.076325216 +0200 ---

Patch 8.2.1677

2020-09-13 Fir de Conversatie Bram Moolenaar
Patch 8.2.1677 Problem:Memory access errors when calling setloclist() in an autocommand. Solution: Give an error if the list was changed unexpectedly. (closes #6946) Files: src/quickfix.c, src/testdir/test_quickfix.vim *** ../vim-8.2.1676/src/quickfix.c 2020-09-05

Patch 8.2.1676

2020-09-13 Fir de Conversatie Bram Moolenaar
Patch 8.2.1676 Problem:Compiler warnings for function typecast. Solution: Add an intermediate cast to "void *". Files: src/os_unix.c *** ../vim-8.2.1675/src/os_unix.c 2020-08-30 17:24:34.277662302 +0200 --- src/os_unix.c 2020-09-13 21:58:42.923711775 +0200

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > On Sun, Sep 13, 2020 at 3:44 AM Bram Moolenaar wrote: > > > > > > >> On Sat, Sep 12, 2020 at 1:09 PM Prabir Shrestha < > > > >> vim-dev-git...@256bit.org> wrote: > > > >> > > > >>> +1 for adding fuzzy match. > > > >>> > > > >>> A bit late to this. But few questions. > > >

Re: [vim/vim] Fix use after free when autocmd changes the location list (#6946)

2020-09-13 Fir de Conversatie Bram Moolenaar
I wrote: > Yegappan wrote: > > > Hi Bram, > > > > On Sun, Sep 13, 2020 at 4:42 AM Bram Moolenaar > > wrote: > > > > > Can you turn the example into a test? I gave it a try but it didn't > > > trigger the error. > > > > > > > > > > > I am able to reproduce this error with the following

Patch 8.2.1675

2020-09-13 Fir de Conversatie Bram Moolenaar
Patch 8.2.1675 Problem:MinGW: testdir makefile deletes non-existing file. Solution: Use another way to delete the output file if it already exists. (Michael Soyka) Files: src/testdir/Make_ming.mak *** ../vim-8.2.1674/src/testdir/Make_ming.mak 2020-08-26

Re: Incorrect path separator used in testdir/Make_ming.mak

2020-09-13 Fir de Conversatie Bram Moolenaar
Michael Soyka wrote: > The following statement > > if not exist $@ $(DEL) $@ > > on line 98 in testdir/Make_ming.mak has two errors: > > 1. it attempts to delete a non-existing file and > 2. the path that is substituted for $@ includes unix/linux path separators. > > The attached

Re: [vim/vim] Fix use after free when autocmd changes the location list (#6946)

2020-09-13 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > Hi Bram, > > On Sun, Sep 13, 2020 at 4:42 AM Bram Moolenaar > wrote: > > > Can you turn the example into a test? I gave it a try but it didn't > > trigger the error. > > > > > > > I am able to reproduce this error with the following function: > >

Re: [patch] fixed typos in doc of vim-8.2.1673

2020-09-13 Fir de Conversatie Bram Moolenaar
Dominique wrote: > Attached patch fixes typos in documentation > of Vim-8.2.1673. Thanks. -- Why don't cannibals eat clowns? Because they taste funny. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features --

Re: [vim/vim] Fix use after free when autocmd changes the location list (#6946)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Sun, Sep 13, 2020 at 4:42 AM Bram Moolenaar wrote: > Can you turn the example into a test? I gave it a try but it didn't > trigger the error. > > > I am able to reproduce this error with the following function: === func Test() call

Incorrect path separator used in testdir/Make_ming.mak

2020-09-13 Fir de Conversatie Michael Soyka
Vim developers, The following statement if not exist $@ $(DEL) $@ on line 98 in testdir/Make_ming.mak has two errors: 1. it attempts to delete a non-existing file and 2. the path that is substituted for $@ includes unix/linux path separators. The attached patch fixes both. Regards,

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Sun, Sep 13, 2020 at 3:44 AM Bram Moolenaar wrote: > > > >> On Sat, Sep 12, 2020 at 1:09 PM Prabir Shrestha < > > >> vim-dev-git...@256bit.org> wrote: > > >> > > >>> +1 for adding fuzzy match. > > >>> > > >>> A bit late to this. But few questions. > > >>> > > >>> How do we use

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Bram Moolenaar
> >> On Sat, Sep 12, 2020 at 1:09 PM Prabir Shrestha < > >> vim-dev-git...@256bit.org> wrote: > >> > >>> +1 for adding fuzzy match. > >>> > >>> A bit late to this. But few questions. > >>> > >>> How do we use matchfuzzy for a list of dictionary instead of item. > >>> Primary reason for this is

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-13 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sat, Sep 12, 2020 at 10:46 PM Prabir Shrestha wrote: > Great perf improvements. Would love to see the PR with updated doc for > this. > > > Created PR #6947 for this change. Thinking about this change some more, I am wondering whether we should support only the key argument for the list