Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Hi Charles! On Di, 01 Mär 2016, Charles E Campbell wrote: > Has this been a vim bugtracker issue? Yes, basically all mails from vim-dev-git...@256bit.org are redirects from github and are mirrored to vim-dev. You can see it also in the subject which contains the repository in brackets

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Christian Brabandt wrote: > Hi Charles! > > On Di, 01 Mär 2016, Charles E Campbell wrote: > >> This is a solution, but inadequate, I'm afraid. The right solution >> (now, for the 3rd time): use a vim with patch 1141, along with >> syntax/sh.vim v145. > I am afraid, your message does not make it

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Hi Charles! On Di, 01 Mär 2016, Charles E Campbell wrote: > Christian Brabandt wrote: > > > > I think, the problem is this line from sh.vim (distributed with vim): > > > > |syn region shCaseEsac matchgroup=shConditional start="\ > matchgroup=shConditional end="\" end="\"

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Christian Brabandt wrote: > > I think, the problem is this line from sh.vim (distributed with vim): > > |syn region shCaseEsac matchgroup=shConditional start="\ matchgroup=shConditional end="\" end="\" contains=@shLoopList | > > which matches the xcode-select command.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

mattn wrote: > > Could you please try below? > > |$ vim -u NONE -N your.sh :syntax on ... move cursor into `--install` > above ... :echo synIDattr(synID(line("."), col("."), 1), "name") | > > I get shOption. > > I get shOption. That's what --install is supposed to be highlighted as. More fully:

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Josh Reichardt wrote: > > With no plugins installed: > > With the cursor before the |--install| flag I get |shConditional|. > With the cursor after the |--install| flag I get |shCaseEsac|. > > shCaseEsac should only be in effect when one is using a case construct. Your example doesn't have a case

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Christian Brabandt wrote: > > Well, what is the output of the synID command given above? It does not > seem reproducible. > > Version questions: * what version of syntax/sh.vim are you using? The latest release: v145 * what version of vim are you using? You need 7.4.1141 or later. Charles

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

mattn wrote: > > try following on cursor at |--install|. > > |echo synIDattr(synID(line("."), col("."), 1), "name") | > > what do you get? > > Using hilinks.vim, which gives rather more information, and with the cursor on --install: SynStack: shOption

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

Josh Reichardt wrote: > > OS: |OS X 10.11.3| > vim version: |7.4 (2013 Aug 10, compiled Feb 11 2016 11:34:55)| > Info for filetype: |sh| > > To reproduce: > > |#!/usr/bin/env bash if ! which "xcode-select" > /dev/null; then echo > "No xcode" else xcode-select --install fi | > > The select in