Re: Patch 7.3.648

2012-09-23 Fir de Conversatie Bram Moolenaar
ZyX wrote: > ԕÂДÁ, 8 ԅϔ҂ӑ 2012šÇ., 17:00:45 UTC+4 я͘ۏ؁Յ͘ Bram Moolenaar ρщԁÌ: > > It might be easier to use vim_strncpy(). And vim_strcat() where > > appropriate. These always add a NUL and check the size of the buffer. > > It is not needed: the following fixes garbage without using alloc_clea

Re: Patch 7.3.648

2012-09-22 Fir de Conversatie ZyX
суббота, 8 сентября 2012 г., 17:00:45 UTC+4 пользователь Bram Moolenaar написал: > It might be easier to use vim_strncpy(). And vim_strcat() where > appropriate. These always add a NUL and check the size of the buffer. It is not needed: the following fixes garbage without using alloc_clear: # H

Re: Patch 7.3.648

2012-09-08 Fir de Conversatie Bram Moolenaar
ZyX wrote: > I now understand the source of the garbage: STRNCPY is not adding NUL > byte if it copied n bytes and there is no NUL in this n bytes. > Everything was in the man, I just had to reread it. It might be easier to use vim_strncpy(). And vim_strcat() where appropriate. These always ad

Re: Patch 7.3.648

2012-09-08 Fir de Conversatie ZyX
I now understand the source of the garbage: STRNCPY is not adding NUL byte if it copied n bytes and there is no NUL in this n bytes. Everything was in the man, I just had to reread it. # HG changeset patch # User ZyX # Date 1347095322 -14400 # Node ID 36b3878656262abb03c3cd98b116208569be58c4 #

Re: Patch 7.3.648

2012-09-08 Fir de Conversatie ZyX
суббота, 8 сентября 2012 г., 0:00:19 UTC+4 пользователь Bram Moolenaar написал: > > That actually did not fix the problem: gcc optimized build now behaves > > like non-optimized one, thats all. I still get a crash where I was > > getting it before (aurum, "AuDiff rev1 1 rev2 tip **"). And I still >

Re: Patch 7.3.648

2012-09-07 Fir de Conversatie Bram Moolenaar
ZyX wrote: > > Patch 7.3.648 > > Problem:Crash when using a very long file name. (ZyX) > > Solution: Properly check length of buffer space. > > Files: src/buffer.c > > That actually did not fix the problem: gcc optimized build now behaves > lik

Re: Patch 7.3.648

2012-09-06 Fir de Conversatie ZyX
Previous patch missed one length decrement and thus was invalid. There was also no need to introduce one new variable, here is the updated one. There is still one issue: at the end of :file outputs garbage is shown meaning that something is wrong. I currently do not know how to fix this or repro

Re: Patch 7.3.648

2012-09-06 Fir de Conversatie ZyX
пятница, 7 сентября 2012 г., 0:04:00 UTC+4 пользователь ZyX написал: > среда, 5 сентября 2012 г., 15:31:07 UTC+4 пользователь Bram Moolenaar написал: > > Patch 7.3.648 > > Problem:Crash when using a very long file name. (ZyX) > > Solution: Properly check length of bu

Re: Patch 7.3.648

2012-09-06 Fir de Conversatie ZyX
среда, 5 сентября 2012 г., 15:31:07 UTC+4 пользователь Bram Moolenaar написал: > Patch 7.3.648 > Problem:Crash when using a very long file name. (ZyX) > Solution: Properly check length of buffer space. > Files:src/buffer.c That actually did not fix the problem: g

Patch 7.3.648

2012-09-05 Fir de Conversatie Bram Moolenaar
Patch 7.3.648 Problem:Crash when using a very long file name. (ZyX) Solution: Properly check length of buffer space. Files: src/buffer.c *** ../vim-7.3.647/src/buffer.c 2012-07-16 17:31:48.0 +0200 --- src/buffer.c2012-09-05 13:17:38.0 +0200