Re: [vim/vim] bug in persistent undo -- `:earlier 100d` undoes one change instead of all (#1254)

2017-01-07 Fir de Conversatie mossgary600 via vim_dev
On Sun, 1/8/17, vim-dev ML wrote: Subject: Re: [vim/vim] bug in persistent undo -- `:earlier 100d` undoes one change instead of all (#1254) To: "vim/vim" Cc: "vim-dev ML" , "Your activity" Date: Sunday, January

Re: [vim/vim] bug in persistent undo -- `:earlier 100d` undoes one change instead of all (#1254)

2017-01-07 Fir de Conversatie Nikolay Aleksandrovich Pavlov
2016-11-17 16:49 GMT+03:00 Bram Moolenaar : > > Christian Brabandt wrote: > >> I am quite sure it happens here in undo.c >> >> 2390 if (dosec) >> 2391 val = (long)(uhp->uh_time - starttime); >> >> val will get a negative value, because starttime is less than the time of >> the undo header. Then thi

Re: Issue with persistent undo history

2012-09-29 Fir de Conversatie Dmitry Frank
Thanks again! 2012/9/28 Christian Brabandt > On Fri, September 28, 2012 08:01, Dmitry Frank wrote: > > Thank you very much for your attention, but will this patch be applied in > > official release? > > It is patch 7.3.646 > > > regards, > Christian > > -- > You received this message from the "v

Re: Issue with persistent undo history

2012-09-28 Fir de Conversatie Christian Brabandt
On Fri, September 28, 2012 08:01, Dmitry Frank wrote: > Thank you very much for your attention, but will this patch be applied in > official release? It is patch 7.3.646 regards, Christian -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text

Re: Issue with persistent undo history

2012-09-27 Fir de Conversatie Dmitry Frank
Thank you very much for your attention, but will this patch be applied in official release? 2012/8/27 Christian Brabandt > Hi Dmitry! > > On Sa, 25 Aug 2012, Dmitry Frank wrote: > > > 2012/8/25 Christian Brabandt > > > > > Hi Dmitry! > > > > > > On Sa, 25 Aug 2012, Dmitry Frank wrote: > > > > >

Re: Issue with persistent undo history

2012-08-26 Fir de Conversatie Christian Brabandt
Hi Dmitry! On Sa, 25 Aug 2012, Dmitry Frank wrote: > 2012/8/25 Christian Brabandt > > > Hi Dmitry! > > > > On Sa, 25 Aug 2012, Dmitry Frank wrote: > > > > > Of course, if you close Vim, then change file by another app, then open > > > this file in Vim again, then, expectedly, undo history shoul

Re: Issue with persistent undo history

2012-08-25 Fir de Conversatie Dmitry Frank
2012/8/25 Christian Brabandt > Hi Dmitry! > > On Sa, 25 Aug 2012, Dmitry Frank wrote: > > > Of course, if you close Vim, then change file by another app, then open > > this file in Vim again, then, expectedly, undo history should be lost. > > But in my example, Vim reloads the changes after file

Re: Issue with persistent undo history

2012-08-25 Fir de Conversatie Christian Brabandt
Hi Dmitry! On Sa, 25 Aug 2012, Dmitry Frank wrote: > Of course, if you close Vim, then change file by another app, then open > this file in Vim again, then, expectedly, undo history should be lost. > But in my example, Vim reloads the changes after file is changed. And, at > this moment, changes

Re: Issue with persistent undo history

2012-08-25 Fir de Conversatie Dmitry Frank
do you want to reload changes. > > Reload changes, and quit Vim. > > *) Start Vim again and open the same file. Check undotree: you will see > > that all the tree is lost. > > This is expected behavior and documented under ":help persistent-undo": > > V

Re: Issue with persistent undo history

2012-08-25 Fir de Conversatie James McCoy
On Sat, Aug 25, 2012 at 04:03:54PM +0400, Dmitry Frank wrote: > *) Make sure you have set up persistent undo in Vim. > *) Open any file in vim, made some changes, save the file. (changes needed > to add changesets to the undo history) > *) Open the same file in any different app, cha

Issue with persistent undo history

2012-08-25 Fir de Conversatie Dmitry Frank
Dear developers, There is an issue with persistent undo history. Steps to reproduce: *) Make sure you have set up persistent undo in Vim. *) Open any file in vim, made some changes, save the file. (changes needed to add changesets to the undo history) *) Open the same file in any different app

Re: Persistent undo usage

2010-08-14 Fir de Conversatie Andy Wokula
Am 14.08.2010 14:41, schrieb Bram Moolenaar: Andy Wokula wrote: I'm trying to get used to persistent undo, but hmmm, I find it still a bit difficult to use. What I want is persistent undo enabled for certain files (not enabled in the vimrc, I don't want all the undo files). So I

Re: Persistent undo usage

2010-08-14 Fir de Conversatie Bram Moolenaar
Andy Wokula wrote: > I'm trying to get used to persistent undo, but hmmm, I find it still a > bit difficult to use. > > What I want is persistent undo enabled for certain files (not enabled in > the vimrc, I don't want all the undo files). > > So I thought i

Persistent undo usage

2010-08-14 Fir de Conversatie Andy Wokula
I'm trying to get used to persistent undo, but hmmm, I find it still a bit difficult to use. What I want is persistent undo enabled for certain files (not enabled in the vimrc, I don't want all the undo files). So I thought it would be enough to :setlocal undofile when it's

Re: crypt + persistent undo bug

2010-07-25 Fir de Conversatie Bram Moolenaar
Christian J. Robinson wrote: > If I'm editing an encrypted file then use the same Vim session to edit > a non-encrypted file, the saved undo information for the non-encrypted > file is garbled when it is read. > > To reproduce, you need an existing, non-encrypted file that has undo > informat

crypt + persistent undo bug

2010-07-25 Fir de Conversatie Christian J. Robinson
If I'm editing an encrypted file then use the same Vim session to edit a non-encrypted file, the saved undo information for the non-encrypted file is garbled when it is read. To reproduce, you need an existing, non-encrypted file that has undo information saved, and an existing encrypted fil

Re: [bug] Vim-7.3a crashes with persistent undo and autocmd FileChangedRO

2010-07-01 Fir de Conversatie Dominique Pellé
and to automatically check-out >> a file when attempting to change it. It causes a crash when >> using persistent undo. >> >> I found a simpler way to reproduce it without using the perforce >> Plugin. The following script is enough to cause Vim to crash: >> >>

Re: [bug] Vim-7.3a crashes with persistent undo and autocmd FileChangedRO

2010-07-01 Fir de Conversatie Bram Moolenaar
n attempting to change it. It causes a crash when > using persistent undo. > > I found a simpler way to reproduce it without using the perforce > Plugin. The following script is enough to cause Vim to crash: > > = > #

[bug] Vim-7.3a crashes with persistent undo and autocmd FileChangedRO

2010-07-01 Fir de Conversatie Dominique Pellé
using persistent undo. I found a simpler way to reproduce it without using the perforce Plugin. The following script is enough to cause Vim to crash: = #!/bin/sh cd /tmp rm -f foobar foobar.undo vim -u NONE -N foobar \ -c ':call fee

Re: [patch] fixed uninitialized memory access in persistent undo

2010-05-24 Fir de Conversatie Bram Moolenaar
Dominique Pelle wrote: > I also notice this additional error which happens sometimes > when loading the persistent undo file: > > =3D=3D14996=3D=3D Invalid write of size 1 > =3D=3D14996=3D=3Dat 0x402753D: memmove (mc_replace_strmem.c:629) > =3D=3D14996=3D=3Dby 0x81

Re: [patch] fixed uninitialized memory access in persistent undo

2010-05-24 Fir de Conversatie Dominique Pellé
edit (normal.c:8912) >> ==7309==    by 0x813096D: nv_edit (normal.c:8885) >> ==7309==    by 0x812459B: normal_cmd (normal.c:1188) >> ==7309==    by 0x80E7930: main_loop (main.c:1216) >> ==7309==    by 0x80E7427: main (main.c:960) >> >> I added --track-origin

Re: [patch] fixed uninitialized memory access in persistent undo

2010-05-24 Fir de Conversatie Bram Moolenaar
_lcount is uninitialized when serialized at undo.c:1158: > > 1155 put_bytes(fp, (long_u)uep_len, 4); > 1156 put_bytes(fp, (long_u)uep->ue_top, 4); > 1157 put_bytes(fp, (long_u)uep->ue_bot, 4); > 1158 put_bytes(fp, (long_u)uep->ue_lcount, 4); > 1159

[patch] fixed uninitialized memory access in persistent undo

2010-05-24 Fir de Conversatie Dominique Pellé
a severe issue. But it's best to initialize it to have deterministic persistent undo files. Attached patch fixes it. -- Dominique -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information,

Re: [patch] Persistent undo

2009-11-17 Fir de Conversatie Mun
Hi Andy, Christian, Thanks for your reply. Please see my comments below. On Tue, Nov 17, 2009 at 12:48 PM PST, Andy Wokula wrote: ... Text Deleted ... AW> > Another possibility would be for 'undofile' to be a string variable with AW> > possible choices being something like "read, write, both

Re: [patch] Persistent undo

2009-11-17 Fir de Conversatie Christian Brabandt
Hi Mun! On Di, 17 Nov 2009, Mun wrote: > I have been using the Persistent Undo patch for several months now and I > have a general comment regarding it's usability. Jordan and I had a > private conversation about this a while back, and he requested I post > something to

Re: [patch] Persistent undo

2009-11-17 Fir de Conversatie Andy Wokula
Mun schrieb: > Hi all, > > I have been using the Persistent Undo patch for several months now and I > have a general comment regarding it's usability. Jordan and I had a > private conversation about this a while back, and he requested I post > something to the list so

Re: [patch] Persistent undo

2009-11-17 Fir de Conversatie Mun
Hi all, I have been using the Persistent Undo patch for several months now and I have a general comment regarding it's usability. Jordan and I had a private conversation about this a while back, and he requested I post something to the list so as to provide a broader audience for fee

Re: [patch] Persistent undo

2009-11-16 Fir de Conversatie Jordan Lewis
2009/11/16 Dominique Pellé : > > Jordan Lewis wrote: > >> Hi, >> >> I've added some documentation to the patch I wrote for persistent >> undo. It's been a while since I've posted about this, so I'll recap >> the features: >> >

Re: [patch] Persistent undo

2009-11-16 Fir de Conversatie Dominique Pellé
Jordan Lewis wrote: > Hi, > > I've added some documentation to the patch I wrote for persistent > undo. It's been a while since I've posted about this, so I'll recap > the features: > > 1. New option 'undofile' causes Vim to automatically write

Re: Persistent undo

2009-11-16 Fir de Conversatie Jordan Lewis
On Nov 16, 10:49 am, Erik Falor wrote: > I'm sorry to report that your patch does not build on Windows with > VS2008. Thanks for that input - I've only tested the patch under Linux and Mac OS X. I don't actually have a Windows development environment available to me at the moment, but I'll try t

Re: [patch] Persistent undo

2009-11-16 Fir de Conversatie Erik Falor
On Mon, Nov 16, 2009 at 03:22:55AM -0600, Jordan Lewis wrote: > Please try this patch! I think you all and the rest of the Vim > community will really like this functionality. I'm sorry to report that your patch does not build on Windows with VS2008. The following is the compiler output. It lo

[patch] Persistent undo

2009-11-16 Fir de Conversatie Jordan Lewis
Hi, I've added some documentation to the patch I wrote for persistent undo. It's been a while since I've posted about this, so I'll recap the features: 1. New option 'undofile' causes Vim to automatically write out the undo history for the current session to a

Re: Persistent Undo

2009-03-01 Fir de Conversatie Jordan Lewis
On Feb 27, 5:28 pm, Jordan Lewis wrote: > Good point, aside from some kind of rare race condition it seems like > using mtime would offer only advantages over checksumming. I'll try to > make this change sometime soon and resubmit the patch. I've replaced the checksum operation with a simple

Re: Persistent Undo

2009-02-27 Fir de Conversatie Jordan Lewis
On Feb 23, 4:51 am, Andreas Bernauer wrote: > > 2. Added 'undofile'/'udf' option that toggles automatic undo file   > > writing and reading. If a file's checksum changed since the last time   > > it had an undo file written for it, Vim will silently (or loudly, with   > > verbose > 0) ignore th

Re: [patch] Persistent Undo

2009-02-23 Fir de Conversatie Andreas Bernauer
Hi Jordan, just my thoughts: Jordan Lewis wrote: > 2. Added 'undofile'/'udf' option that toggles automatic undo file > writing and reading. If a file's checksum changed since the last time > it had an undo file written for it, Vim will silently (or loudly, with > verbose > 0) ignore the un

[patch] Persistent Undo

2009-02-20 Fir de Conversatie Jordan Lewis
This patch implements persistent undo. It is against SVN revision 1365. I'd like to submit it to the list to see what people think. More specifically, here are the changes: 1. Added commands :wundo and :rundo that write and read undo files respectively. An undo file is a binary file