Re: [virt-tools-list] [libosinfo 1/4] Add InstallScript:expected-path-format

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 4:06 PM, Christophe Fergeau wrote: > On Mon, Nov 12, 2012 at 03:55:56PM +0100, Zeeshan Ali (Khattak) wrote: >> On Mon, Nov 12, 2012 at 11:37 AM, Christophe Fergeau >> wrote: >> > On Sun, Nov 11, 2012 at 08:14:55PM +0100, Zeeshan Ali (Khattak) wrote: >> >> From: "Zeeshan Al

Re: [virt-tools-list] [libosinfo 4/4] Don't assume install script disk

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 11:50 AM, Christophe Fergeau wrote: > On Sun, Nov 11, 2012 at 08:14:58PM +0100, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Instead of hardcoding install script disk, lets get this info from app. > > Do we have a way to carry the information that fo

Re: [virt-tools-list] [libosinfo 3/4] Don't assume target disk

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 11:47 AM, Christophe Fergeau wrote: > On Sun, Nov 11, 2012 at 08:14:57PM +0100, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Instead of hardcoding target disk, lets get this info from application. > > Are all OSes OK with being auto installed on some

Re: [virt-tools-list] [libosinfo 1/4] Add InstallScript:expected-path-format

2012-11-12 Thread Christophe Fergeau
On Mon, Nov 12, 2012 at 03:55:56PM +0100, Zeeshan Ali (Khattak) wrote: > On Mon, Nov 12, 2012 at 11:37 AM, Christophe Fergeau > wrote: > > On Sun, Nov 11, 2012 at 08:14:55PM +0100, Zeeshan Ali (Khattak) wrote: > >> From: "Zeeshan Ali (Khattak)" > >> > >> Inform the applications in which format th

Re: [virt-tools-list] [libosinfo 1/4] Add InstallScript:expected-path-format

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 11:37 AM, Christophe Fergeau wrote: > On Sun, Nov 11, 2012 at 08:14:55PM +0100, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Inform the applications in which format the paths are expected by the >> installer. >> --- >> data/install-scripts/windows-c

Re: [virt-tools-list] [libosinfo v2 5/8] InstallConfigParam:policy should not be writable

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 11:26 AM, Christophe Fergeau wrote: > On Fri, Nov 09, 2012 at 04:14:21PM +0100, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> This actually not only breaks ABI but also the API: we remove one argument >> of _new() function. The prop getter is the main

Re: [virt-tools-list] [libosinfo v2 4/8] InstallConfigParam props should map to entity params

2012-11-12 Thread Zeeshan Ali (Khattak)
On Mon, Nov 12, 2012 at 11:22 AM, Christophe Fergeau wrote: > On Fri, Nov 09, 2012 at 04:14:20PM +0100, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> Without entity params usage, there is no real benefit of deriving from >> Entity class so this was very much intended from st

Re: [virt-tools-list] [virt-viewer][PATCH] Reconnect to libvirtd after connection breaks

2012-11-12 Thread Michal Privoznik
On 12.11.2012 10:57, Christophe Fergeau wrote: > On Thu, Nov 08, 2012 at 05:13:09PM +0100, Michal Privoznik wrote: >> Currently, if user wants to reconnect to a domain he can use >> '-r' cmd line argument. This makes virt-viewer listen to >> domain events. However, if connection to libvirtd breaks

Re: [virt-tools-list] [libosinfo 4/4] Don't assume install script disk

2012-11-12 Thread Christophe Fergeau
On Sun, Nov 11, 2012 at 08:14:58PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Instead of hardcoding install script disk, lets get this info from app. Do we have a way to carry the information that for winxp this has to be a floppy drive? Is winxp ok with getting thin

Re: [virt-tools-list] [libosinfo 3/4] Don't assume target disk

2012-11-12 Thread Christophe Fergeau
On Sun, Nov 11, 2012 at 08:14:57PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Instead of hardcoding target disk, lets get this info from application. Are all OSes OK with being auto installed on something else than the first disk? (thinking of older Windows here for

Re: [virt-tools-list] [libosinfo 1/4] Add InstallScript:expected-path-format

2012-11-12 Thread Christophe Fergeau
On Sun, Nov 11, 2012 at 08:14:55PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Inform the applications in which format the paths are expected by the > installer. > --- > data/install-scripts/windows-cmd.xml | 2 +- > data/install-scripts/windows-reg.xml |

Re: [virt-tools-list] [libosinfo v2 6/8] Correct InstallConfigParam:policy prop to enum type

2012-11-12 Thread Christophe Fergeau
On Fri, Nov 09, 2012 at 04:14:22PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Although this means ABI "breakage", we must keep in mind: > > a. The property getter (the API used by apps) was treating the string >value as enum, i-e it was broken for apps so if any

Re: [virt-tools-list] [libosinfo v2 5/8] InstallConfigParam:policy should not be writable

2012-11-12 Thread Christophe Fergeau
On Fri, Nov 09, 2012 at 04:14:21PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > This actually not only breaks ABI but also the API: we remove one argument > of _new() function. The prop getter is the main part of this API that an > app will be using if its using this AP

Re: [virt-tools-list] [libosinfo v2 4/8] InstallConfigParam props should map to entity params

2012-11-12 Thread Christophe Fergeau
On Fri, Nov 09, 2012 at 04:14:20PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Without entity params usage, there is no real benefit of deriving from > Entity class so this was very much intended from start. Looks like the members of OsInfoInstallConfigParam::priv are

Re: [virt-tools-list] [libosinfo v2 3/8] Add enum param getter/setter helpers

2012-11-12 Thread Christophe Fergeau
On Fri, Nov 09, 2012 at 04:14:19PM +0100, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > Add: > > * osinfo_entity_get_param_value_enum > * osinfo_entity_set_param_enum > --- > osinfo/libosinfo.syms | 3 +++ > osinfo/osinfo_entity.c | 39 ++

Re: [virt-tools-list] [virt-viewer][PATCH] Reconnect to libvirtd after connection breaks

2012-11-12 Thread Christophe Fergeau
On Thu, Nov 08, 2012 at 05:13:09PM +0100, Michal Privoznik wrote: > Currently, if user wants to reconnect to a domain he can use > '-r' cmd line argument. This makes virt-viewer listen to > domain events. However, if connection to libvirtd breaks > somehow, we will receive no longer any event. Henc

[virt-tools-list] [virtinst] Add attribute'model' in VirtualDisk class

2012-11-12 Thread Chen Hanxiao
From: ChenHanxiao Introduce a new attribute 'model' to support virtio-scsi disk with SCSI controller type 'virtio-scsi' Signed-off-by: ChenHanxiao --- virtinst/VirtualDisk.py | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/virtinst/VirtualDisk.py

[virt-tools-list] [virt-manager] Add virtio-scsi disk bus option

2012-11-12 Thread Chen Hanxiao
From: ChenHanxiao This patch will add virtio-scsi bus option on "Add New Virtual Hardware" GUI page. It will support users to add a virtual disk using SCSI bus with a controller model virtio-scsi. In virt-manager, we will provide virtio-scsi disk XML for libvirt: We provided tag 'mod