The check that at least one of spice-gtk and gtk-vnc is present
uses a wrong variable name to check for spice-gtk presence, which
causes the check to think it's never present. This would make
gtk-vnc presence mandatory. This commit fixes the name of the
spice-gtk variable ($have_gtk_spice -
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
somehow, we will receive no longer any event. Hence we must
reconnect to the libvirt.
---
diff to v1:
-clean the patch up
On 13.11.2012 11:42, Christophe Fergeau wrote:
The check that at least one of spice-gtk and gtk-vnc is present
uses a wrong variable name to check for spice-gtk presence, which
causes the check to think it's never present. This would make
gtk-vnc presence mandatory. This commit fixes the name
In order to make syntax-check pass.
These patches should be applied on the top of
https://www.redhat.com/archives/virt-tools-list/2012-November/msg00075.html
otherwise AUTHORS would need update (add /me).
Michal Privoznik (3):
cfg.mk: Don't require bindtextdomain directly
AUTHORS: add
On Tue, Nov 13, 2012 at 11:57:31AM +0100, Michal Privoznik wrote:
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
somehow, we will receive no longer any event. Hence
With current implementation, all binaries that need it call
bindtextdomain but not directly. They call a helper function
instead. This makes, however, syntax-check fail as it cannot
recognize it.
---
cfg.mk |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cfg.mk
In relation to https://bugzilla.redhat.com/show_bug.cgi?id=875126
this series makes some improvements to the screenshot saving code.
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
When falling back to saving to .png, the filename might not
end with .png. This commit appends the .png extension to the
screenshot filename if it's missing.
---
src/virt-viewer-window.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer-window.c
It makes sense for the screenshots to be saved in ~/Images,
especially as otherwise the filechooser will display
'recent documents' to which we cannot save. This commit also sets
the default screenshot name to 'Screenshot'.
---
src/virt-viewer-window.c | 8 +---
1 file changed, 5
Currently, the screenshots can only be saved to png. This commit
checks if the file extension is a known one, and will save to this
format if it is. Otherwise it will fallback to saving to png.
---
src/virt-viewer-window.c | 55 ++--
1 file changed, 53
On Mon, Nov 12, 2012 at 04:22:12PM +0100, Zeeshan Ali (Khattak) wrote:
On Mon, Nov 12, 2012 at 11:47 AM, Christophe Fergeau
cferg...@redhat.com wrote:
On Sun, Nov 11, 2012 at 08:14:57PM +0100, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Instead of
On Mon, Nov 12, 2012 at 04:32:29PM +0100, Zeeshan Ali (Khattak) wrote:
Ah ok, might be worth explicitly spelling out that the drive name should
not be there as this is not your typical Windows path.
I do spell out in the docs of the appropriate getters:
Also note that in case of
Dear List,
I have been trying to use VMM with my custom KVM but have not been able to get
it to work.
After creating a custom KVM-QEMU installation which works as intended, I
installed libvirt and VMM and noticed that the KVM-QEMU VMs being created were
not running on my custom version.
On 13.11.2012 12:30, Christophe Fergeau wrote:
On Tue, Nov 13, 2012 at 11:57:31AM +0100, Michal Privoznik wrote:
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
On Tue, Nov 13, 2012 at 1:19 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Mon, Nov 12, 2012 at 04:22:12PM +0100, Zeeshan Ali (Khattak) wrote:
On Mon, Nov 12, 2012 at 11:47 AM, Christophe Fergeau
cferg...@redhat.com wrote:
On Sun, Nov 11, 2012 at 08:14:57PM +0100, Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Separate out root and user password setup in fedora installer so that
root account is not made passwordless just because user password was
not specified.
---
data/install-scripts/fedora.xml | 9 ++---
1 file changed, 6 insertions(+), 3
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-sif.xml | 2 +-
osinfo/libosinfo.syms| 3 +++
osinfo/osinfo_install_config.c | 28
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Instead of hardcoding avatar path and disk, lets get those from
application.
---
data/install-scripts/fedora.xml | 26 +---
data/install-scripts/windows-cmd.xml | 4 ++-
osinfo/libosinfo.syms| 6 +++-
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/fedora.xml | 84 +--
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-unattend.xml | 32 ++--
osinfo/libosinfo.syms | 3
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Inform the applications in which format the paths are expected by the
installer.
---
data/install-scripts/windows-cmd.xml | 2 +-
data/install-scripts/windows-reg.xml | 2 +-
data/install-scripts/windows-sif.xml | 4 ++--
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-unattend.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/install-scripts/windows-unattend.xml
b/data/install-scripts/windows-unattend.xml
index 2248610..80b2350 100644
---
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-unattend.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/data/install-scripts/windows-unattend.xml
b/data/install-scripts/windows-unattend.xml
index 80b2350..c43b153 100644
---
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Document the format of the string returned by this function.
---
osinfo/osinfo_install_script.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-sif.xml | 4 ++--
data/install-scripts/windows-unattend.xml | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/data/install-scripts/windows-sif.xml
b/data/install-scripts/windows-sif.xml
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
osinfo/osinfo_entity.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/osinfo/osinfo_entity.c b/osinfo/osinfo_entity.c
index 9fabc46..348981e 100644
--- a/osinfo/osinfo_entity.c
+++ b/osinfo/osinfo_entity.c
@@ -221,6 +221,7 @@ void
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Remove private structure and finalize implementation. This should have
been part of commit ee9e797.
---
osinfo/osinfo_install_config_param.c | 29 -
1 file changed, 29 deletions(-)
diff --git
[adding gnulib]
On 11/13/2012 04:28 AM, Michal Privoznik wrote:
With current implementation, all binaries that need it call
bindtextdomain but not directly. They call a helper function
instead. This makes, however, syntax-check fail as it cannot
recognize it.
---
cfg.mk |3 ++-
1
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-sif.xml | 2 ++
data/install-scripts/windows-unattend.xml | 2 ++
2 files changed, 4 insertions(+)
diff --git a/data/install-scripts/windows-sif.xml
b/data/install-scripts/windows-sif.xml
index
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-unattend.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/install-scripts/windows-unattend.xml
b/data/install-scripts/windows-unattend.xml
index 509f18a..baa8059 100644
---
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Separate out root and user password setup in fedora installer so that
root account is not made passwordless just because user password was
not specified.
---
data/install-scripts/fedora.xml | 9 ++---
1 file changed, 6 insertions(+), 3
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-unattend.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/data/install-scripts/windows-unattend.xml
b/data/install-scripts/windows-unattend.xml
index baa8059..78ca670 100644
---
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
osinfo/osinfo_entity.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/osinfo/osinfo_entity.c b/osinfo/osinfo_entity.c
index 9fabc46..348981e 100644
--- a/osinfo/osinfo_entity.c
+++ b/osinfo/osinfo_entity.c
@@ -221,6 +221,7 @@ void
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
'filename' should be toplevel node under 'install-script' rather than
an attribute of its toplevel 'template' child. The reason this was
previously put in the incorrect place was that the first idea was to have
multiple files under one install
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Instead of hardcoding avatar path and disk, lets get those from
application.
---
data/install-scripts/fedora.xml | 26 +---
data/install-scripts/windows-cmd.xml | 4 ++-
osinfo/libosinfo.syms| 6 +++-
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Remove private structure and finalize implementation. This should have
been part of commit ee9e797.
---
osinfo/osinfo_install_config_param.c | 29 -
1 file changed, 29 deletions(-)
diff --git
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/fedora.xml | 84 +--
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-unattend.xml | 32 ++--
osinfo/libosinfo.syms | 3
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-sif.xml | 2 +-
osinfo/libosinfo.syms| 3 +++
osinfo/osinfo_install_config.c | 28
37 matches
Mail list logo
