Re: [virt-tools-list] [libosinfo 7/8] rfc: Infer ISO language from label

2012-12-05 Thread Christophe Fergeau
On Tue, Dec 04, 2012 at 04:08:00PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Dec 4, 2012 at 1:01 PM, Daniel P. Berrange berra...@redhat.com wrote: The values required for each of these setters is really OS-specific. To properly isolate apps from this, we need to have a data map concept,

[virt-tools-list] [virt-install PATCH v3] Support multiple seclabels

2012-12-05 Thread Martin Kletzander
Until now, virt-install supported only one seclabel and it was the first one libvirt reported in capabilities. This patch adds support for more of them and also adds a functionality to try to match the right one from the label given. This is done by checking how many colons the label has

Re: [virt-tools-list] [PATCH] [virt-viewer] Make .desktop file comply with spec

2012-12-05 Thread Michal Privoznik
On 04.12.2012 23:23, Doug Goldstein wrote: The .desktop file did not comply with the Desktop Entry spec as checked with desktop-file-validate. Boolean keys are defined as taking only 'true' or 'false', the entry Terminal had False. MimeType is a string list and therefore must be terminated

[virt-tools-list] [libosinfo] loader: Fix media object leaks

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- osinfo/osinfo_loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c index c49d303..a4dd01d 100644 --- a/osinfo/osinfo_loader.c +++ b/osinfo/osinfo_loader.c @@ -957,6 +957,7 @@ static void

Re: [virt-tools-list] [libosinfo 7/8] rfc: Infer ISO language from label

2012-12-05 Thread Zeeshan Ali (Khattak)
On Wed, Dec 5, 2012 at 11:15 AM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Dec 04, 2012 at 04:08:00PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Dec 4, 2012 at 1:01 PM, Daniel P. Berrange berra...@redhat.com wrote: The values required for each of these setters is really

[virt-tools-list] [libosinfo] Device drivers API/data

2012-12-05 Thread Zeeshan Ali (Khattak)
These patches add means for apps to find and fetch device drivers and to tell installer about where to find pre- and post-installation device drivers. Also included is the first implementation: virtio storage device drivers for Windows XP and Windows 7. I have tested these against Boxes and they

[virt-tools-list] [libosinfo 04/10] schema: Allow driver info under os nodes

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This defines the XML we'll use to add device driver information to our XML database. --- data/schemas/libosinfo.rng | 31 +++ 1 file changed, 31 insertions(+) diff --git a/data/schemas/libosinfo.rng

[virt-tools-list] [libosinfo 01/10] Add DeviceDriver class

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- osinfo/Makefile.am| 3 + osinfo/libosinfo.syms | 7 ++ osinfo/osinfo.h | 1 + osinfo/osinfo_device_driver.c | 181 ++

[virt-tools-list] [libosinfo 02/10] Add DeviceDriverList class

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org OsinfoDeviceDriverList is a list specialization that stores only OsinfoDeviceDriver objects. --- osinfo/Makefile.am| 2 + osinfo/libosinfo.syms | 7 ++ osinfo/osinfo.h | 1 +

[virt-tools-list] [libosinfo 08/10] winxp, win7, installer: Claim drivers pre-install capability

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- data/install-scripts/windows-sif.xml | 2 ++ data/install-scripts/windows-unattend.xml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/data/install-scripts/windows-sif.xml b/data/install-scripts/windows-sif.xml index

[virt-tools-list] [libosinfo 10/10] win7, installer: Setup pre-installation drivers

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- data/install-scripts/windows-unattend.xml | 68 +++ 1 file changed, 68 insertions(+) diff --git a/data/install-scripts/windows-unattend.xml b/data/install-scripts/windows-unattend.xml index 2cf2235..de84b65 100644

[virt-tools-list] [libosinfo 06/10] win7, xp: Provide info on viostor drivers

2012-12-05 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org The drivers are currently availalable from my own webspace, we should probably put it in a more canonical location and update this patch once the approach taken here is agreed upon by everyone. --- data/oses/windows.xml.in | 34

Re: [virt-tools-list] [libosinfo 7/8] rfc: Infer ISO language from label

2012-12-05 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 04:08:00PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Dec 4, 2012 at 1:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 04, 2012 at 11:47:06AM +0100, Christophe Fergeau wrote: On Mon, Dec 03, 2012 at 06:30:18PM +0200, Zeeshan Ali (Khattak) wrote:

[virt-tools-list] [virt-viewer][PATCH 2/2] session-spice: Cast CA string to gunit8 pointer

2012-12-05 Thread Michal Privoznik
SpiceSession has 'ca' property which is type of GByteArray*. However, when we read the property from file, we read it as string. For conversion g_byte_array_new_take() is used which takes given pointer as guint8* so we need to do the cast. --- src/virt-viewer-session-spice.c |2 +- 1 files

[virt-tools-list] [virt-viewer][PATCH 1/2] Sanitize sytnax-check

2012-12-05 Thread Michal Privoznik
make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/windows-cmdline-wrapper.c * cfg.mk: add a syntax-rule exception * data/virt-viewer-debug.nsis.in: remove empty line at EOF --- cfg.mk |4 ++--

[virt-tools-list] [virt-viewer][PATCH 1/2] Sanitize syntax-check

2012-12-05 Thread Michal Privoznik
make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/windows-cmdline-wrapper.c * cfg.mk: add a syntax-rule exception * data/virt-viewer-debug.nsis.in: remove empty line at EOF --- cfg.mk |4 ++--

Re: [virt-tools-list] [virt-viewer][PATCH 1/2] Sanitize sytnax-check

2012-12-05 Thread Michal Privoznik
On 05.12.2012 15:13, Michal Privoznik wrote: make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/windows-cmdline-wrapper.c * cfg.mk: add a syntax-rule exception * data/virt-viewer-debug.nsis.in: remove empty line at EOF --- cfg.mk

Re: [virt-tools-list] [virt-viewer][PATCH 2/2] session-spice: Cast CA string to gunit8 pointer

2012-12-05 Thread Marc-André Lureau
ack - Mensaje original - SpiceSession has 'ca' property which is type of GByteArray*. However, when we read the property from file, we read it as string. For conversion g_byte_array_new_take() is used which takes given pointer as guint8* so we need to do the cast. ---

Re: [virt-tools-list] [libosinfo 7/8] rfc: Infer ISO language from label

2012-12-05 Thread Zeeshan Ali (Khattak)
On Wed, Dec 5, 2012 at 4:11 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 04, 2012 at 04:08:00PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Dec 4, 2012 at 1:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 04, 2012 at 11:47:06AM +0100, Christophe Fergeau

Re: [virt-tools-list] [virt-viewer][PATCH 1/2] Sanitize syntax-check

2012-12-05 Thread Marc-André Lureau
Hi - Mensaje original - make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/windows-cmdline-wrapper.c You mean in src/virt-viewer-file.c ? I would rather add config.h there than an exception. * cfg.mk: add a syntax-rule exception

Re: [virt-tools-list] [virt-install PATCH v2] Support multiple seclabels

2012-12-05 Thread Cole Robinson
On 12/05/2012 05:30 AM, Martin Kletzander wrote: On 12/04/2012 11:13 PM, Cole Robinson wrote: On 12/03/2012 09:06 AM, Martin Kletzander wrote: Until now, virt-install supported only one seclabel and it was the first one libvirt reported in capabilities. This patch adds support for more of

Re: [virt-tools-list] [virt-install PATCH v3] Support multiple seclabels

2012-12-05 Thread Cole Robinson
On 12/05/2012 06:11 AM, Martin Kletzander wrote: Until now, virt-install supported only one seclabel and it was the first one libvirt reported in capabilities. This patch adds support for more of them and also adds a functionality to try to match the right one from the label given. This is

Re: [virt-tools-list] [virt-manager v3]Add virtio-scsi disk bus option

2012-12-05 Thread Cole Robinson
On 12/03/2012 05:25 AM, Chen Hanxiao wrote: From: ChenHanxiao chenhanx...@cn.fujitsu.com This patch will add virtio-scsi bus option on Add New Virtual Hardware GUI page. It will support users to add a virtual disk using SCSI bus with a controller model virtio-scsi. If there is no SCSI

Re: [virt-tools-list] [libosinfo 1/2] install-config: Document expected kbd layout format

2012-12-05 Thread Christophe Fergeau
On Mon, Dec 03, 2012 at 11:48:07PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- osinfo/osinfo_install_config.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_install_config.c

Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for = F18

2012-12-05 Thread Christophe Fergeau
Hey I don't think it's good to duplicate the mapping twice, and that's a good candidate for these datamaps. Christophe On Mon, Dec 03, 2012 at 11:48:08PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Now that we have established what kind of string to

[virt-tools-list] [virt-viewer][PATCH 1/2 v2] Sanitize syntax-check

2012-12-05 Thread Michal Privoznik
make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/virt-viewer-file.c * src/virt-viewer-file.c: add #include config.h * data/virt-viewer-debug.nsis.in: remove empty line at EOF --- data/virt-viewer-debug.nsis.in |1 -

Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for = F18

2012-12-05 Thread Zeeshan Ali (Khattak)
On Wed, Dec 5, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey Hi, I don't think it's good to duplicate the mapping twice, and that's a good candidate for these datamaps. I agree but for now we can do it this way. Once we have the datamaps in place, we can make use of them

Re: [virt-tools-list] [virt-viewer][PATCH 1/2 v2] Sanitize syntax-check

2012-12-05 Thread Marc-André Lureau
ack - Mensaje original - make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/virt-viewer-file.c * src/virt-viewer-file.c: add #include config.h * data/virt-viewer-debug.nsis.in: remove empty line at EOF ---

Re: [virt-tools-list] [virt-viewer][PATCH 1/2 v2] Sanitize syntax-check

2012-12-05 Thread Michal Privoznik
On 05.12.2012 17:17, Marc-André Lureau wrote: ack Thanks, I've pushed the whole patchset. Michal - Mensaje original - make syntax-check is producing some errors about empty line at EOF and missing #include config.h in src/virt-viewer-file.c * src/virt-viewer-file.c: add #include

Re: [virt-tools-list] [libosinfo 2/8] Make OsinfoMedia::os a weak reference

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 3:23 PM, Christophe Fergeau cferg...@redhat.com wrote: On Mon, Dec 03, 2012 at 12:23:31PM +0100, Christophe Fergeau wrote: OsinfoOs stores a list of media when it's part of an OsinfoDb. If these OsinfoMedia took a reference on the OsinfoOs they are part of, we'd get a

Re: [virt-tools-list] [libosinfo 1/8] Add OsinfoMedia::os property

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: --- osinfo/osinfo_media.c | 51 ++- osinfo/osinfo_media.h | 2 ++ 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/osinfo/osinfo_media.c

Re: [virt-tools-list] [libosinfo 3/8] Set OsinfoOs::media for OSes stored in an OsinfoDb

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: --- ACK. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] [libosinfo 5/8] Add osinfo_db_identify_media

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: --- osinfo/libosinfo.syms | 2 + osinfo/osinfo_db.c| 105 +- osinfo/osinfo_db.h| 2 + test/test-isodetect.c | 10 ++--- tools/osinfo-detect.c | 12

Re: [virt-tools-list] [libosinfo 6/8] Deprecate osinfo_db_guess_os_from_media

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: --- osinfo/osinfo_db.c | 38 +++--- osinfo/osinfo_db.h | 1 + 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/osinfo/osinfo_db.c b/osinfo/osinfo_db.c index

Re: [virt-tools-list] [libosinfo 7/8] rfc: Infer ISO language from label

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: Now that libosinfo has an osinfo_db_identify_media method which modifies the media it was passed, we can generate properties which needs information from the media stored in the OsinfoDB, and information from the

Re: [virt-tools-list] [libosinfo 8/8] win: Add lang-regex tags

2012-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 3, 2012 at 1:23 PM, Christophe Fergeau cferg...@redhat.com wrote: Now that libosinfo knows how to use the lang-regex OsinfoDB attribute, we can add this data to the various Windows media definitions in the database. ACK and I'm assuming you'll remove the same entries from patch

[virt-tools-list] [PATCH virt-viewer] Use monitor geometry, not screen size

2012-12-05 Thread Marc-André Lureau
In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I introduced a regression: going fullscreen would no longer match client and guest resolution correctly. A GdkScreen is not necessarily the physical screen monitor size. Lookup the physical monitor size using

Re: [virt-tools-list] [libosinfo] build-sys: Fix circular make dependency

2012-12-05 Thread Zeeshan Ali (Khattak)
On Wed, Dec 5, 2012 at 6:17 PM, Christophe Fergeau cferg...@redhat.com wrote: osinfo_enum_types.h was depending on libosinfo_1_0_include_HEADERS, which contains osinfo_enum_types.h. This caused a build-time warning from make about a circular dependency. ACK and thanks for fixing this mess I