Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for >= F18

2012-12-06 Thread Zeeshan Ali (Khattak)
On Thu, Dec 6, 2012 at 4:06 PM, Christophe Fergeau wrote: > On Thu, Dec 06, 2012 at 03:12:36PM +0200, Zeeshan Ali (Khattak) wrote: >> On Wed, Dec 5, 2012 at 6:08 PM, Zeeshan Ali (Khattak) >> wrote: >> > On Wed, Dec 5, 2012 at 5:56 PM, Christophe Fergeau >> > wrote: >> >> Hey >> > >> > Hi, >> >

Re: [virt-tools-list] [virt-install PATCH 0/2] Cleanup manpage generation

2012-12-06 Thread Michal Privoznik
On 06.12.2012 16:47, Martin Kletzander wrote: > I added the generation of manpages to the build stage and removed the > manpages that are now being generated there. > > Martin Kletzander (2): > setup: rebuild manpages in build phase > Remove and ignore build-generated files > > .gitignore

Re: [virt-tools-list] [libosinfo] Device drivers API/data

2012-12-06 Thread Michal Privoznik
On 05.12.2012 15:02, Zeeshan Ali (Khattak) wrote: > These patches add means for apps to find and fetch device drivers and to tell > installer about where to find pre- and post-installation device drivers. > > Also included is the first implementation: virtio storage device drivers for > Windows XP

[virt-tools-list] [virt-install PATCH 1/2] setup: rebuild manpages in build phase

2012-12-06 Thread Martin Kletzander
Until now, the manpages were rebuilt only in sdist phase, this patch changes it to be part of the build phase as well. --- setup.py | 96 +--- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/setup.py b/setup.py index 7019c

[virt-tools-list] [virt-install PATCH 0/2] Cleanup manpage generation

2012-12-06 Thread Martin Kletzander
I added the generation of manpages to the build stage and removed the manpages that are now being generated there. Martin Kletzander (2): setup: rebuild manpages in build phase Remove and ignore build-generated files .gitignore|1 + man/en/virt-clone.1 | 311 --- m

Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for >= F18

2012-12-06 Thread Christophe Fergeau
On Thu, Dec 06, 2012 at 03:12:36PM +0200, Zeeshan Ali (Khattak) wrote: > On Wed, Dec 5, 2012 at 6:08 PM, Zeeshan Ali (Khattak) > wrote: > > On Wed, Dec 5, 2012 at 5:56 PM, Christophe Fergeau > > wrote: > >> Hey > > > > Hi, > > > >> I don't think it's good to duplicate the mapping twice, and that

Re: [virt-tools-list] [libosinfo 2/2] fedora, installer: Set keyboard config for >= F18

2012-12-06 Thread Zeeshan Ali (Khattak)
On Wed, Dec 5, 2012 at 6:08 PM, Zeeshan Ali (Khattak) wrote: > On Wed, Dec 5, 2012 at 5:56 PM, Christophe Fergeau > wrote: >> Hey > > Hi, > >> I don't think it's good to duplicate the mapping twice, and that's a good >> candidate for these datamaps. > > I agree but for now we can do it this way.

Re: [virt-tools-list] [libosinfo 4/4] loader: Fix leak in osinfo_loader_os

2012-12-06 Thread Michal Privoznik
On 06.12.2012 10:54, Christophe Fergeau wrote: > --- > osinfo/osinfo_loader.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c > index bb7949e..b392a43 100644 > --- a/osinfo/osinfo_loader.c > +++ b/osinfo/osinfo_loader.c > @@ -982,6 +982,7 @

Re: [virt-tools-list] [PATCH virt-viewer] Use monitor geometry, not screen size

2012-12-06 Thread Christophe Fergeau
On Wed, Dec 05, 2012 at 06:37:39PM +0100, Marc-André Lureau wrote: > In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I > introduced a regression: going fullscreen would no longer match client > and guest resolution correctly. > > A GdkScreen is not necessarily the physical screen mon

[virt-tools-list] [libosinfo 3/4] loader: Don't leak 'arch'

2012-12-06 Thread Christophe Fergeau
--- osinfo/osinfo_loader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c index 606e413..bb7949e 100644 --- a/osinfo/osinfo_loader.c +++ b/osinfo/osinfo_loader.c @@ -729,6 +729,7 @@ static OsinfoMedia *osinfo_loader_media (OsinfoLoader *load

[virt-tools-list] [libosinfo 2/4] loader: Set GError on osinfo_loader_nodeset failures

2012-12-06 Thread Christophe Fergeau
Most of the code in OsinfoLoader check if osinfo_loader_nodeset set a GError to see if it failed and never test if it returned -1. Better to make sure that we actually set the GError when this function fails. --- osinfo/osinfo_loader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/osinfo/o

[virt-tools-list] [libosinfo 4/4] loader: Fix leak in osinfo_loader_os

2012-12-06 Thread Christophe Fergeau
--- osinfo/osinfo_loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c index bb7949e..b392a43 100644 --- a/osinfo/osinfo_loader.c +++ b/osinfo/osinfo_loader.c @@ -982,6 +982,7 @@ static void osinfo_loader_os(OsinfoLoader *loader,

[virt-tools-list] [libosinfo 1/4] loader: Use xmlFree to free libxml2 strings

2012-12-06 Thread Christophe Fergeau
As libxml2 and glib memory allocation functions can be overridden with custom functions, it's important to use the right free functions for allocated memory. --- osinfo/osinfo_loader.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/osinfo/osinfo_load

Re: [virt-tools-list] [virt-manager v3]Add virtio-scsi disk bus option

2012-12-06 Thread Chen HanXiao
Thanks for the review. New patch will be posted soon. Regards > -Original Message- > From: Cole Robinson [mailto:crobi...@redhat.com] > Sent: Wednesday, December 05, 2012 11:23 PM > To: Chen Hanxiao > Cc: virt-tools-list@redhat.com > Subject: Re: [virt-tools-list][virt-manager v3]Add vir