From: "Zeeshan Ali (Khattak)"
According to the documentation, we expect apps to specify full paths for
disks and locations so we must assume they are so in the scripts.
---
data/install-scripts/fedora.xml | 12 ++--
data/install-scripts/windows-cmd.xml | 2 +-
2 files changed, 7 in
On Fri, Dec 7, 2012 at 7:12 PM, Christophe Fergeau wrote:
> On Fri, Dec 07, 2012 at 07:02:05PM +0200, Zeeshan Ali (Khattak) wrote:
>> On Fri, Dec 7, 2012 at 6:55 PM, Christophe Fergeau
>> wrote:
>> > On Fri, Dec 07, 2012 at 03:55:22PM +0200, Zeeshan Ali (Khattak) wrote:
>> >> I really don't see
On Fri, Dec 07, 2012 at 07:02:05PM +0200, Zeeshan Ali (Khattak) wrote:
> On Fri, Dec 7, 2012 at 6:55 PM, Christophe Fergeau
> wrote:
> > On Fri, Dec 07, 2012 at 03:55:22PM +0200, Zeeshan Ali (Khattak) wrote:
> >> I really don't see any way to remove the duplication other than either
> >> using da
On Fri, Dec 7, 2012 at 2:55 PM, Christophe Fergeau wrote:
> On Fri, Dec 07, 2012 at 03:55:22PM +0200, Zeeshan Ali (Khattak) wrote:
>> I really don't see any way to remove the duplication other than either
>> using datamaps or removing the fix for one of the profiles.
>
> The good news is that the
On Fri, Dec 7, 2012 at 6:55 PM, Christophe Fergeau wrote:
> On Fri, Dec 07, 2012 at 03:55:22PM +0200, Zeeshan Ali (Khattak) wrote:
>> I really don't see any way to remove the duplication other than either
>> using datamaps or removing the fix for one of the profiles.
>
> The good news is that the
On Fri, Dec 07, 2012 at 03:55:22PM +0200, Zeeshan Ali (Khattak) wrote:
> I really don't see any way to remove the duplication other than either
> using datamaps or removing the fix for one of the profiles.
The good news is that the datamap code at
http://cgit.freedesktop.org/~teuf/libosinfo/log/?h
This is ordered on the name of the property that is read/set
---
Pushed under the trivial rule
osinfo/libosinfo.syms | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
index c19f760..82f6f95 100644
--- a/osinfo/libosinfo.
On Fri, Dec 7, 2012 at 3:55 PM, Zeeshan Ali (Khattak)
wrote:
> On Fri, Dec 7, 2012 at 3:41 PM, Christophe Fergeau
> wrote:
>> On Fri, Dec 07, 2012 at 02:52:24PM +0200, Zeeshan Ali (Khattak) wrote:
>>> On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau
>>> wrote:
>>> > It depends, you did not
On Fri, Dec 7, 2012 at 4:37 PM, Zeeshan Ali (Khattak)
wrote:
> On Fri, Dec 7, 2012 at 3:22 PM, Michal Privoznik wrote:
>> When generating documentation I've noticed couple of warnings produced
>> by gtk-doc like missing field description or incorrect format of enum
>> items description and so on.
On Fri, Dec 7, 2012 at 3:22 PM, Michal Privoznik wrote:
> When generating documentation I've noticed couple of warnings produced
> by gtk-doc like missing field description or incorrect format of enum
> items description and so on.
All patches look good. Thanks and ACK series.
--
Regards,
Zees
On Fri, Dec 7, 2012 at 11:34 AM, Christophe Fergeau wrote:
> Hi,
>
> libosinfo has various *List classes which basically are a GObject class
> wrapping a hash table of objects of a specific type. Each of these classes
> implements osinfo_list_new_filtered, osinfo_list_new_copy, ... probably
> beca
On Fri, Dec 7, 2012 at 3:41 PM, Christophe Fergeau wrote:
> On Fri, Dec 07, 2012 at 02:52:24PM +0200, Zeeshan Ali (Khattak) wrote:
>> On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau
>> wrote:
>> > It depends, you did not explain at all why you'd prefer to keep things this
>> > way for now. I
On Fri, Dec 07, 2012 at 02:52:24PM +0200, Zeeshan Ali (Khattak) wrote:
> On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau
> wrote:
> > It depends, you did not explain at all why you'd prefer to keep things this
> > way for now. If it would take significant time to remove the duplication,
> > t
These files were still missing function arguments description:
* osinfo/osinfo_install_script.c
* osinfo/osinfo_os.c
---
osinfo/osinfo_install_script.c | 14 ++
osinfo/osinfo_os.c |1 +
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/osinfo/osinfo_in
This patch adds small description to each undocumented
argument for each function within osinfo_install_config.c.
---
osinfo/osinfo_install_config.c | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/osinfo/osinfo_install_config.c b/osinfo/osinfo_inst
---
osinfo/osinfo_install_config_param.h |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/osinfo/osinfo_install_config_param.h
b/osinfo/osinfo_install_config_param.h
index dfed04e..fae6cc4 100644
--- a/osinfo/osinfo_install_config_param.h
+++ b/osinfo/osinfo_instal
When generating documentation I've noticed couple of warnings produced
by gtk-doc like missing field description or incorrect format of enum
items description and so on.
Michal Privoznik (4):
Suppress gtk-doc warnings on missing field description
osinfo_install_config.c: Describe function argu
On 07.12.2012 13:16, Christophe Fergeau wrote:
> osinfo_loader_install_config_params.h defines
> OSINFO_INSTALL_CONFIG_PARAMS_* constants, better to use these
> rather than string literals.
> ---
> osinfo/osinfo_loader.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a
Each public visible struct and enum must have documented
items. If it hasn't, gtk-doc produces a lot of warnings.
However, things it's complaining about doesn't have any
interesting attributes, so mark them as private.
---
osinfo/osinfo_avatar_format.h|1 +
osinfo/osinfo_db.h
Hi
- Mensaje original -
> My reasoning was that gtk_widget_get_screen(GTK_WIDGET(self));
> operates on
> a subwindow of the application, not on the main one, so it's
> inconsistent
> with the use of _get_root_window. I don't think this will cause
Hmm.
> practical
> problems, but I though
On Fri, Dec 7, 2012 at 10:06 AM, Christophe Fergeau wrote:
> On Fri, Dec 07, 2012 at 03:43:37AM +0200, Zeeshan Ali (Khattak) wrote:
>> On Thu, Dec 6, 2012 at 4:06 PM, Christophe Fergeau
>> wrote:
>> > On Thu, Dec 06, 2012 at 03:12:36PM +0200, Zeeshan Ali (Khattak) wrote:
>> >> On Wed, Dec 5, 201
On Fri, Dec 07, 2012 at 12:31:36PM +0100, Michal Privoznik wrote:
> On 07.12.2012 09:46, Christophe Fergeau wrote:
> > libosinfo.syms contains the osinfo_install_config_param_new symbol
> > twice. Reorder the LIBOSINFO_0.2.0 section to make this obvious,
> > and remove the duplicated symbol.
> > --
On Fri, Dec 07, 2012 at 12:10:04PM +0100, Michal Privoznik wrote:
> On 07.12.2012 09:30, Christophe Fergeau wrote:
> > This is a follow-up to my previous series fixing leaks as a similar
> > one was just introduced.
> > ---
> > osinfo/osinfo_loader.c | 4 +++-
> > 1 file changed, 3 insertions(+),
osinfo_list.h uses OsinfoFilter so it must include osinfo_filter.h
to be self-contained.
---
osinfo/osinfo_list.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/osinfo/osinfo_list.h b/osinfo/osinfo_list.h
index fd60b1d..57ca684 100644
--- a/osinfo/osinfo_list.h
+++ b/osinfo/osinfo_list.h
@@
osinfo_loader_install_config_params.h defines
OSINFO_INSTALL_CONFIG_PARAMS_* constants, better to use these
rather than string literals.
---
osinfo/osinfo_loader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index 5d92df4.
On 07.12.2012 09:46, Christophe Fergeau wrote:
> A few static methods were prefixed with osinfo_os_ instead of
> osinfo_install_script_
> ---
> osinfo/osinfo_install_script.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/osinfo/osinfo_install_scri
On 07.12.2012 09:46, Christophe Fergeau wrote:
> Some newly added tags were missing from the description
> ---
> osinfo/osinfo_loader.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
> index 62b92f9..5d92df4 100644
> ---
On 07.12.2012 09:46, Christophe Fergeau wrote:
> ---
> osinfo/osinfo_install_script.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
> index b891aaf..c752434 100644
> --- a/osinfo/osinfo_install_script.c
> +++ b/os
On 07.12.2012 09:46, Christophe Fergeau wrote:
> Fabiano made significant work in the installer code, this commit
> adds his copyright to the files where he is listed in the 'Authors'
> section, this makes things clearer.
> ---
> osinfo/osinfo_avatar_format.c| 1 +
> osinfo/osinfo_install_
On 07.12.2012 09:46, Christophe Fergeau wrote:
> libosinfo.syms contains the osinfo_install_config_param_new symbol
> twice. Reorder the LIBOSINFO_0.2.0 section to make this obvious,
> and remove the duplicated symbol.
> ---
> osinfo/libosinfo.syms | 5 ++---
> 1 file changed, 2 insertions(+), 3 d
On 07.12.2012 09:30, Christophe Fergeau wrote:
> This is a follow-up to my previous series fixing leaks as a similar
> one was just introduced.
> ---
> osinfo/osinfo_loader.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.
On Fri, Dec 07, 2012 at 05:22:00AM -0500, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > On Wed, Dec 05, 2012 at 06:37:39PM +0100, Marc-André Lureau wrote:
> > > In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I
> > > introduced a regression: going fullscreen would
From: ChenHanxiao
This patch will add virtio-scsi bus option on "Add New Virtual
Hardware" GUI page. It will support users to add a virtual disk
using SCSI bus with a controller model virtio-scsi.
If there is no SCSI controller existed, a new SCSI controller by
model 'virtio-scsi' will be added a
- Mensaje original -
> On Wed, Dec 05, 2012 at 06:37:39PM +0100, Marc-André Lureau wrote:
> > In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I
> > introduced a regression: going fullscreen would no longer match
> > client
> > and guest resolution correctly.
> >
> > A GdkSc
These methods were never part of a libosinfo release, so we can
remove them without breaking ABI.
---
osinfo/libosinfo.syms | 4 --
osinfo/osinfo_device_driverlist.c | 77 ---
osinfo/osinfo_device_driverlist.h | 7
3 files changed, 88 deletion
The generic equivalent provided by OsinfoList should be used instead.
---
osinfo/osinfo_deploymentlist.c | 4
osinfo/osinfo_deploymentlist.h | 4
osinfo/osinfo_devicelinklist.c | 4
osinfo/osinfo_devicelinklist.h | 4
osinfo/osinfo_devicelist.c | 4
We need to do that before deprecating all the derived class
implementations of osinfo_xxxlist_new_*.
---
osinfo/osinfo_db.c| 25 -
osinfo/osinfo_os.c| 11 ---
test/test-devicelist.c| 6 +++---
test/test-oslist.c| 6 +++--
Hi,
libosinfo has various *List classes which basically are a GObject class
wrapping a hash table of objects of a specific type. Each of these classes
implements osinfo_list_new_filtered, osinfo_list_new_copy, ... probably
because of c&p. However, these methods are seldomly used, and are not used
Currently, every class inheriting from OsinfoList reimplements
_new_copy, _new_filtered, _new_intersection and _new_union. This
commit adds generic implementations of these methodes in OsinfoList
which will allow us to deprecate all the other implementations.
---
osinfo/libosinfo.syms | 10 +++--
On Thu, Dec 06, 2012 at 11:56:43AM +0100, Michal Privoznik wrote:
> On 06.12.2012 10:54, Christophe Fergeau wrote:
> > ---
> > osinfo/osinfo_loader.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
> > index bb7949e..b392a43 100644
>
---
I've already pushed this patch by mistake, sending it now for review, I'll
just revert it if it has issues.
Christophe
osinfo/osinfo_loader.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
ind
This is a follow-up to my previous series fixing leaks as a similar
one was just introduced.
---
osinfo/osinfo_loader.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index 62b92f9..e630793 100644
--- a/osinfo/osinfo_loader.c
---
osinfo/osinfo_install_script.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index b891aaf..c752434 100644
--- a/osinfo/osinfo_install_script.c
+++ b/osinfo/osinfo_install_script.c
@@ -289,6 +289,15 @@ gboolean osin
A few static methods were prefixed with osinfo_os_ instead of
osinfo_install_script_
---
osinfo/osinfo_install_script.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index c752434..6808d41
Fabiano made significant work in the installer code, this commit
adds his copyright to the files where he is listed in the 'Authors'
section, this makes things clearer.
---
osinfo/osinfo_avatar_format.c| 1 +
osinfo/osinfo_install_config_param.c | 1 +
osinfo/osinfo_install_config_param.h
Some newly added tags were missing from the description
---
osinfo/osinfo_loader.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index 62b92f9..5d92df4 100644
--- a/osinfo/osinfo_loader.c
+++ b/osinfo/osinfo_loader.c
@@ -1147,
libosinfo.syms contains the osinfo_install_config_param_new symbol
twice. Reorder the LIBOSINFO_0.2.0 section to make this obvious,
and remove the duplicated symbol.
---
osinfo/libosinfo.syms | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/osinfo/libosinfo.syms b/osinfo/li
On Fri, Dec 07, 2012 at 03:43:37AM +0200, Zeeshan Ali (Khattak) wrote:
> On Thu, Dec 6, 2012 at 4:06 PM, Christophe Fergeau
> wrote:
> > On Thu, Dec 06, 2012 at 03:12:36PM +0200, Zeeshan Ali (Khattak) wrote:
> >> On Wed, Dec 5, 2012 at 6:08 PM, Zeeshan Ali (Khattak)
> >> wrote:
> >> > On Wed, De
48 matches
Mail list logo
