Re: [virt-tools-list] [PATCH virt-viewer] Fix send-key menu not showing in fullscreen with gtk3 (rhbz#913601)

2013-02-21 Thread Christophe Fergeau
On Thu, Feb 21, 2013 at 06:30:11PM +0100, Hans de Goede wrote: > This should also fix the send-key menu showing in the wrong position with a > gtk2 build, when the tooltray icon is clicked on the 2nd or higher monitor. ACK Christophe pgpYw4gC59Dtk.pgp Description: PGP signature

Re: [virt-tools-list] [virt-viewer] Be more consistent in #if/#ifdef use

2013-02-21 Thread Hans de Goede
ACK. On 02/21/2013 06:24 PM, Christophe Fergeau wrote: Some of the code is checking for spice-gtk/oVirt availability by using #ifdef HAVE_XXX, and some of the code is using #if HAVE_XXX. As configure.ac only AC_DEFINE() HAVE_XXX when XXX could be found, let's use the #ifdef HAVE_XXX form everywh

[virt-tools-list] [PATCH virt-viewer] Fix send-key menu not showing in fullscreen with gtk3 (rhbz#913601)

2013-02-21 Thread Hans de Goede
This should also fix the send-key menu showing in the wrong position with a gtk2 build, when the tooltray icon is clicked on the 2nd or higher monitor. Signed-off-by: Hans de Goede --- src/virt-viewer-window.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/virt-viewer-window.c b/src/v

[virt-tools-list] [virt-viewer] Be more consistent in #if/#ifdef use

2013-02-21 Thread Christophe Fergeau
Some of the code is checking for spice-gtk/oVirt availability by using #ifdef HAVE_XXX, and some of the code is using #if HAVE_XXX. As configure.ac only AC_DEFINE() HAVE_XXX when XXX could be found, let's use the #ifdef HAVE_XXX form everywhere --- src/remote-viewer-main.c | 10 +- src/rem

[virt-tools-list] [[virt-viewer PATCHv3]] Add oVirt support

2013-02-21 Thread Christophe Fergeau
This commit adds support for ovirt:// URIs. It does so by using libgovirt to get the spice/vnc connection information through oVirt xmlrpc API. --- configure.ac| 18 src/Makefile.am | 8 ++ src/remote-viewer.c | 230 +++- virt-vie

Re: [virt-tools-list] [[virt-viewer PATCHv2]] Add oVirt support

2013-02-21 Thread Christophe Fergeau
Self-NACK, I forgot to squash one change in, see the v3 instead. Christophe On Thu, Feb 21, 2013 at 06:10:20PM +0100, Christophe Fergeau wrote: > This commit adds support for ovirt:// URIs. It does so by using > libgovirt to get the spice/vnc connection information through > oVirt xmlrpc API. > -

Re: [virt-tools-list] [virt-viewer] Add oVirt support

2013-02-21 Thread Christophe Fergeau
On Fri, Jan 25, 2013 at 04:13:35PM +0100, Marc-André Lureau wrote: > Hi > > it looks good me, > > On Thu, Jan 24, 2013 at 4:57 PM, Christophe Fergeau > wrote: > > @@ -240,3 +256,5 @@ AC_MSG_NOTICE([ LIBXML2: $LIBXML2_CFLAGS > > $LIBXML2_LIBS]) > > AC_MSG_NOTICE([]) > > AC_MSG_NOTICE([

[virt-tools-list] [[virt-viewer PATCHv2]] Add oVirt support

2013-02-21 Thread Christophe Fergeau
This commit adds support for ovirt:// URIs. It does so by using libgovirt to get the spice/vnc connection information through oVirt xmlrpc API. --- configure.ac| 18 src/Makefile.am | 8 ++ src/remote-viewer.c | 240 +++- virt-vie

[virt-tools-list] [python-virtinst PATCH] virt-clone: Properly propagate --replace parameter

2013-02-21 Thread Martin Kletzander
Solves https://bugzilla.redhat.com/show_bug.cgi?id=913382 Due to the '--replace' parameter not being propagated properly, the clone of a guest with already existing name fails. --- virtinst/CloneManager.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virtinst/CloneManager.py b/virtinst/C

Re: [virt-tools-list] [PATCH] Update tips for Checkbox "Allocate entire disk now"

2013-02-21 Thread Michal Privoznik
On 21.02.2013 06:27, Chen Hanxiao wrote: > From: Chen Hanxiao > > As discussed in: > https://www.redhat.com/archives/virt-tools-list/2013-February/msg00154.html > There is a bug when creating disk image as qcow2, enable > fully allocating but get the minimal sparse image. > > We should give user