[virt-tools-list] [PATCH virt-viewer 2/2] Add example of an oVirt URI to the manpage

https://bugzilla.redhat.com/show_bug.cgi?id=1142769 --- man/remote-viewer.pod | 5 + 1 file changed, 5 insertions(+) diff --git a/man/remote-viewer.pod b/man/remote-viewer.pod index 1683e44..b3b0bbc 100644 --- a/man/remote-viewer.pod +++ b/man/remote-viewer.pod @@ -306,6 +306,11 @@ To connect

[virt-tools-list] [PATCH virt-viewer 1/2] Add documentation for fullscreen monitor mapping

see https://bugzilla.redhat.com/show_bug.cgi?id=1142769 --- man/remote-viewer.pod | 43 --- man/virt-viewer.pod | 34 ++ 2 files changed, 70 insertions(+), 7 deletions(-) diff --git a/man/remote-viewer.pod b/man/remote-view

[virt-tools-list] [PATCH virt-viewer] Initialize fullscreen display map to fallback

If uuid was never set, we never checked the 'fallback' monitor map. Initializing the monitor map to the fallback value at startup solves this issue. This allows fallback mode to work with older servers that don't send the UUID. --- src/virt-viewer-app.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [virt-tools-list] [virt-viewer: PATCH 3/4 v3] Let the user cancel the SPICE auth dialog

ACK On Wed, 2014-09-24 at 13:49 +0200, Fabiano Fidêncio wrote: > virt_viewer_auth_collect_credentials() was recently changed to return > a boolean instead of an integer (2561c171). This change introduced a > regression in the authentication dialog behavior, making it impossible > for the user to c

Re: [virt-tools-list] [virt-viewer: PATCH 2/4 v2] Improve authentication error messages

On Wed, 2014-09-24 at 13:49 +0200, Fabiano Fidêncio wrote: > Adding a better error message to our default error message, based on the > libvirt error. Also, the libvirt error is shown as debug. > > https://bugzilla.redhat.com/show_bug.cgi?id=1142742 > --- > v2: > - Add a special case with our own

Re: [virt-tools-list] [PATCH v4 remote-viewer] Connecting to ovirt without specifying VM name will not fail

Looking good, but a few more comments below. On Thu, 2014-09-25 at 14:56 +0200, Pavel Grunt wrote: > When a user tries to connect to ovirt without specifying > VM name (remote-viewer ovirt://ovirt.example.com) or with > wrong VM name a list of available virtual machines is shown, > and the user ma

Re: [virt-tools-list] [virt-viewer: PATCH 1/4] Simplify virt_viewer_auth_libvirt_credentials() return value logic

ACK On Wed, 2014-09-24 at 13:49 +0200, Fabiano Fidêncio wrote: > As the function should return < 0 in error cases, let's explicitly > return/set the return value to -1 in error cases. Otherwise, the > function will return 0. > > This patch also fixes a regression introduced by (a5ce2ed3). > > ht

[virt-tools-list] [PATCH virt-viewer] Unset app 'fullscreen' when leaving fullscreen

Previously, the fullscreen floating toolbar and the "toggle-fullscreen" hotkey (which maps to the menu item action) had slightly different methods of exiting fullscreen. The floating toolbar method unset the 'fullscreen' property on the application (which causes all windows to simultaneously exit f

[virt-tools-list] [virt-viewer: PATCH v2] Ask for username when connecting with SASL

When connecting with SASL for authentication, some authentication mechanisms need a username (the plain text and md5 ones, for example). --- v2: - Fix check for username logic, v1 would introduce a regression in the code --- src/virt-viewer-session-spice.c | 80 +---

Re: [virt-tools-list] [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

On 09/25/2014 10:08 AM, Laszlo Ersek wrote: > On 09/25/14 14:59, Michal Privoznik wrote: > >>> (3) I just realized that a domain's name can change during its lifetime. >> >> Well, the only moment that we support that is migration. Otherwise the >> name can't be changed (it's not only varstore path

Re: [virt-tools-list] [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

On 09/25/14 14:59, Michal Privoznik wrote: > On 21.09.2014 16:58, Laszlo Ersek wrote: >> Hi Cole and Michal, >> >> I'm attaching three patches: >> >> >> >> (2) Unfortunately, even libvirtd needs to be modified, in addition. >> >> My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (

Re: [virt-tools-list] [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

On 21.09.2014 16:58, Laszlo Ersek wrote: Hi Cole and Michal, I'm attaching three patches: > (2) Unfortunately, even libvirtd needs to be modified, in addition. My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I verified that with gdb), but libvirtd doesn't act upon it cor

[virt-tools-list] [PATCH v4 remote-viewer] Connecting to ovirt without specifying VM name will not fail

When a user tries to connect to ovirt without specifying VM name (remote-viewer ovirt://ovirt.example.com) or with wrong VM name a list of available virtual machines is shown, and the user may pick a machine he wants to connect to. --- v4: - new GError types were added for handling the cancellatio

Re: [virt-tools-list] [virt-viewer: PATCH 4/4] Auto fill the username field in the auth dialog

On Wed, Sep 24, 2014 at 1:49 PM, Fabiano Fidêncio wrote: > --- > src/virt-viewer.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/virt-viewer.c b/src/virt-viewer.c > index 9f51b2f..828b6e5 100644 > --- a/src/virt-viewer.c > +++ b/src/virt-viewer.c > @@ -640,6 +640,12 @@ > vir

[virt-tools-list] [PATCH] Ask for username when connecting with SASL

When connecting with SASL for authentication, some authentication mechanisms need a username (the plain text and md5 ones, for example). --- For testing this patch, please, apply these 3 patches sent to spice-de...@lists.freedesktop.org: [0]: http://lists.freedesktop.org/archives/spice-devel/2014