[virt-tools-list] [virt-viewer][PATCH 1/3 v2] virt-viewer-app: Moved reconnect from VV to app

Reconnect field in virt-viewer moved into virt-viewer-app and changed to property. New getter function implemented for it. This will be used in virt-viewer-window.c for implementing a "reconnect" button in the GUI. --- Changes since v1: - Moved the reconnect property from virt-viewer.c into virt-v

[virt-tools-list] [virt-viewer][PATCH 3/3 v2] virt-viewer-app: Added reconnect button to preferences

Added a new preferences tab, and a reconnect CheckButton into virt-viewer-preferences.xml. They are implicitly set to hidden. If compiling virt-viewer, USING_VIRT_VIEWER is defined and their visibility is set to true in virt_viewer_app_get_preferences(). --- Changes since v1: - Added a new prefer

Re: [virt-tools-list] [virt-viewer][PATCH 1/3] virt-viewer: Changed reconnect field to property

Hi, Just one comment below, On Tue, May 12, 2015 at 12:21:02PM +0200, Lukas Venhoda wrote: > Reconnect field in virt-viewer.c changed to property. > This will be used in virt-viewer-window.c for implementing a "reconnect" > button in the GUI. > --- > In virt_viewer_new() function, there's comment

Re: [virt-tools-list] [virt-viewer][PATCH 3/3] virt-viewer-window: Added reconnect button to GUI

On Tue, May 12, 2015 at 12:21 PM, Lukas Venhoda wrote: > Added a reconnect CheckMenuItem into virt-viewer.xml. > This button is implicitly set to hidden. > If compiling virt-viewer, USING_VIRT_VIEWER is defined and > visibility of the button is set to true in virt_viewer_window_init. > > The r

[virt-tools-list] [virt-viewer][PATCH 2/3] Makefile.am: Added new define for virt-viewer

Added define USING_VIRT_VIEWER when compiling virt-viewer. This will be needed when compiling virt-viewer with the "Reconnect" GUI button, because it can be only implemented in virt-viewer and not remote-viewer. --- I thought of many other ways around this, but ultimately, ifdef seemed like the cle

[virt-tools-list] [virt-viewer][PATCH 3/3] virt-viewer-window: Added reconnect button to GUI

Added a reconnect CheckMenuItem into virt-viewer.xml. This button is implicitly set to hidden. If compiling virt-viewer, USING_VIRT_VIEWER is defined and visibility of the button is set to true in virt_viewer_window_init. The reconnect button callback gets the button state (true/false) and set the

[virt-tools-list] [virt-viewer][PATCH 1/3] virt-viewer: Changed reconnect field to property

Reconnect field in virt-viewer.c changed to property. This will be used in virt-viewer-window.c for implementing a "reconnect" button in the GUI. --- In virt_viewer_new() function, there's comment "/* should probably be properties instead */". If someone thinks it's a good idea, I can change all o