Re: [virt-tools-list] [virt-manager][PATCH 3/3] Modify the machine type for s390x.All machine types begin with "s390x-ccw" will by set to the default machine type "s390-ccw-virtio".

2015-11-04 Thread Kevin Zhao
Hi Cole , Thanks for merging my patch. I choose to check for the prefix because that the next version of KVMIBM may change the machine type,they are not always have the machine type "s390-ccw-virtio ", so I preserve the checking for the machine type. On 2015年11月05日 03:53, Cole Robinson wrote:

Re: [virt-tools-list] [virt-manager][PATCH 3/3] Modify the machine type for s390x.All machine types begin with "s390x-ccw" will by set to the default machine type "s390-ccw-virtio".

2015-11-04 Thread Cole Robinson
On 11/04/2015 01:30 AM, Kevin Zhao wrote: > --- > virtinst/capabilities.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/capabilities.py b/virtinst/capabilities.py > index 4fa1724..10e7ea0 100644 > --- a/virtinst/capabilities.py > +++

Re: [virt-tools-list] [PATCH 3/5] Update gitignore

2015-11-04 Thread Eduardo Lima (Etrunko)
On 11/03/2015 10:57 AM, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 03, 2015 at 09:38:24AM -0200, Eduardo Lima (Etrunko) wrote: >> >> Yes, you can find those in the final Makefile, but test-driver is the >> only one missing. Maybe a bug in automake? > > Makefile.am has a

[virt-tools-list] [PATCH 4/6] Update MAINTAINERCLEANFILES variables

2015-11-04 Thread Eduardo Lima (Etrunko)
Makefile.am: Use helper variables from git.mk man/Makefile.am: This should be $(dist_man_MANS) instead of $(man_MANS) Signed-off-by: Eduardo Lima (Etrunko) --- Makefile.am | 18 +++--- man/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 16 deletions(-)

[virt-tools-list] [PATCH 3/6] Update git.mk from latest upstream version

2015-11-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- git.mk | 221 - 1 file changed, 178 insertions(+), 43 deletions(-) diff --git a/git.mk b/git.mk index 0b26b23..bd39ae1 100644 --- a/git.mk +++ b/git.mk @@ -1,14 +1,19 @@

[virt-tools-list] [PATCH 5/6] Move declaration to the beginning of the file

2015-11-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index ca264c8..dd8dbba 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -71,6 +71,7 @@ static

[virt-tools-list] [PATCH 2/6] Call intltoolize after autoreconf

2015-11-04 Thread Eduardo Lima (Etrunko)
After removing m4/.gitignore file in previous patch, I started getting the following error when running autogen.sh. ln: failed to create symbolic link ‘m4/intltool.m4’: No such file or directory cp: cannot create regular file ‘m4/intltool.m4’: No such file or directory intltoolize: cannot copy

Re: [virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

2015-11-04 Thread Fabiano Fidêncio
On Tue, Nov 3, 2015 at 3:20 PM, Fabiano Fidêncio wrote: > On Tue, Nov 3, 2015 at 12:14 PM, Eduardo Lima (Etrunko) > wrote: >> On 02/11/15 04:08, Fabiano Fidêncio wrote: >>> Hey! >>> >>> On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) >>>

Re: [virt-tools-list] [PATCH] Reading cursor-release hotkey set-up from settings file

2015-11-04 Thread Pavel Grunt
Hi Snir, On Mon, 2015-10-26 at 18:58 +0200, Snir Sheriber wrote: > While opening nested remote-viewers, cursor-release doesn't effect the > inner remote-viewer (hotkey for both is identical) > > Checking for cursor release setup in the settings file, > overriding existing command line and vv

Re: [virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

2015-11-04 Thread Eduardo Lima (Etrunko)
On 04/11/15 11:39, Fabiano Fidêncio wrote: > On Tue, Nov 3, 2015 at 3:20 PM, Fabiano Fidêncio wrote: >> On Tue, Nov 3, 2015 at 12:14 PM, Eduardo Lima (Etrunko) >> wrote: >>> On 02/11/15 04:08, Fabiano Fidêncio wrote: Hey! On Thu, Oct 29,

Re: [virt-tools-list] [PATCH 4/6] Update MAINTAINERCLEANFILES variables

2015-11-04 Thread Christophe Fergeau
On Wed, Nov 04, 2015 at 12:32:45PM -0200, Eduardo Lima (Etrunko) wrote: > Makefile.am: Use helper variables from git.mk > man/Makefile.am: This should be $(dist_man_MANS) instead of $(man_MANS) Having these 2 commit split in the previous iteration was imo better, but no need to resplit them. A

[virt-tools-list] [PATCH v2 0/6] [virt-viewer] Some cosmetic fixes

2015-11-04 Thread Eduardo Lima (Etrunko)
Resend of my cleanup series, please take a look. In this new version, I have found what was causing the errors running autogen.sh and updated git.mk from upstream. Eduardo Lima (Etrunko) (6): Remove m4/.gitignore file Call intltoolize after autoreconf Update git.mk from latest upstream

Re: [virt-tools-list] [PATCH 2/6] Call intltoolize after autoreconf

2015-11-04 Thread Christophe Fergeau
On Wed, Nov 04, 2015 at 04:23:33PM +0100, Christophe Fergeau wrote: > Hey, > > (did not get 0/6 and 1/6 for some reason but they are in the mailing > list archives > https://www.redhat.com/archives/virt-tools-list/2015-November/msg00041.html ) Still did not get them, but ACK series (sorry for

Re: [virt-tools-list] [PATCH 2/6] Call intltoolize after autoreconf

2015-11-04 Thread Christophe Fergeau
Hey, (did not get 0/6 and 1/6 for some reason but they are in the mailing list archives https://www.redhat.com/archives/virt-tools-list/2015-November/msg00041.html ) On Wed, Nov 04, 2015 at 12:32:43PM -0200, Eduardo Lima (Etrunko) wrote: > After removing m4/.gitignore file in previous patch, I

[virt-tools-list] [PATCH 1/6] Remove m4/.gitignore file

2015-11-04 Thread Eduardo Lima (Etrunko)
All .gitignore files are handled by git.mk and should not be part of the repository. Signed-off-by: Eduardo Lima (Etrunko) --- m4/.gitignore | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 m4/.gitignore diff --git a/m4/.gitignore b/m4/.gitignore