Re: [virt-tools-list] [c...@centos.org: Build failed in Jenkins: virt-viewer-build » libvirt-centos-6 #712]

On Mon, 2016-02-15 at 21:58 +0100, Fabiano Fidêncio wrote: > Daniel, > > On Mon, Feb 15, 2016 at 6:01 PM, Daniel P. Berrange com> wrote: > > On Mon, Feb 15, 2016 at 05:57:01PM +0100, Fabiano Fidêncio wrote: > > > Daniel. > > > > > > On Mon, Feb 15, 2016 at 5:09 PM, Daniel P.

[virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is

[virt-tools-list] [PATCH v5 virt-viewer 0/3] Port to GtkApplication API's

In this version: Rebased to latest master Eduardo Lima (Etrunko) (3): Port to GtkApplication API's remote-viewer: Remove unused properties Drop old compatibility code configure.ac| 6 +- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 -

[virt-tools-list] [PATCH v5 2/3] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 101

[virt-tools-list] [PATCH v5 3/3] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 -

Re: [virt-tools-list] [c...@centos.org: Build failed in Jenkins: virt-viewer-build » libvirt-centos-6 #712]

Daniel, On Mon, Feb 15, 2016 at 6:01 PM, Daniel P. Berrange wrote: > On Mon, Feb 15, 2016 at 05:57:01PM +0100, Fabiano Fidêncio wrote: >> Daniel. >> >> On Mon, Feb 15, 2016 at 5:09 PM, Daniel P. Berrange >> wrote: >> > Some recent patches appear to

Re: [virt-tools-list] [PATCH v4 2/5] Minor code cleanups

On Mon, Feb 15, 2016 at 9:05 PM, Jonathon Jongsma wrote: > On Mon, 2016-02-15 at 12:31 -0200, Eduardo Lima (Etrunko) wrote: >> - Reuse #ifdef HAVE_SPICE_GTK block for include. >> - Move declaration of vfunc together with others of the same class. >> - Move variable

Re: [virt-tools-list] [virt-viewer v4] Drop support to gtk2

On Mon, Feb 15, 2016 at 9:38 PM, Jonathon Jongsma wrote: > Looks good, thanks! > > Acked-by: Jonathon Jongsma 18:48 < fidencio> jjongsma: autobuild.sh told me that the patch is not okay and I'll have to amend this to the patch:

Re: [virt-tools-list] [virt-viewer v4] Drop support to gtk2

Looks good, thanks! Acked-by: Jonathon Jongsma On Mon, 2016-02-15 at 21:33 +0100, Fabiano Fidêncio wrote: > The 3.0 release was the last one that still supports GTK2. For the > Windows builds the support to GTK2 was dropped in the previous release. > Let's do the same for

[virt-tools-list] [virt-viewer v4] Drop support to gtk2

The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. Signed-off-by: Eduardo Lima (Etrunko) -- Changes since v3: - Addressed Jonathon's

Re: [virt-tools-list] [PATCH v4 1/5] Drop support to gtk2

On Mon, 2016-02-15 at 12:31 -0200, Eduardo Lima (Etrunko) wrote: > From: Fabiano Fidêncio > > The 3.0 release was the last one that still supports GTK2. For the > Windows builds the support to GTK2 was dropped in the previous release. > Let's do the same for the entire

Re: [virt-tools-list] SOLVED: virt-manager SPICE console over ssh

On 02/15/2016 12:56 PM, Ian Pilcher wrote: > I knew this rang a bell ... > > The problem was that the SPICE server was configured to listen on the > wildcard address (0.0.0.0). > > > > > > Getting rid of the listen address makes things work. > > > Makes me wonder what

[virt-tools-list] SOLVED: virt-manager SPICE console over ssh

I knew this rang a bell ... The problem was that the SPICE server was configured to listen on the wildcard address (0.0.0.0). Getting rid of the listen address makes things work. -- Ian Pilcher

Re: [virt-tools-list] virt-manager SPICE console over ssh

On 02/15/2016 11:14 AM, Cole Robinson wrote: Can you provide virt-manager --debug output? It will show the address the app is trying to connect to Full output at http://pastebin.com/vwVWs89U I'm guessing that the relevant lines are: [Mon, 15 Feb 2016 11:33:10 virt-manager 19295] DEBUG

Re: [virt-tools-list] virt-manager SPICE console over ssh

On 02/15/2016 09:31 AM, Ian Pilcher wrote: > I am unable to connect to a remote (qemu+ssh://...) SPICE console from > virt-manager: > > Error: viewer connection to hypervisor host got refused or > disconnected! > > The odd thing is that virt-viewer works just fine when I specify the >

Re: [virt-tools-list] [c...@centos.org: Build failed in Jenkins: virt-viewer-build » libvirt-centos-6 #712]

On Mon, Feb 15, 2016 at 05:57:01PM +0100, Fabiano Fidêncio wrote: > Daniel. > > On Mon, Feb 15, 2016 at 5:09 PM, Daniel P. Berrange > wrote: > > Some recent patches appear to have broken the build... > > Pavel already posted a patch that will be pushed soon. > It seems

Re: [virt-tools-list] [PATCH virt-viewer] display: Use correct variable name

On Mon, 2016-02-15 at 17:55 +0100, Fabiano Fidêncio wrote: > On Mon, Feb 15, 2016 at 5:53 PM, Pavel Grunt > wrote: > > Fix gtk2 build > > --- > >  src/virt-viewer-display.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/virt-viewer-display.c

Re: [virt-tools-list] [c...@centos.org: Build failed in Jenkins: virt-viewer-build » libvirt-centos-6 #712]

Daniel. On Mon, Feb 15, 2016 at 5:09 PM, Daniel P. Berrange wrote: > Some recent patches appear to have broken the build... Pavel already posted a patch that will be pushed soon. It seems like the right time for applying the pending patch that drops Gtk2 support. What do

Re: [virt-tools-list] [PATCH virt-viewer] display: Use correct variable name

On Mon, Feb 15, 2016 at 5:53 PM, Pavel Grunt wrote: > Fix gtk2 build > --- > src/virt-viewer-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c > index bac0c7c..e3f86a3 100644 > ---

[virt-tools-list] [PATCH virt-viewer] display: Use correct variable name

Fix gtk2 build --- src/virt-viewer-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c index bac0c7c..e3f86a3 100644 --- a/src/virt-viewer-display.c +++ b/src/virt-viewer-display.c @@ -378,7 +378,7 @@ void

[virt-tools-list] [c...@centos.org: Build failed in Jenkins: virt-viewer-build » libvirt-centos-6 #712]

Some recent patches appear to have broken the build... - Forwarded message from c...@centos.org - > Date: Mon, 15 Feb 2016 13:25:50 + (GMT+00:00) > From: c...@centos.org > To: shaj...@redhat.com, berra...@redhat.com > Subject: Build failed in Jenkins: virt-viewer-build »

Re: [virt-tools-list] [PATCH v4 3/5] Port to GtkApplication API's

On 02/15/2016 12:31 PM, Eduardo Lima (Etrunko) wrote: > diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c > index 3a958f0..14549fd 100644 > --- a/src/virt-viewer-window.c > +++ b/src/virt-viewer-window.c > @@ -346,8 +346,7 @@ virt_viewer_window_init (VirtViewerWindow *self) >

[virt-tools-list] [PATCH v4 3/5] Port to GtkApplication API's

Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is

[virt-tools-list] [PATCH v4 virt-viewer 0/5] Port to GtkApplication API's

In this version: Rebased to latest master, fixed conflicts in virt-viewer-display.c. Fix patch #3 according to review by Fabiano Fidencio. Remove virt-glib-compat.[ch] files entirely from the tree. All functions are now covered with new version requirements. Eduardo Lima (Etrunko) (4): Minor

[virt-tools-list] virt-manager SPICE console over ssh

I am unable to connect to a remote (qemu+ssh://...) SPICE console from virt-manager: Error: viewer connection to hypervisor host got refused or disconnected! The odd thing is that virt-viewer works just fine when I specify the qemu+ssh://... URL on the command line. Here is the graphics

[virt-tools-list] [PATCH v4 4/5] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 101

[virt-tools-list] [PATCH v4 1/5] Drop support to gtk2

From: Fabiano Fidêncio The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH v4 5/5] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 -

[virt-tools-list] [PATCH v4 2/5] Minor code cleanups

- Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 13 +++-- 1 file changed, 7

Re: [virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

On 02/15/2016 11:57 AM, Fabiano Fidêncio wrote: > > NACK from me. > There is no reason for keeping an empty virt-glib-compat.c file. > virt-glib-compat.h also could be removed entirely as g_clear_pointer() > was introduced in 2.34. So, please, remove both files from the tree. > > Reviewed-by:

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

On Mon, Feb 15, 2016 at 2:57 PM, Eduardo Lima (Etrunko) wrote: > On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote: > [snip] > >>> >>> cleanup: >>> -g_free(uri); >>> -if (viewer) >>> -g_object_unref(viewer); >>> -g_strfreev(args); >>> -g_clear_error();

Re: [virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > With glib requirements now being 2.38, these functions do not make > sense anymore > > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/virt-glib-compat.c | 15 --- >  src/virt-glib-compat.h | 27

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote: [snip] >> >> cleanup: >> -g_free(uri); >> -if (viewer) >> -g_object_unref(viewer); >> -g_strfreev(args); >> -g_clear_error(); >> - >> +g_object_unref(viewer); > > g_object_unref() shouldn't be called with a NULL

Re: [virt-tools-list] [PATCH v3 4/5] remote-viewer: Remove unused properties

On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > The reason for using properties to access those members was to ensure > that they would only be set during the creation of the object. Now > that > we removed that restriction, we set private members directly. > > Signed-off-by:

Re: [virt-tools-list] [PATCH v3 2/5] Minor code cleanups

On 02/15/2016 11:51 AM, Fabiano Fidêncio wrote: > > Acked-by: Fabiano Fidêncio > > Anyways. was this patch already ACKed in the previous iterations, no? > It might have, but I don't have write permissions to the repositories, so I can't push. -- Eduardo de Barros Lima

Re: [virt-tools-list] [PATCH v3 2/5] Minor code cleanups

On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > - Reuse #ifdef HAVE_SPICE_GTK block for include. > - Move declaration of vfunc together with others of the same class. > - Move variable declaration to the top of the function. > > Signed-off-by: Eduardo Lima (Etrunko)

Re: [virt-tools-list] [PATCH v3 1/5] Drop support to gtk2

On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > From: Fabiano Fidêncio > > The 3.0 release was the last one that still supports GTK2. For the > Windows builds the support to GTK2 was dropped in the previous > release. > Let's do the same for the entire

Re: [virt-tools-list] [PATCH v3 1/5] Drop support to gtk2

On 02/15/2016 11:48 AM, Fabiano Fidêncio wrote: > > This patch got already ACKed in one of the previous iterations? > If yes, I'll push it. If it's not the case, I cannot ACK my own patch > though :-) > I can ack it for you :P. But this one is already outdated due to Pavel's recent changes in

Re: [virt-tools-list] [PATCH virt-viewer v3] app: Compute monitor mapping only in fullscreen

On Mon, Feb 15, 2016 at 12:14 PM, Pavel Grunt wrote: > --- > v3: g_return changed to early return > v2: move monitor config setting from _set_uuid_string() > --- > src/virt-viewer-app.c | 26 -- > 1 file changed, 20 insertions(+), 6 deletions(-) > >

[virt-tools-list] [PATCH virt-viewer v3] app: Compute monitor mapping only in fullscreen

--- v3: g_return changed to early return v2: move monitor config setting from _set_uuid_string() --- src/virt-viewer-app.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index c49d3e8..60157e9 100644

Re: [virt-tools-list] [PATCH virt-viewer v2] app: Compute monitor mapping only in fullscreen

Pavel, On Mon, Feb 15, 2016 at 11:53 AM, Pavel Grunt wrote: > --- > v2: move monitor config setting from _set_uuid_string() > --- > src/virt-viewer-app.c | 26 -- > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/src/virt-viewer-app.c

[virt-tools-list] [PATCH virt-viewer v2] app: Compute monitor mapping only in fullscreen

--- v2: move monitor config setting from _set_uuid_string() --- src/virt-viewer-app.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index c49d3e8..9d6 100644 --- a/src/virt-viewer-app.c +++

Re: [virt-tools-list] [PATCH virt-viewer v2] app: Do not show usbredir button without session

On Mon, Feb 15, 2016 at 8:15 AM, Pavel Grunt wrote: > The button is visible in the fullscreen toolbar when waiting for a guest. > Clicking on it causes the runtime warning: > virt-viewer-CRITICAL **: virt_viewer_session_usb_device_selection: assertion >