Re: [virt-tools-list] [PATCH v4 3/5] Port to GtkApplication API's

2016-02-16 Thread Jonathon Jongsma
Looks pretty good. Comments inline. On Mon, 2016-02-15 at 12:31 -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes

Re: [virt-tools-list] countless password requests

2016-02-16 Thread Cole Robinson
The password prompts are because each remote spice connection requires needs to open many different channels, each channel will prompt for a password if you don't have SSH keys setup. So, setup ssh keys like Fabiano suggests. It will fix your problem - Cole On 02/16/2016 11:16 AM, LK wrote: > Hi

Re: [virt-tools-list] countless password requests

2016-02-16 Thread LK
Hi Fabiano, the password is asked by virt-manager when I try to connect to the remote host. After the first request I insert the root password and I can see the list of virtual machines on the remote host. But, If I try to open one of this virtual machine, virt-manager starts asking countless

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Pavel Grunt
On Tue, 2016-02-16 at 13:21 -0200, Eduardo Lima (Etrunko) wrote: > On 02/16/2016 10:41 AM, Pavel Grunt wrote: > > Hi, > > > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > > > Most of this patch consists in code being shuffled around to fit > > > the > > > expected flow while

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Fabiano Fidêncio
On Tue, Feb 16, 2016 at 1:41 PM, Pavel Grunt wrote: > Hi, > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >>

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Eduardo Lima (Etrunko)
On 02/16/2016 10:41 AM, Pavel Grunt wrote: > Hi, > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >> patch the less intrusive as

Re: [virt-tools-list] [PATCH v5 2/3] remote-viewer: Remove unused properties

2016-02-16 Thread Pavel Grunt
Ack, Pavel On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > The reason for using properties to access those members was to ensure > that they would only be set during the creation of the object. Now > that > we removed that restriction, we set private members directly. > >

Re: [virt-tools-list] [PATCH v5 3/3] Drop old compatibility code

2016-02-16 Thread Pavel Grunt
Ack, Pavel On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > With glib requirements now being 2.38, these functions do not make > sense anymore. > > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/Makefile.am |  2 - >  

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Pavel Grunt
Hi, On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes are: > > - Updated build