Re: [virt-tools-list] [PATCH virtio-win-pkg-scripts v3 0/2] helpers to standardize driver directory layout

On 02/08/2016 11:07 AM, Roman Kagan wrote: > On Mon, Feb 08, 2016 at 12:35:21PM +0100, Christophe Fergeau wrote: >> For what it's worth, I've had success building (did not test) qemu-ga >> with mingw using the attached spec file. > > We build it in a similar way and use it in our testing for some

Re: [virt-tools-list] [PATCH virtio-win-pkg-scripts v3 0/2] helpers to standardize driver directory layout

On 02/08/2016 09:23 AM, Roman Kagan wrote: > On Sat, Feb 06, 2016 at 06:20:42PM -0500, Cole Robinson wrote: >> Sorry for the delay, been caught up in other stuff. I'll be focusing on >> virtio-win stuff this coming week though >> >> I've committed these patches now. I added a few commits on top to

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

On 02/17/2016 01:22 PM, Jonathon Jongsma wrote: >>> I disagree, but again, I think it is basically a matter of >>> preference. >> >> It is. From the macro name it is not clear for me how is different >> "GOTO_END" from "goto end" > > For what it's worth, I agree with Pavel here. I think it

Re: [virt-tools-list] countless password requests

Thanks! The ssh keys setup suggested by Fabiano works fine. LK Am 16.02.2016 um 17:31 schrieb Cole Robinson: The password prompts are because each remote spice connection requires needs to open many different channels, each channel will prompt for a password if you don't have SSH keys setup.

Re: [virt-tools-list] [PATCH v6 virt-viewer 0/3] Port to GtkApplication API's

On Wed, 2016-02-17 at 11:01 -0200, Eduardo Lima (Etrunko) wrote: > In this version I addressed the comments made from review of v5. > - Rename virt_viewer_app_startup() to > virt_viewer_app_on_application_startup() > - Remove VIRT_VIEWER_VERSION error code and move --version option > handler

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

On Tue, 2016-02-16 at 17:17 +0100, Pavel Grunt wrote: > On Tue, 2016-02-16 at 13:21 -0200, Eduardo Lima (Etrunko) wrote: > > On 02/16/2016 10:41 AM, Pavel Grunt wrote: > > > Hi, > > > > > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > > > > Most of this patch consists in

[virt-tools-list] [PATCH v6 2/3] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 101

[virt-tools-list] [PATCH v6 3/3] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 -

[virt-tools-list] [PATCH v6 virt-viewer 0/3] Port to GtkApplication API's

In this version I addressed the comments made from review of v5. - Rename virt_viewer_app_startup() to virt_viewer_app_on_application_startup() - Remove VIRT_VIEWER_VERSION error code and move --version option handler to VirtViewerApp. - Removed {remote,virt}_viewer_new() functions and call

[virt-tools-list] [PATCH v6 1/3] Port to GtkApplication API's

Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is