Re: [virt-tools-list] [virt-viewer][PATCH 0/2] Couple of build fixes

2016-06-04 Thread Fabiano FidĂȘncio
Michal, On Sat, Jun 4, 2016 at 12:29 PM, Michal Privoznik wrote: > Just fixes for some of the problems I ran into lately. > > Michal Privoznik (2): > virt-viewer-display-vnc: Include virt-viewer-util.h > tests: Fix VPATH build > > src/virt-viewer-display-vnc.c | 1 + >

[virt-tools-list] [virt-viewer][PATCH 2/2] tests: Fix VPATH build

2016-06-04 Thread Michal Privoznik
So test-hotkeys include virt-viewer-app.h which includes virt-viewer-window.h which includes virt-viewer-display.h which in turn wants to include virt-viewer-enums.h. But, the enums header file is generated at build time into builddir not srcdir. Therefore it may happen if the two are distinct

[virt-tools-list] [virt-viewer][PATCH 0/2] Couple of build fixes

2016-06-04 Thread Michal Privoznik
Just fixes for some of the problems I ran into lately. Michal Privoznik (2): virt-viewer-display-vnc: Include virt-viewer-util.h tests: Fix VPATH build src/virt-viewer-display-vnc.c | 1 + tests/Makefile.am | 1 + 2 files changed, 2 insertions(+) -- 2.8.3

[virt-tools-list] [virt-viewer][PATCH 1/2] virt-viewer-display-vnc: Include virt-viewer-util.h

2016-06-04 Thread Michal Privoznik
In function virt_viewer_display_vnc_new() we are calling virt_viewer_signal_connect_object() which is defined in virt-viewer-util module. However, the header file for the module is never included. CC libvirt_viewer_la-virt-viewer-display-vnc.lo virt-viewer-display-vnc.c: In function