Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote: > On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: >> Create toolbar widget in the loop > > NACK from my side. > There is any gain on re-factoring a code that will be removed as soon > as we do the release. > Actually, it just

[virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

Let's just stick with default theme colors. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-notebook.c | 13 ++--- src/virt-viewer-window.c | 10 -- 2 files changed, 2 insertions(+), 21

Re: [virt-tools-list] [virt-viewer v2 2/4] timed-revealer: Don't release reference we don't own

On Tue, Jun 28, 2016 at 5:23 PM, Fabiano Fidêncio wrote: > From: Christophe Fergeau > > VirtViewerTimedRevealer::evBox is created in > virt_viewer_timed_revealer_new() and will be passed to > gtk_container_add() through gtk_overlay_add_overlay(overlay, >

Re: [virt-tools-list] [virt-viewer v2 4/4] window: Don't take a reference on 'toolbar'

On Tue, Jun 28, 2016 at 5:23 PM, Fabiano Fidêncio wrote: > From: Christophe Fergeau > > VirtViewerTimedRevealer now derives from GtkEventBox/GtkContainer, so > it follows GTK+ conventions and takes ownership of the floating ref on > 'toolbar'. Since

Re: [virt-tools-list] [virt-viewer v2 1/4] timed-revealer: Fix "revealer" refcounting

On Tue, Jun 28, 2016 at 5:22 PM, Fabiano Fidêncio wrote: > From: Christophe Fergeau > > virt_viewer_timed_revealer_new calls gtk_container_add on the instance > returned by gtk_revealer_new so VirtViewerTimedRevealer does not own any > ref on this

Re: [virt-tools-list] [virt-viewer v2 1/4] timed-revealer: Fix "revealer" refcounting

Hey, if you want to add Pavel's backtrace to one of the commit logs, I think it was pointing at this g_clear_object line, so you could add it the the log here. Christophe On Tue, Jun 28, 2016 at 05:22:59PM +0200, Fabiano Fidêncio wrote: > From: Christophe Fergeau > >

Re: [virt-tools-list] [virt-viewer v2 3/4] timed-revealer: Inherit from GtkEventBox

Acked-by: Christophe Fergeau On Tue, Jun 28, 2016 at 05:23:01PM +0200, Fabiano Fidêncio wrote: > As suggested by Christophe, inheriting from GtkEventBox instead of > having one instance of it as a member can help us to get rid of >

[virt-tools-list] [virt-viewer v2 2/4] timed-revealer: Don't release reference we don't own

From: Christophe Fergeau VirtViewerTimedRevealer::evBox is created in virt_viewer_timed_revealer_new() and will be passed to gtk_container_add() through gtk_overlay_add_overlay(overlay, virt_viewer_timed_revealer_get_overlay_widget(priv->revealer)) This means

[virt-tools-list] [virt-viewer v2 1/4] timed-revealer: Fix "revealer" refcounting

From: Christophe Fergeau virt_viewer_timed_revealer_new calls gtk_container_add on the instance returned by gtk_revealer_new so VirtViewerTimedRevealer does not own any ref on this GtkRevealer instance. Unrefing it in _dispose() is thus wrong. ---

[virt-tools-list] [virt-viewer v2 4/4] window: Don't take a reference on 'toolbar'

From: Christophe Fergeau VirtViewerTimedRevealer now derives from GtkEventBox/GtkContainer, so it follows GTK+ conventions and takes ownership of the floating ref on 'toolbar'. Since VirtViewerWindow and VirtViewerTimedRevealer will have the same lifespan, we don't need to

[virt-tools-list] [virt-viewer v2 3/4] timed-revealer: Inherit from GtkEventBox

As suggested by Christophe, inheriting from GtkEventBox instead of having one instance of it as a member can help us to get rid of virt_viewer_timed_revealer_get_overlay_widget(). --- src/virt-viewer-timed-revealer.c | 35 --- src/virt-viewer-timed-revealer.h | 7

Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: > Create toolbar widget in the loop NACK from my side. There is any gain on re-factoring a code that will be removed as soon as we do the release. Actually, it just makes my life harder in order to rebase Sagar's patches on

[virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

Create toolbar widget in the loop --- src/virt-viewer-window.c | 121 --- 1 file changed, 83 insertions(+), 38 deletions(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 1ebb423..b276ae8 100644 --- a/src/virt-viewer-window.c

Re: [virt-tools-list] [PATCH] timed-revealer: Inherit from GtkEventBox

Hey, On Tue, Jun 28, 2016 at 04:18:30PM +0200, Fabiano Fidêncio wrote: > As suggested by Christophe, inheritting from GtkEventBox instead of > having one instance of it as a member can help us to get rid of > virt_viewer_timed_revealer_get_overlay_widget() and also makes more > natural that we

[virt-tools-list] [PATCH] timed-revealer: Inherit from GtkEventBox

As suggested by Christophe, inheritting from GtkEventBox instead of having one instance of it as a member can help us to get rid of virt_viewer_timed_revealer_get_overlay_widget() and also makes more natural that we take ownership of the GtkToolbar floating ref. This change also fixes the crash

Re: [virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

On 06/28/2016 07:21 AM, Fabiano Fidêncio wrote: > On Tue, Jun 28, 2016 at 12:08 PM, Pavel Grunt wrote: >> Hi Eduardo, >> >> On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote: >>> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 >>> >>> Signed-off-by:

Re: [virt-tools-list] [PATCH virt-viewer] window: Keep reference on timed revealer

On Tue, Jun 28, 2016 at 02:03:02PM +0200, Pavel Grunt wrote: > Avoid crash when closing virt-viewer due to multiple unrefs in > virt_viewer_timed_revealer_dispose and virt_viewer_window_dispose: > #0 0x73e92c9d in g_type_check_instance_is_fundamentally_a () at >

Re: [virt-tools-list] [PATCH virt-viewer] window: Keep reference on timed revealer

On Tue, Jun 28, 2016 at 2:03 PM, Pavel Grunt wrote: > Avoid crash when closing virt-viewer due to multiple unrefs in > virt_viewer_timed_revealer_dispose and virt_viewer_window_dispose: > #0 0x73e92c9d in g_type_check_instance_is_fundamentally_a () at >

[virt-tools-list] [PATCH virt-viewer] window: Keep reference on timed revealer

Avoid crash when closing virt-viewer due to multiple unrefs in virt_viewer_timed_revealer_dispose and virt_viewer_window_dispose: #0 0x73e92c9d in g_type_check_instance_is_fundamentally_a () at /lib64/libgobject-2.0.so.0 #1 0x73e722a5 in g_object_unref () at

Re: [virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

On Tue, Jun 28, 2016 at 12:08 PM, Pavel Grunt wrote: > Hi Eduardo, > > On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote: >> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> >> As a

Re: [virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

Hi Eduardo, On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 > > Signed-off-by: Eduardo Lima (Etrunko) > --- > > As a result of commit cc455b7f916110d7cfae6b7af753349e070c9494, setting > custom color

Re: [virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

Etrunko, On Mon, Jun 27, 2016 at 11:00 PM, Eduardo Lima (Etrunko) wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 > > Signed-off-by: Eduardo Lima (Etrunko) > --- > > As a result of commit cc455b7f916110d7cfae6b7af753349e070c9494, setting

Re: [virt-tools-list] [PATCH virt-viewer] package: Add appdata metadata for Gnome Software

On Mon, Jun 27, 2016 at 05:20:54PM +0200, Lukáš Venhoda wrote: > Adds metadata to be used with Gnome Software. > Includes name, summary, description and three screenshots of remote-viewer. > --- > data/Makefile.am | 9 +++-- > data/remote-viewer.appdata.xml.in | 29