[virt-tools-list] [PATCH 5/5] virtinst: Add --smbios command line option

2016-07-12 Thread Charles Arnold
Signed-off-by: Charles Arnold diff --git a/tests/clitest.py b/tests/clitest.py index b63a92a..52b9cd1 100644 --- a/tests/clitest.py +++ b/tests/clitest.py @@ -427,6 +427,10 @@ c.add_compare("""--pxe \ --memorybacking size=1,unit='G',nodeset='1,2-5',nosharepages=yes,locked=yes

[virt-tools-list] [PATCH 2/5] virtinst: Add --smbios command line option

2016-07-12 Thread Charles Arnold
Add an smbios sub-element to the os element for supporting the --smbios command line option Signed-off-by: Charles Arnold diff --git a/virtinst/osxml.py b/virtinst/osxml.py index 2bbd466..54e118b 100644 --- a/virtinst/osxml.py +++ b/virtinst/osxml.py @@ -77,7 +77,7 @@ class

[virt-tools-list] [PATCH 1/5] virtinst: Add --smbios command line option

2016-07-12 Thread Charles Arnold
Add the --smbios command line option with all supported arguments. Signed-off-by: Charles Arnold diff --git a/virtinst/cli.py b/virtinst/cli.py index 432640b..4f9a13b 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -67,6 +67,7 @@ from .osxml import OSXML from .pm import

[virt-tools-list] [PATCH 4/5] virtinst: Add --smbios command line option

2016-07-12 Thread Charles Arnold
Classes for building and installing with libvirt XML for the defining of SMBios information to a guest. Signed-off-by: Charles Arnold diff --git a/virtinst/sysinfo.py b/virtinst/sysinfo.py new file mode 100644 index 000..eca7921 --- /dev/null +++ b/virtinst/sysinfo.py @@

[virt-tools-list] [PATCH 3/5] virtinst: Add --smbios command line option

2016-07-12 Thread Charles Arnold
Add a sysinfo element to the guest XML for smbios information Signed-off-by: Charles Arnold diff --git a/virtinst/guest.py b/virtinst/guest.py index 6a42536..173aa04 100644 --- a/virtinst/guest.py +++ b/virtinst/guest.py @@ -52,6 +52,7 @@ from .idmap import IdMap from .osxml

Re: [virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Victor Toso
Hi, On Tue, Jul 12, 2016 at 03:38:52PM +0200, Christophe Fergeau wrote: > On Tue, Jul 12, 2016 at 02:19:02PM +0200, Victor Toso wrote: > > Documentation states that: > > "Client applications may take a reference on the @task object and use > > it to monitor the status of the file transfer

Re: [virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Christophe Fergeau
On Tue, Jul 12, 2016 at 02:19:02PM +0200, Victor Toso wrote: > Documentation states that: > "Client applications may take a reference on the @task object and use > it to monitor the status of the file transfer task." > > We have been monitoring SpiceFileTransferTask without reference it but >

Re: [virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Daniel P. Berrange
On Tue, Jul 12, 2016 at 02:22:54PM +0200, Fabiano Fidêncio wrote: > On Tue, Jul 12, 2016 at 2:19 PM, Victor Toso wrote: > > Documentation states that: > > "Client applications may take a reference on the @task object and use > > it to monitor the status of the file

Re: [virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Fabiano Fidêncio
On Tue, Jul 12, 2016 at 2:19 PM, Victor Toso wrote: > Documentation states that: > "Client applications may take a reference on the @task object and use > it to monitor the status of the file transfer task." > > We have been monitoring SpiceFileTransferTask without

[virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Victor Toso
Documentation states that: "Client applications may take a reference on the @task object and use it to monitor the status of the file transfer task." We have been monitoring SpiceFileTransferTask without reference it but since the introduction of file transfer dialog we also unref it after task

Re: [virt-tools-list] [PATCH] virt-viewer: ensure we close when seeing domain stop event

2016-07-12 Thread Fabiano Fidêncio
On Tue, Jul 12, 2016 at 12:29 PM, Daniel P. Berrange wrote: > Normally virt-viewer relies on the VNC/SPICE widget seeing > an EOF on its underlying connection to detect when the > session is closed. > > When tunnelling to a remote guest over SSH though, this > EOF can be

[virt-tools-list] [PATCH] virt-viewer: ensure we close when seeing domain stop event

2016-07-12 Thread Daniel P. Berrange
Normally virt-viewer relies on the VNC/SPICE widget seeing an EOF on its underlying connection to detect when the session is closed. When tunnelling to a remote guest over SSH though, this EOF can be delayed for a very long time, leaving a dead session open. This can be seen with virt-viewer

Re: [virt-tools-list] [PATCH] virt-viewer: fix display of guest name in title for vnc

2016-07-12 Thread Pavel Grunt
On Tue, 2016-07-12 at 11:11 +0100, Daniel P. Berrange wrote: > On Tue, Jul 12, 2016 at 12:04:54PM +0200, Pavel Grunt wrote: > > > > Hi, > > > > On Tue, 2016-07-12 at 10:48 +0100, Daniel P. Berrange wrote: > > > > > > The following commit broke the display of the guest name in > > > the title

Re: [virt-tools-list] [PATCH] virt-viewer: fix display of guest name in title for vnc

2016-07-12 Thread Pavel Grunt
Hi, On Tue, 2016-07-12 at 10:48 +0100, Daniel P. Berrange wrote: > The following commit broke the display of the guest name in > the title for VNC displays: > >   commit 61a1bc4dcbb056755fe96c5945f84c1312041059 >   Author: Pavel Grunt >   Date:   Wed Apr 15 13:50:35 2015

Re: [virt-tools-list] [PATCH] virt-viewer: fix display of guest name in title for vnc

2016-07-12 Thread Fabiano Fidêncio
On Tue, Jul 12, 2016 at 11:48 AM, Daniel P. Berrange wrote: > The following commit broke the display of the guest name in > the title for VNC displays: > > commit 61a1bc4dcbb056755fe96c5945f84c1312041059 > Author: Pavel Grunt > Date: Wed Apr 15

[virt-tools-list] [PATCH] virt-viewer: fix display of guest name in title for vnc

2016-07-12 Thread Daniel P. Berrange
The following commit broke the display of the guest name in the title for VNC displays: commit 61a1bc4dcbb056755fe96c5945f84c1312041059 Author: Pavel Grunt Date: Wed Apr 15 13:50:35 2015 +0200 session-vnc: Set window for display to avoid gtk-vnc v0.3.8 crash