[virt-tools-list] [PATCH virt-viewer 11/11] iso-dialog: Implement functionality provided by oVirt foreign menu

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c| 149 + src/resources/ui/remote-viewer-iso-list.ui | 4 +- 2 files changed, 152 insertions(+), 1 deletion(-) diff --git a/src/remote-viewer-iso-list-dialog.c

[virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 57 +++-- 1 file changed, 21 insertions(+), 36 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..ee23ba5

[virt-tools-list] [PATCH virt-viewer 09/11] Run iso-dialog when 'Change CD' menu is activated

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 29 + 2 files changed, 30 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index

[virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

2016-07-17 Thread Eduardo Lima (Etrunko)
With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-17 Thread Eduardo Lima (Etrunko)
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c | 20 +++-

[virt-tools-list] [PATCH virt-viewer 05/11] ovirt-foreign-menu: Remove GtkMenu related functions

2016-07-17 Thread Eduardo Lima (Etrunko)
With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-17 Thread Eduardo Lima (Etrunko)
Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 76 +++- 1 file changed, 36 insertions(+), 40 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer 02/11] ovirt-foreign-menu: Use g_clear_pointer/g_clear_object

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 68 1 file changed, 16 insertions(+), 52 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index b0b8fec..889e7bc 100644 ---

[virt-tools-list] [PATCH virt-viewer 08/11] Introduce ISO List dialog

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 115 +++ src/remote-viewer-iso-list-dialog.h| 58 ++ src/resources/ui/remote-viewer-iso-list.ui | 174

[virt-tools-list] [PATCH virt-viewer 04/11] ovirt-foreign-menu: Add accessors for current iso and iso list

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer 06/11] ovirt-foreign-menu: Notify of new files even if list did not change

2016-07-17 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 24b5af2..75154bb 100644 --- a/src/ovirt-foreign-menu.c +++

[virt-tools-list] [PATCH virt-viewer 00/11] Replace oVirt foreign menu with dedicated dialog

2016-07-17 Thread Eduardo Lima (Etrunko)
After analyzing the causes of the bug reported in rhbz #1310624, we came to the conclusion that the whole idea of having a menu to display a list remote files seemed wrong. A temporary solution has been provided until the code was reworked, and this is the result. Most of the changes is in