Re: [virt-tools-list] [PATCH 0/2] virtinst: Pass SMBios information to guest

>>> On 7/18/2016 at 12:54 PM, Cole Robinson wrote: > On 07/14/2016 10:06 AM, Charles Arnold wrote: >> This patchset introduces a command line option to pass smbios information to >> the guest. It adds an smbios mode sub-element to the guest's os element. The >> mode

Re: [virt-tools-list] [virt-install] Support for capturing guest serial console to a log file?

On 07/15/2016 10:58 AM, Kashyap Chamarthy wrote: > Currently, one could do a `virsh edit vm1`, to redirect guest serial > console output to a log file: > > > > > > > > > > > But that requires cumbersome manaul editing of the guest XML. Is it >

Re: [virt-tools-list] [PATCH 0/2] virtinst: Pass SMBios information to guest

On 07/14/2016 10:06 AM, Charles Arnold wrote: > This patchset introduces a command line option to pass smbios information to > the guest. It adds an smbios mode sub-element to the guest's os element. The > mode attribute must be specified and is either "emulate" (let the hypervisor > generate all

Re: [virt-tools-list] [PATCH virt-viewer v2 01/11] ovirt-foreign-menu: Rework states logic

On Mon, 2016-07-18 at 10:25 -0300, Eduardo Lima (Etrunko) wrote: > Use switch/case instead of lots of conditional blocks > > Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Pavel Grunt > --- >  src/ovirt-foreign-menu.c | 41

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On Mon, 2016-07-18 at 12:18 -0300, Eduardo Lima (Etrunko) wrote: > On 07/18/2016 11:58 AM, Pavel Grunt wrote: > > > > On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: > > > > > > On 07/18/2016 06:15 AM, Pavel Grunt wrote: > > > > > > > > > > > > Hi Eduardo, > > > > > > > > On

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On 07/18/2016 11:58 AM, Pavel Grunt wrote: > On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: >> On 07/18/2016 06:15 AM, Pavel Grunt wrote: >>> >>> Hi Eduardo, >>> >>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: Use switch/case instead of lots of

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: > On 07/18/2016 06:15 AM, Pavel Grunt wrote: > > > > Hi Eduardo, > > > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > > > > > > Use switch/case instead of lots of conditional blocks > > Yes, it is more

[virt-tools-list] [PATCH virt-viewer v2 01/11] ovirt-foreign-menu: Rework states logic

Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/src/ovirt-foreign-menu.c

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On 07/18/2016 06:15 AM, Pavel Grunt wrote: > Hi Eduardo, > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >> Use switch/case instead of lots of conditional blocks > Yes, it is more readable >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >>

Re: [virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

On 07/18/2016 09:14 AM, Pavel Grunt wrote: > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >> With the new ISO dialog, the user triggers the refresh manually. > > This should come after the dialog is introduced> Well, I have no plans in merging any of these patches

Re: [virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > With the new ISO dialog, the user triggers the refresh manually. This should come after the dialog is introduced> > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/ovirt-foreign-menu.c | 23

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

Hi Eduardo, On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > Use switch/case instead of lots of conditional blocks Yes, it is more readable > > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/ovirt-foreign-menu.c | 76