On 07/19/2016 12:32 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:04PM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 49
>> ++--
>>
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..af3ae46 100644
---
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 25 -
On 07/19/2016 02:54 PM, Eduardo Lima (Etrunko) wrote:
> On 07/19/2016 12:57 PM, Christophe Fergeau wrote:
>>> +
>>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog);
>>> +self->priv->foreign_menu = foreign_menu;
>>
>> I'd g_object_ref it if you need to have it around (together with
>>
On 07/19/2016 12:57 PM, Christophe Fergeau wrote:
>> +
>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog);
>> +self->priv->foreign_menu = foreign_menu;
>
> I'd g_object_ref it if you need to have it around (together with
> g_clear_object
> in dispose/finalize).
Okay, fixed.
>> +
>>
On 07/19/2016 01:13 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:08PM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/Makefile.am| 3 +
>> src/remote-viewer-iso-list-dialog.c|
On 07/19/2016 12:43 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:05PM -0300, Eduardo Lima (Etrunko) wrote:
>> With this commit, we finish cleaning up ovirt foreign menu code, which
>> only deals with data, leaving the UI bits to be handled properly in the
>> new ISO list dialog.
>
On 07/19/2016 12:10 PM, Daniel P. Berrange wrote:
> It appears that quite a few tests in virt-manager are currently
> failing. I'm unclear if this is due to genuine libvirt regressions,
> or the tests were relying on undefined behaviour which has now
> changed in libvirt
>
Hmm, I'm not sure
On 07/19/2016 12:11 PM, Christophe Fergeau wrote:
> On Mon, Jul 18, 2016 at 10:18:14AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 07/18/2016 09:14 AM, Pavel Grunt wrote:
>>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
With the new ISO dialog, the user triggers the refresh
On 07/19/2016 12:46 PM, Christophe Fergeau wrote:
> Your glade seems to have added unrelated changes to that commit. If
> newer versions of glade are always going to make these changes, we can
> commit them separately.
>
Dunno why all those changes got in, most likely because of different
On Sun, Jul 17, 2016 at 11:13:08PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/Makefile.am| 3 +
> src/remote-viewer-iso-list-dialog.c| 115 +++
>
It appears that quite a few tests in virt-manager are currently
failing. I'm unclear if this is due to genuine libvirt regressions,
or the tests were relying on undefined behaviour which has now
changed in libvirt
- Forwarded message from c...@centos.org -
> Date: Tue, 19 Jul 2016
On Sun, Jul 17, 2016 at 11:13:10PM -0300, Eduardo Lima (Etrunko) wrote:
> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
> we make it acessible via property to avoid interdependency between
> objects.
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
>
Your glade seems to have added unrelated changes to that commit. If
newer versions of glade are always going to make these changes, we can
commit them separately.
Christophe
On Sun, Jul 17, 2016 at 11:13:07PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
On Sun, Jul 17, 2016 at 11:13:05PM -0300, Eduardo Lima (Etrunko) wrote:
> With this commit, we finish cleaning up ovirt foreign menu code, which
> only deals with data, leaving the UI bits to be handled properly in the
> new ISO list dialog.
I'm not clear exactly what this is doing from the
Why?
On Sun, Jul 17, 2016 at 11:13:06PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/ovirt-foreign-menu.c
On Sun, Jul 17, 2016 at 11:13:04PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 49
> ++--
> src/ovirt-foreign-menu.h | 5 -
> 2 files changed, 39
On Mon, Jul 18, 2016 at 10:18:14AM -0300, Eduardo Lima (Etrunko) wrote:
> On 07/18/2016 09:14 AM, Pavel Grunt wrote:
> > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
> >> With the new ISO dialog, the user triggers the refresh manually.
> >
> > This should come after the dialog
Acked-by: Christophe Fergeau
On Sun, Jul 17, 2016 at 11:13:02PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 68
>
> 1 file changed, 16
On Mon, Jul 18, 2016 at 10:25:25AM -0300, Eduardo Lima (Etrunko) wrote:
> Use switch/case instead of lots of conditional blocks
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 41 +++--
> 1 file changed, 15
20 matches
Mail list logo