Re: [virt-tools-list] [PATCH virt-viewer] Fix resizing problem with recent gtk versions

On Sat, Jul 23, 2016 at 12:05 AM, Jonathon Jongsma wrote: > When using client-side decorations, as well as in certain other > situations (wayland, and windows in some cases), the window gradually > resizes larger and larger. > > This is caused by a change in how gtk

[virt-tools-list] [PATCH virt-viewer] Fix resizing problem with recent gtk versions

When using client-side decorations, as well as in certain other situations (wayland, and windows in some cases), the window gradually resizes larger and larger. This is caused by a change in how gtk interprets the sizes passed to gtk_window_resize(), particularly when client-side decorations

[virt-tools-list] [PATCH virt-viewer v2 10/12] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c | 31 +++

[virt-tools-list] [PATCH virt-viewer v2 09/12] Run iso-dialog when 'Change CD' menu is activated

Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 24 2 files changed, 25 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index

[virt-tools-list] [PATCH virt-viewer v2 05/12] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer v2 08/12] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 112 + src/remote-viewer-iso-list-dialog.h| 58

[virt-tools-list] [PATCH virt-viewer v2 06/12] ovirt-foreign-menu: Notify of new files even if nothing changed

When user presses the Refresh button in ISO dialog, the list is cleared, and currently, the only way it is informed of the new list is by the notify signal. The same applies when an error occurs while trying to change the current ISO. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer v2 04/12] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v2 00/12] Replace oVirt foreign menu with dedicated dialog

New version of the ISO list dialog, with changes suggested in first round of reviews and lots of bug fixes. Before sending v1 I had refactored a few bits and it introduced some serious crashes. On the UI side, we now use GtkStack instead of GtkNotebook and the last commit of the series also makes

[virt-tools-list] [PATCH virt-viewer v2 01/12] ovirt-foreign-menu: Rework states logic

Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Pavel Grunt --- src/ovirt-foreign-menu.c | 46 -- 1 file changed, 20 insertions(+), 26 deletions(-) diff

[virt-tools-list] [PATCH virt-viewer v2 07/12] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 ---

[virt-tools-list] [PATCH virt-viewer v2 03/12] ovirt-foreign-menu: Remove timer used to refresh iso list

With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v2 11/12] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c| 157 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 158 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-dialog.c

[virt-tools-list] [PATCH virt-viewer v2 02/12] ovirt-foreign-menu: Use g_clear_pointer/g_clear_object

Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Christophe Fergeau --- src/ovirt-foreign-menu.c | 68 1 file changed, 16 insertions(+), 52 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v2 12/12] iso-dialog: Use header bar for buttons

It seems to give more modern look to the dialog, but it requires Gtk+ 3.12, thus I will am keeping this commit separated. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac| 4 ++-- src/remote-viewer-iso-list-dialog.c | 33