[virt-tools-list] [PATCH virt-viewer v3 10/10] iso-dialog: Use header bar for buttons

2016-07-29 Thread Eduardo Lima (Etrunko)
It seems to give more modern look to the dialog, but it requires Gtk+ 3.12, thus I will am keeping this commit separated. On the glade UI file, we get rid of the GtkAlignment object that was used to put some space between the tree view and dialog buttons. The "Select ISO" label is gone too.

[virt-tools-list] [PATCH virt-viewer v3 06/10] Introduce ISO List dialog

2016-07-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 106 src/remote-viewer-iso-list-dialog.h| 58

[virt-tools-list] [PATCH virt-viewer v3 04/10] ovirt-foreign-menu: Notify of new files even if nothing changed

2016-07-29 Thread Eduardo Lima (Etrunko)
When user presses the Refresh button in ISO dialog, the list is cleared, and currently, the only way it is informed of the new list is by the notify signal. The same applies when an error occurs while trying to change the current ISO. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

2016-07-29 Thread Eduardo Lima (Etrunko)
I have pushed the first two patches of the series because they were already acknowledged and were pretty much self-contained. I tried to replace GtkTreeView in favor of new GtkListBox, but after some painful work, I decided to drop it because it is not possible to reproduce the exact same

[virt-tools-list] [PATCH virt-viewer v3 09/10] iso-dialog: Implement functionality provided by oVirt foreign menu

2016-07-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c| 180 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 181 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-dialog.c

[virt-tools-list] [PATCH virt-viewer v3 05/10] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

2016-07-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 ---

[virt-tools-list] [PATCH virt-viewer v3 03/10] ovirt-foreign-menu: Remove GtkMenu related functions

2016-07-29 Thread Eduardo Lima (Etrunko)
With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer v3 08/10] remote-viewer: Make ovirt-foreign-menu a property

2016-07-29 Thread Eduardo Lima (Etrunko)
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c | 31 +++

[virt-tools-list] [PATCH virt-viewer v3 01/10] ovirt-foreign-menu: Remove timer used to refresh iso list

2016-07-29 Thread Eduardo Lima (Etrunko)
With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v3 02/10] ovirt-foreign-menu: Add accessors for current iso and iso list

2016-07-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v3 07/10] Run iso-dialog when 'Change CD' menu is activated

2016-07-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 24 2 files changed, 25 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index

Re: [virt-tools-list] [Libvirt-ci] Build failed in Jenkins: virt-manager-test ยป libvirt-centos-7 #1474

2016-07-29 Thread Cole Robinson
On 07/28/2016 05:20 AM, Daniel P. Berrange wrote: > This latest virt-manager failure looks genuine: > > On Thu, Jul 28, 2016 at 09:12:18AM +, c...@centos.org wrote: >> --- tests/cli-test-xml/compare/virt-install-kvm-f14-url.xml >> +++ Generated Output >> @@ -50,7 +50,7 @@ >> >>

[virt-tools-list] [virt-manager PATCH] snapshot: start snapshot when double-click the item of snapshot list

2016-07-29 Thread Chen Hanxiao
From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- ui/snapshots.ui | 37 +++-- virtManager/snapshots.py | 3 ++- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/ui/snapshots.ui