Final version of this series, this time I changed the order of the patches
so that the set/get ISO names port to GTask API will come first, and only
after that the dialog is introduced. Finally, the last patch will remove
the old code.
Eduardo Lima (Etrunko) (10):
remote-viewer: Extend #ifdef
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 106
src/remote-viewer-iso-list-dialog.h| 58
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 117 ++-
src/ovirt-foreign-menu.h | 10
2 files changed, 96 insertions(+),
Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
2 files changed, 47
It seems to give more modern look to the dialog, but it requires Gtk+
3.12, thus I will am keeping this commit separated.
On the glade UI file, we get rid of the GtkAlignment object that was
used to put some space between the tree view and dialog buttons. The
"Select ISO" label is gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 205 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 206 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 9 -
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 6892f0d..e244719 100644
---
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1399091
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule.
man/virt-install.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/virt-install.pod b/man/virt-install.pod
index