On 18/01/17 15:45, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote:
>> Similar to the previous commit, the ISO dialog will fetch the result
>> asynchronously, rather than relying on the "notify::files" signal from
>> OvirtForeignMenu object. It als
On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote:
> Similar to the previous commit, the ISO dialog will fetch the result
> asynchronously, rather than relying on the "notify::files" signal from
> OvirtForeignMenu object. It also enables error to be shown if anything
> goes wro
On Wed, Jan 18, 2017 at 12:16:52PM -0200, Eduardo Lima (Etrunko) wrote:
> This is done with the new ovirt_foreign_menu_set_current_iso_name_async
> function.
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 117
> ++-
> src
In this version, I address comments from Christophe in patch number 2
"Fetch ISO names using GTask API", basically adding more error handling.
In "Add accessors for current iso and iso list" I changed the return
type from char * to gchar * and changed users of the code accordingly.
Finally, I spl
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 9
Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
2 files changed, 47 insertions(+), 9 deletions(-)
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 11 +--
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 50a8ea6..e2216a2 100644
--- a/src/ovirt-foreign-menu.c
+
It seems to give more modern look to the dialog, but it requires Gtk+
3.12, thus I will am keeping this commit separated.
On the glade UI file, we get rid of the GtkAlignment object that was
used to put some space between the tree view and dialog buttons. The
"Select ISO" label is gone too.
Signe
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 204 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 205 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer-
Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 170
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 117 ++-
src/ovirt-foreign-menu.h | 10
2 files changed, 96 insertions(+), 31 deletions(-)
dif
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 37 +
1 file changed, 37 insertions(+)
diff --gi
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 121 ++
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources/ui
On 17/01/17 13:51, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau
Pushed, thanks
>
> On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote:
>> The #endif is closing a #ifdef HAVE_OVIRT block, while another one is
>> opened right next, so there is no need to have those
On 18/01/17 11:06, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 10:56:59AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 18/01/17 10:53, Christophe Fergeau wrote:
>>> On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
>>
On Wed, Jan 18, 2017 at 10:56:59AM -0200, Eduardo Lima (Etrunko) wrote:
> On 18/01/17 10:53, Christophe Fergeau wrote:
> > On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
> >> On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
> >>> On 17/01/17 14:00, Christophe Fergeau wrote:
On 18/01/17 10:53, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
>>> On 17/01/17 14:00, Christophe Fergeau wrote:
On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
>>
On Wed, Jan 18, 2017 at 10:12:20AM -0200, Eduardo Lima (Etrunko) wrote:
> On 17/01/17 14:01, Christophe Fergeau wrote:
> > On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote:
> >> Signed-off-by: Eduardo Lima (Etrunko)
> >> ---
> >> src/remote-viewer-iso-list-dialog.c|
On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
> On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
> > On 17/01/17 14:00, Christophe Fergeau wrote:
> >> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
> >>> The OvirtForeignMenu pointer is needed by th
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1375452
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule.
ui/snapshots.ui | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/snapshots.ui b/ui/snapshots.ui
index 673754b0..b6a6c2ed 100644
--- a/ui/snapshots.ui
+++ b/ui/snapshot
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1371781
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule.
virt-install | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt-install b/virt-install
index 5a4080fb..f1da1000 100755
--- a/virt-install
+++ b/virt-in
On 17/01/17 14:01, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/remote-viewer-iso-list-dialog.c| 205
>> -
>> src/resources/ui/remote-viewer-iso-list.
On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
> On 17/01/17 14:00, Christophe Fergeau wrote:
>> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
>>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
>>> we make it acessible via property to avoid interd
On 17/01/17 14:00, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
>> we make it acessible via property to avoid interdependency between
>> objects.
>>
>> Signed-off-by: Edu
Argument -c is short for --cdrom so fix the man page.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1366241
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule.
man/virt-install.pod | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/virt-install.pod b/ma
25 matches
Mail list logo
