Fixed 2 issues about interface information:
1. The mac address of bridges are shown as 'Unknown'.
2. The interface status in widget in host details dialog can't be updated
correctly.
Lin Ma (2):
interface: Return mac address correctly for bridge devices
Update interface's status in widget whi
In the host details dialog, the status of network and storage can be
refreshed automatically, but interface can't. re-open the host details
dialog can't help either. users have to do tab changing or reconnect to
hypervisor in virt-manager to reflect interface's status.
Reproduce:
1. launch virt-ma
Because a bridge xml doesn't include its own mac item, what it contains
are the slave devices's mac, It causes the get_xmlobj().macaddr can't
return the mac address of bridge.
So while showing host details, The bridge's mac address is displayed as
'Unknown' in tab 'Network Interfaces'. Say virbr0,
When the network interface is up the active XML contains only IP address
even in case that the inactive XML was configured to get the IP address
from DHCP server. To propagate this information back to UI we need to
get both XMLs to figure out current IP addresses and the configuration.
Resolves:
Acked-by: Fabiano Fidêncio
---
README | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README b/README
index e9fe5b9..ea1c633 100644
--- a/README
+++ b/README
@@ -14,12 +14,12 @@ the last release that supported GTK2.
Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to pr
To render nicely on the project git page:
https://pagure.io/virt-viewer
---
README => README.md | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
rename README => README.md (92%)
diff --git a/README b/README.md
similarity index 92%
rename from README
rename to README.md
index ea1c633
On Thu, Jan 19, 2017 at 4:29 PM, Pavel Grunt wrote:
> On Thu, 2017-01-19 at 16:12 +0100, Fabiano Fidêncio wrote:
>> On Thu, Jan 19, 2017 at 1:17 PM, Pavel Grunt
>> wrote:
>> > To render nicely on the project git page:
>> > https://pagure.io/virt-viewer
>> > ---
>> > README => README.md | 5 +---
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 9
Also moves 'Change CD' menu item from the toplevel menu to a subitem
under 'File' toplevel menu.
In order to avoid object interdependency, it is necessary to make the
ovirt foreign-menu pointer from RemoteViewer, acessible via property, so
it can be passed to the dialog as an opaque GObject.
Sign
Also, to keep consistency around the codebase, changed the return value
of ovirt_foreign_menu_get_current_iso_name() from char * to gchar *.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 11 +--
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 11 insertions(+), 2
In this version I merged the "Introduce ISO dialog" and "Implement
functionality provided by oVirt foreign menu" patches. The same was done
with "Make ovirt-foreign-menu a property" and "Run iso-dialog when
'Change CD' menu is activated".
Also addressed some comments, in special better UI behavior
It seems to give more modern look to the dialog, but it requires Gtk+
3.12, thus I will am keeping this commit separated.
On the glade UI file, we get rid of the GtkAlignment object that was
used to put some space between the tree view and dialog buttons. The
"Select ISO" label is gone too.
Signe
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 365 +
src/remote-viewer-iso-list-dialog.h| 58 +
src/resources/u
On Thu, Jan 19, 2017 at 12:44:15PM -0200, Eduardo Lima (Etrunko) wrote:
> On 19/01/17 10:48, Christophe Fergeau wrote:
> > The issues pointed out in
> > https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html
> > do not seem to have been addressed?
> >
>
> True, I did overlook
On Thu, 2017-01-19 at 16:12 +0100, Fabiano Fidêncio wrote:
> On Thu, Jan 19, 2017 at 1:17 PM, Pavel Grunt
> wrote:
> > To render nicely on the project git page:
> > https://pagure.io/virt-viewer
> > ---
> > README => README.md | 5 +
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> > re
On 18/01/17 15:45, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote:
>> Similar to the previous commit, the ISO dialog will fetch the result
>> asynchronously, rather than relying on the "notify::files" signal from
>> OvirtForeignMenu object. It als
On Thu, Jan 19, 2017 at 01:07:48PM -0200, Eduardo Lima (Etrunko) wrote:
> On 19/01/17 11:06, Christophe Fergeau wrote:
> > On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote:
> >> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
> >>
> >> Signed-off-by: Edua
On 18/01/17 14:31, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:52PM -0200, Eduardo Lima (Etrunko) wrote:
>> This is done with the new ovirt_foreign_menu_set_current_iso_name_async
>> function.
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 117
>> +
On Thu, Jan 19, 2017 at 1:17 PM, Pavel Grunt wrote:
> To render nicely on the project git page:
> https://pagure.io/virt-viewer
> ---
> README => README.md | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
> rename README => README.md (97%)
>
> diff --git a/README b/README.md
> simila
On Thu, Jan 19, 2017 at 1:17 PM, Pavel Grunt wrote:
> ---
> README | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/README b/README
> index e9fe5b9..ea1c633 100644
> --- a/README
> +++ b/README
> @@ -14,12 +14,12 @@ the last release that supported GTK2.
> Virt Vie
On 19/01/17 11:06, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote:
>> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/resources/ui/virt-viewer.ui | 19 ++
On 19/01/17 10:56, Christophe Fergeau wrote:
> Looks good, but maybe better to squash this with later commits? (see my
> comment in one of the subsequent commits)
This one could go well with patch 8/9: "Run iso-dialog when..."
>
> Christophe
>
>
> On Wed, Jan 18, 2017 at 12:16:54PM -0200, Edua
On 19/01/17 10:48, Christophe Fergeau wrote:
> The issues pointed out in
> https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html
> do not seem to have been addressed?
>
True, I did overlook that message, thanks for the reminder. I changed
the code so the spinner stops and set
On 19/01/17 10:55, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 11 +--
>> src/ovirt-foreign-menu.h | 2 ++
>> 2 files changed, 11 insertions(+), 2 deletio
On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote:
> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/resources/ui/virt-viewer.ui | 19 ++-
> src/virt-viewer-window.c| 37 +
On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 11 +--
> src/ovirt-foreign-menu.h | 2 ++
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/ovirt-foreign-menu.c b/s
Looks good, but maybe better to squash this with later commits? (see my
comment in one of the subsequent commits)
Christophe
On Wed, Jan 18, 2017 at 12:16:54PM -0200, Eduardo Lima (Etrunko) wrote:
> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
> we make it acessible via
The issues pointed out in
https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html
do not seem to have been addressed?
Did you try merging the patches from "Introduce ISO List dialog" to "Run
iso-dialog when 'Change CD' menu is activated" (without the headerbar
change)? I think t
---
README | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README b/README
index e9fe5b9..ea1c633 100644
--- a/README
+++ b/README
@@ -14,12 +14,12 @@ the last release that supported GTK2.
Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to provide a
display of the VNC
To render nicely on the project git page:
https://pagure.io/virt-viewer
---
README => README.md | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
rename README => README.md (97%)
diff --git a/README b/README.md
similarity index 97%
rename from README
rename to README.md
index ea1c633..f
On Thu, Jan 19, 2017 at 10:53:16AM +, Daniel P. Berrange wrote:
> If you have a checkout, you'll need to replace your "origin" remote.
>
> git remote rm origin
>
> then one or these as appropriate:
>
> git remote add origin ssh://g...@pagure.io/virt-viewer.git (committers)
> git remot
Fedora hosted is being shutdown real soon now. I've previously moved the
downloads over to pagure.io, and have now moved the git repository too.
If you have a checkout, you'll need to replace your "origin" remote.
git remote rm origin
then one or these as appropriate:
git remote add origin
32 matches
Mail list logo
