[virt-tools-list] [PATCH virt-viewer 2/4] Run ISO dialog when 'Change CD' menu is activated

Also moves 'Change CD' menu item from the toplevel menu to a subitem under 'File' toplevel menu. In order to avoid object interdependency, it is necessary to make the ovirt foreign-menu pointer from RemoteViewer, acessible via property, so it can be passed to the dialog as an opaque GObject.

[virt-tools-list] [PATCH virt-viewer 4/4] iso-dialog: Use header bar for buttons

It seems to give more modern look to the dialog, but it requires Gtk+ 3.12, thus I will am keeping this commit separated. On the glade UI file, we get rid of the GtkAlignment object that was used to put some space between the tree view and dialog buttons. The "Select ISO" label is gone too.

[virt-tools-list] [PATCH virt-viewer 3/4] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) ---

[virt-tools-list] [PATCH virt-viewer 1/4] Introduce ISO List dialog

The motivation for this dialog started with rhbz #1310624, where it was reported that foreign menu was causing too many debug messages to be printed to the console, because remote viewer had a timeout of 5 seconds to refresh the ISO list automatically. As a workaround, the timeout was adjusted

[virt-tools-list] [PATCH virt-viewer 0/4 v8] Replace oVirt foreign menu with dedicated dialog

In this version, I have addressed the comments on the ISO dialog code, also providing a better message for that commit. Also, put the headerbar patch at the end, as others were already acked and should be ready to merge. Eduardo Lima (Etrunko) (4): Introduce ISO List dialog Run ISO dialog

Re: [virt-tools-list] [PATCH virt-viewer 3/5] iso-dialog: Use header bar for buttons

On 20/01/17 13:26, Fabiano Fidêncio wrote: > On Fri, Jan 20, 2017 at 4:21 PM, Christophe Fergeau > wrote: >> I haven't looked at this patch at all, as I don't know what the plan is >> for virt-viewer regarding gtk+ versions. It's easy to move last in the >> series though.

Re: [virt-tools-list] [PATCH virt-viewer 2/5] Introduce ISO List dialog

On 20/01/17 13:20, Christophe Fergeau wrote: > Can you expand a bit in the commit log about what this iso dialog is, > what is your goal for introducing it, .. ? Huge commit with shortlog > does not look good ;) > Alright, it will be done for the next version. > On Thu, Jan 19, 2017 at

Re: [virt-tools-list] [PATCH virt-viewer 1/5] ovirt-foreign-menu: Add accessors for current iso and iso list

On 20/01/17 13:16, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau Pushed, thanks. > > On Thu, Jan 19, 2017 at 01:42:10PM -0200, Eduardo Lima (Etrunko) wrote: >> Also, to keep consistency around the codebase, changed the return value >> of