On 24/01/17 09:11, Christophe Fergeau wrote:
> On Mon, Jan 23, 2017 at 05:28:14PM -0200, Eduardo Lima (Etrunko) wrote:
>> Also moves 'Change CD' menu item from the toplevel menu to a subitem
>> under 'File' toplevel menu.
>>
>> In order to avoid object interdependency, it is necessary to make the
>
Patch looks good to me, regarding the UI implications of the change to
header bar, I don't know, I haven't followed that up closely.
Christophe
On Mon, Jan 23, 2017 at 05:28:16PM -0200, Eduardo Lima (Etrunko) wrote:
> It seems to give more modern look to the dialog, but it requires Gtk+
> 3.12, t
On Mon, Jan 23, 2017 at 05:28:15PM -0200, Eduardo Lima (Etrunko) wrote:
> With this commit, we finish cleaning up ovirt foreign menu code, which
> only deals with data, leaving the UI bits to be handled properly in the
> new ISO list dialog.
>
> This patch also updates remote-viewer to reflect the
On Mon, Jan 23, 2017 at 05:28:14PM -0200, Eduardo Lima (Etrunko) wrote:
> Also moves 'Change CD' menu item from the toplevel menu to a subitem
> under 'File' toplevel menu.
>
> In order to avoid object interdependency, it is necessary to make the
> ovirt foreign-menu pointer from RemoteViewer, ace
Acked-by: Christophe Fergeau
(you could adjust the (C) to 2017 in the files you changed)
On Mon, Jan 23, 2017 at 05:28:13PM -0200, Eduardo Lima (Etrunko) wrote:
> The motivation for this dialog started with rhbz #1310624, where it was
> reported that foreign menu was causing too many debug mess
On Mon, Jan 23, 2017 at 05:01:34PM -0200, Eduardo Lima (Etrunko) wrote:
> >> +
> >> +static void
> >> +fetch_iso_names_cb(OvirtForeignMenu *foreign_menu,
> >> + GAsyncResult *result,
> >> + RemoteViewerISOListDialog *self)
> >> +{
> >> +RemoteViewerISOListDia
