Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

On Mon, 2017-02-06 at 18:04 +0100, Christophe Fergeau wrote: > On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > > Hey, > > > > > > > > On Thu, Jan 26, 2017 at

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > Hey, > > > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) > > > wrote: > > > > We must

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > On 03/02/17 14:34, Christophe Fergeau wrote: > > Hey, > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) > > wrote: > > > We must take into account that users can close the dialog at > > > anytime, > > > even

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

Acked-by: Eduardo Lima (Etrunko) On 06/02/17 10:02, Pavel Grunt wrote: > Fixes -Werror=format-security used when creating the rpm > --- > see: > https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz > --- >

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

Fixes -Werror=format-security used when creating the rpm --- see: https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz --- src/remote-viewer-iso-list-dialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [virt-tools-list] [PATCH virt-viewer] Update for README.md

On Mon, 2017-02-06 at 12:18 +0100, Christophe Fergeau wrote: > On Mon, Feb 06, 2017 at 12:06:25PM +0100, Pavel Grunt wrote: > > It is needed to use the 'foreign' init option otherwise autotools > > requires README > > --- > > I am sorry for breaking the build again. > > An alternative for this

Re: [virt-tools-list] [PATCH virt-viewer] session-spice: Pass hostname to authentication dialog

On Fri, 2017-02-03 at 16:11 -0200, Eduardo Lima (Etrunko) wrote: > With this patch the dialog now shows the host we are trying to > connect to. I would mention that we use the "host" property of SpiceSession > > Signed-off-by: Eduardo Lima (Etrunko) --- >  

Re: [virt-tools-list] [PATCH virt-viewer] Update for README.md

On Mon, Feb 06, 2017 at 12:06:25PM +0100, Pavel Grunt wrote: > It is needed to use the 'foreign' init option otherwise autotools > requires README > --- > I am sorry for breaking the build again. > An alternative for this patch would be to generate README from README.md > or reverting the previous

[virt-tools-list] [PATCH virt-viewer] Update for README.md

It is needed to use the 'foreign' init option otherwise autotools requires README --- I am sorry for breaking the build again. An alternative for this patch would be to generate README from README.md or reverting the previous commit --- configure.ac| 2 +- virt-viewer.spec.in | 2 +- 2

Re: [virt-tools-list] [virt-manager PATCH] virtManager/addhardware: get supported disk bus types from libvirt

On Sun, Feb 05, 2017 at 04:51:57PM -0500, Cole Robinson wrote: > On 01/20/2017 10:21 AM, Pavel Hrdina wrote: > > Libvirt provides domain capabilities where supported disk bus types are > > listed. Virt-manager should try to get those bus types. The old code > > remains as fallback if domain

Re: [virt-tools-list] [virt-manager PATCH] virtManager/interface: detect whether IP address comes from DHCP server

On Sun, Feb 05, 2017 at 04:27:21PM -0500, Cole Robinson wrote: > On 01/19/2017 12:07 PM, Pavel Hrdina wrote: > > When the network interface is up the active XML contains only IP address > > even in case that the inactive XML was configured to get the IP address > > from DHCP server. To propagate