Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

2017-02-10 Thread Pavel Grunt
On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote: > I tend to agree. I don’t see how any legitimate GError * (from > g_error_new or the like) would have a NULL message. So this is > really defensive coding. > nothing prevents calling g_error_new with a NULL message :) I know it is n

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

2017-02-10 Thread Christophe Fergeau
On Fri, Feb 10, 2017 at 03:50:36PM +0100, Pavel Grunt wrote: > On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote: > > I tend to agree. I don’t see how any legitimate GError * (from > > g_error_new or the like) would have a NULL message. So this is > > really defensive coding. > > > n

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

2017-02-10 Thread Christophe de Dinechin
> On 10 Feb 2017, at 15:50, Pavel Grunt wrote: > > On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote: >> I tend to agree. I don’t see how any legitimate GError * (from >> g_error_new or the like) would have a NULL message. So this is >> really defensive coding. >> > nothing preven

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

2017-02-10 Thread Jonathon Jongsma
On Fri, 2017-02-10 at 19:18 +0100, Christophe de Dinechin wrote: > > On 10 Feb 2017, at 15:50, Pavel Grunt wrote: > > > > On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote: > > > I tend to agree. I don’t see how any legitimate GError * (from > > > g_error_new or the like) would have

Re: [virt-tools-list] Problem accessing USB devices under a VM running Windows 10

2017-02-10 Thread Jeffery Small
On Tue, Feb 07, 2017 at 16:54:34, Christophe Fergeau wrote: >On Mon, Feb 06, 2017 at 11:19:08AM -0800, Jeffery Small wrote: >> >> I'm on an Xubuntu 16.10 system running the latest version of QEMU-KVM >> (1.2.6.1). I have a VM running Windows 10, which is launched from >> virt-manager. >> >> Q

Re: [virt-tools-list] Problem accessing USB devices under a VM running Windows 10

2017-02-10 Thread Jeffery Small
I'm following up to my last post of just a few minutes ago. I discovered the nature of the problem: user confusion. After reading many articles on the subject, I thought that using the virt-manger option to "Add Hardware" was the trick to getting USB devices attached to the VM OS. After posting,