Re: [virt-tools-list] [virt-manager PATCH v2] domain: add support to rename domain with nvram vars file

2017-03-07 Thread Pavel Hrdina
On Tue, Mar 07, 2017 at 11:20:50AM -0500, Cole Robinson wrote: > On 03/07/2017 07:33 AM, Pavel Hrdina wrote: > > Libvirt storage API doesn't support renaming storage volumes so > > we need to copy the nvram file and remove the old one. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [virt-tools-list] [virt-manager PATCH v2] domain: add support to rename domain with nvram vars file

2017-03-07 Thread Cole Robinson
On 03/07/2017 07:33 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina > --- > > new in v2: > - prop

Re: [virt-tools-list] [PATCH 1/2] Add missing ifdef HAVE_OVIRT (virt-viewer-window.c)

2017-03-07 Thread Eduardo Lima (Etrunko)
Hi Uri, Victor has already sent and merged patches fixing those warnings. Can you try with latest upstream if you still have warnings? By the way, I like some parts of your patches a bit better than his, but as the patches are already in, I am not sure if it is worth to change the code once again.

[virt-tools-list] [virt-manager PATCH v2] domain: add support to rename domain with nvram vars file

2017-03-07 Thread Pavel Hrdina
Libvirt storage API doesn't support renaming storage volumes so we need to copy the nvram file and remove the old one. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 Signed-off-by: Pavel Hrdina --- new in v2: - properly implement the rename process - introduced new method has_n

[virt-tools-list] SECURITY: Various security issues in icoutils 'wrestool', used by libguestfs

2017-03-07 Thread Richard W.M. Jones
Sorry for missing the importance of these earlier. These vulnerabilities were first disclosed this January. There are seven vulnerabilities reported in the icoutils package, in the 'wrestool' program. Unfortunately because libguestfs downloads untrusted guest content and processes it with 'wrest

[virt-tools-list] [PATCH 2/2] Fix compiler warnings ifndef HAVE_OVIRT (remote-viewer.c)

2017-03-07 Thread Uri Lublin
Currently the compilers complains when HAVE_OVIRT is not defined: src/remote-viewer.c: In function 'remote_viewer_get_property': src/remote-viewer.c:227:26: warning: unused variable 'priv' [-Wunused-variable] RemoteViewerPrivate *priv = self->priv; ^~~~ src/remote-vie

[virt-tools-list] [PATCH 1/2] Add missing ifdef HAVE_OVIRT (virt-viewer-window.c)

2017-03-07 Thread Uri Lublin
Currently the build fails when configured without-ovirt (snipped a bit): make[3]: Entering directory 'virt-viewer/src' CCLD remote-viewer ./.libs/libvirt-viewer.a(libvirt_viewer_la-virt-viewer-window.o): In function `virt_viewer_window_menu_change_cd_activate': src/virt-viewer-window.c:10

Re: [virt-tools-list] [virt-manager PATCH 1/2] domain: add support to rename domain with nvram vars file

2017-03-07 Thread Pavel Hrdina
On Mon, Mar 06, 2017 at 06:48:34PM -0500, Cole Robinson wrote: > On 03/06/2017 03:43 AM, Pavel Hrdina wrote: > > Libvirt storage API doesn't support renaming storage volumes so > > we need to copy the nvram file and remove the old one. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=