[virt-tools-list] [PATCH virt-viewer] Avoid warning when loading initial monitor mapping

2017-03-29 Thread Jonathon Jongsma
When started in fullscreen mode with a monitor-mapping configuration option, we are getting the following warnings on the terminal: (process:27428): Gdk-CRITICAL **: gdk_screen_get_n_monitors: assertion 'GDK_IS_SCREEN (screen)' failed ** (process:27428): WARNING **: Invalid

Re: [virt-tools-list] [PATCH virt-viewer] Remove unused virt_viewer_app_set_zoom_level

2017-03-29 Thread Eduardo Lima (Etrunko)
On 29/03/17 07:36, Pavel Grunt wrote: > --- > src/virt-viewer-app.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/virt-viewer-app.h b/src/virt-viewer-app.h > index 8381631..16b1c8c 100644 > --- a/src/virt-viewer-app.h > +++ b/src/virt-viewer-app.h > @@ -68,7 +68,6 @@ void

Re: [virt-tools-list] [PATCH virt-viewer] vnc: Set display as enabled on init

2017-03-29 Thread Eduardo Lima (Etrunko)
On 29/03/17 07:36, Pavel Grunt wrote: > It will enable some functionality, like zoom. > You could maybe elaborate a bit better, as you are also setting enabled to FALSE it when the session gets disconnected. Acked-by: Eduardo Lima (Etrunko) > Regression since

Re: [virt-tools-list] [virt-manager PATCH] virt-xml: add qemu commandline passthrough example

2017-03-29 Thread Chen Hanxiao
At 2017-03-29 19:33:11, "Cole Robinson" wrote: >On 03/28/2017 06:42 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> We forgot to mention --qemu-commandline in virt-xml.pod. >> Also added an example copied from Cole's blog. >> >> Signed-off-by:

Re: [virt-tools-list] [virt-manager PATCH] virt-xml: add qemu commandline passthrough example

2017-03-29 Thread Cole Robinson
On 03/28/2017 06:42 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > We forgot to mention --qemu-commandline in virt-xml.pod. > Also added an example copied from Cole's blog. > > Signed-off-by: Chen Hanxiao > --- > man/virt-xml.pod | 6 ++ > 1

[virt-tools-list] [PATCH virt-viewer] Remove unused virt_viewer_app_set_zoom_level

2017-03-29 Thread Pavel Grunt
--- src/virt-viewer-app.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/virt-viewer-app.h b/src/virt-viewer-app.h index 8381631..16b1c8c 100644 --- a/src/virt-viewer-app.h +++ b/src/virt-viewer-app.h @@ -68,7 +68,6 @@ void virt_viewer_app_free_connect_info(VirtViewerApp *self); gboolean

Re: [virt-tools-list] [PATCH virt-viewer] Remove G_VALUE_INIT definition

2017-03-29 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Mar 29, 2017 at 11:14:42AM +0200, Pavel Grunt wrote: > Available in GLib since the version 2.30 I would have explicitly mentioned "and virt-viewer requires glib 2.38" Christophe signature.asc Description: PGP signature

[virt-tools-list] [PATCH virt-viewer] Remove G_VALUE_INIT definition

2017-03-29 Thread Pavel Grunt
Available in GLib since the version 2.30 --- src/remote-viewer.c | 4 1 file changed, 4 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 451fb1d..2db76bc 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c @@ -48,10 +48,6 @@ #include "remote-viewer.h"

Re: [virt-tools-list] [virt-viewer] build-sys: Make spice-controller optional

2017-03-29 Thread Pavel Grunt
On Fri, 2017-03-24 at 14:51 +0100, Christophe Fergeau wrote: > The spice-controller integration code is only needed when a browser > plugin is in use. This has been deprecated in favour of .vv files > for > several years now. This commit makes this code optional, if > spice-controller.pc cannot be