On 02/06/17 09:57, Pavel Grunt wrote:
> On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote:
>> From: Victor Toso
>>
>> Mainly an issue for kiosk mode.
>>
>> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
>> Signed-off-by: Victor Toso
>> ---
>> src/virt-viewer-session-spice.c | 4
On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Mainly an issue for kiosk mode.
>
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
> Signed-off-by: Victor Toso
> ---
> src/virt-viewer-session-spice.c | 4
> 1 file changed, 4 insertions(+)
>
> d
Hi,
Self nack those two patches. Following proposal is enough and much
simpler:
https://www.redhat.com/archives/virt-tools-list/2017-June/msg00014.html
On Fri, Jun 02, 2017 at 12:40:34PM +0200, Victor Toso wrote:
> From: Victor Toso
>
> In kiosk mode, we will see the error dialog on cancel/clos
From: Victor Toso
Mainly an issue for kiosk mode.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Victor Toso
---
src/virt-viewer-session-spice.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.
From: Victor Toso
For whom is trying to collect the credentials, it might be necessary
to know if a failure is due bad user input of credentials or if the
user has cancelled or closed the dialog.
Prior to this patch anything but GTK_RESPONSE_OK was considered a
failure without any extra informat
On Fri, 2017-06-02 at 12:40 +0200, Victor Toso wrote:
> From: Victor Toso
>
> Who is trying to collect the credentials might need to know if a
> given
> failure is due bad user input of credentionals or if the user has
> cancel/closed the dialog (which is also consider failure prior this
> patch)
From: Victor Toso
In kiosk mode, we will see the error dialog on cancel/close which is not
expected as we are not really trying to connect with given user/pass.
Cheers,
toso
Victor Toso (2):
Return full response from virt_viewer_auth_collect_credentials()
spice: do not show error on can
From: Victor Toso
Mainly an issue for kiosk mode.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Victor Toso
---
src/virt-viewer-session-spice.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spic
From: Victor Toso
Who is trying to collect the credentials might need to know if a given
failure is due bad user input of credentionals or if the user has
cancel/closed the dialog (which is also consider failure prior this
patch)
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signe
