[virt-tools-list] [virt-viewer v1] vnc: only emit 'session-disconnect' if it was connected

2017-06-06 Thread Victor Toso
From: Victor Toso When user cancels an authentication dialog, virt-viewer-session-vnc.c will correctly emit "session-cancelled" and after that it will emit "session-disconnected" which is not correct as the session's connection was not establish at that moment. We can track

Re: [virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

2017-06-06 Thread Victor Toso
On Fri, Jun 02, 2017 at 11:59:04AM -0300, Eduardo Lima (Etrunko) wrote: > On 02/06/17 09:57, Pavel Grunt wrote: > > On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote: > >> From: Victor Toso > >> > >> Mainly an issue for kiosk mode. > >> > >> Related:

Re: [virt-tools-list] [virt-viewer v2] vnc: do not show error on cancel/close of auth dialog

2017-06-06 Thread Eduardo Lima (Etrunko)
On 06/06/17 09:12, Victor Toso wrote: > From: Victor Toso > > Mainly a kiosk mode, similar to the spice fix in 6480e52f62b. > > This patch saves the cancel/close state of auth dialog from > virt_viewer_auth_collect_credentials() in order to avoid an error > dialog to pop up

[virt-tools-list] [virt-viewer v2] vnc: do not show error on cancel/close of auth dialog

2017-06-06 Thread Victor Toso
From: Victor Toso Mainly a kiosk mode, similar to the spice fix in 6480e52f62b. This patch saves the cancel/close state of auth dialog from virt_viewer_auth_collect_credentials() in order to avoid an error dialog to pop up to user in kiosk mode. This happens due the fact

Re: [virt-tools-list] [virt-viewer v1] app: Only disconnect if it was connected previously

2017-06-06 Thread Victor Toso
Hi, On Tue, Jun 06, 2017 at 11:03:11AM +0200, Victor Toso wrote: > From: Victor Toso > > When user cancels an authentication dialog, virt-viewer-session-vnc.c > will correctly emit "session-cancelled" and after that it will emit > "session-disconnected" which is not correct

[virt-tools-list] [virt-viewer v1] app: Only disconnect if it was connected previously

2017-06-06 Thread Victor Toso
From: Victor Toso When user cancels an authentication dialog, virt-viewer-session-vnc.c will correctly emit "session-cancelled" and after that it will emit "session-disconnected" which is not correct as the connect was not establish at that moment. The reason for emitting