[virt-tools-list] Changing default vgamem='16384' for QXL device

2017-07-24 Thread Eric Abreu
Hello folks, I would like to change the RAM for the QXL Video device from default 16 MB to 64 MB or more whether is this possible. I do not have the option to change it, I tried to delete the device and add a new one and neither it let me change it. I also tried to edit the .xml under

Re: [virt-tools-list] [virt-manager] [PATCH 4/5] tests: Upgrade pep8 to pycodestyle

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:26 +0100, Radostin Stoyanov wrote: > The PEP8 [1] project has been renamed to pycodestyle [2]. > > [1] https://github.com/codeclimate/pep8 > [2] https://github.com/pycqa/pycodestyle > --- >  HACKING.md|  2 +- >  setup.py  |  8 >  

Re: [virt-tools-list] [virt-manager] [PATCH 3/5] Remove unintentionally added '+'

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:26 +0100, Radostin Stoyanov wrote: > --- >  virtManager/create.py | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtManager/create.py b/virtManager/create.py > index cec44a6..10948cd 100644 > --- a/virtManager/create.py > +++

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 11/11] tests: Add unit tests for the "utils" module

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  tests/test_utils.py | 702 > >  1 file changed, 702 insertions(+) >  create mode 100644 tests/test_utils.py > > diff --git a/tests/test_utils.py b/tests/test_utils.py > new

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 10/11] tests: Add unit tests for "progress" module

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  tests/test_progress.py | 115 > + >  1 file changed, 115 insertions(+) >  create mode 100644 tests/test_progress.py > > diff --git a/tests/test_progress.py b/tests/test_progress.py

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 09/11] tests: Add unit tests for FileSource

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  tests/test_file_source.py | 174 > ++ >  1 file changed, 174 insertions(+) >  create mode 100644 tests/test_file_source.py > > diff --git a/tests/test_file_source.py

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 08/11] tests: Add unit tests for DockerSource

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  tests/test_docker_source.py | 605 > >  1 file changed, 605 insertions(+) >  create mode 100644 tests/test_docker_source.py > > diff --git a/tests/test_docker_source.py

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 07/11] tests: Add unit tests for 'virt_bootstrap' module

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  tests/__init__.py|  41 >  tests/test_virt_bootstrap.py | 467 > +++ >  2 files changed, 508 insertions(+) >  create mode 100644 tests/test_virt_bootstrap.py > > diff --git

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 06/11] Use 'tox' to test agains multiple Python versions

2017-07-24 Thread Cedric Bosdonnat
I forgot: * Typo in the commit message: missing 't' in against On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > 'Tox' is tool which will check if the package installs correctly and all 'Tox is a tool that' > unit tests pass with different Python versions. > --- >  tox.ini | 23

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 06/11] Use 'tox' to test agains multiple Python versions

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > 'Tox' is tool which will check if the package installs correctly and all > unit tests pass with different Python versions. > --- >  tox.ini | 23 +++ >  1 file changed, 23 insertions(+) >  create mode 100644 tox.ini >

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Pavel Grunt
On Mon, 2017-07-24 at 05:47 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > > > otherwise msi generation fails with: > > Couldn't find file > >

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 04/11] DockerSource: Show correct err msg on skopeo fail

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > The first argument of CalledProcessError() must be the returncode not > the command. > --- >  src/virtBootstrap/sources.py | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/virtBootstrap/sources.py

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 03/11] DockerSource: Fix formula of download progress

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > When downloading image with multiple layers, the download progress > value of every following layer should not start from 0. > > If we have 10 layers, downloading each of them should increase the > total download progress by 10%. > >

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 02/11] tests: Add test suite

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > --- >  README.md | 12 >  setup.py  |  5 - >  tests/__init__.py |  0 >  3 files changed, 16 insertions(+), 1 deletion(-) >  create mode 100644 tests/__init__.py > > diff --git a/README.md b/README.md >

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 01/11] Add remapping ownership of files in rootfs

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > When Libvirt creates LXC container with enabled user namespace the > ownership of files in the container should be mapped to the specified > target UID/GID. > > The implementation of the mapping is inspired by the tool uidmapshift: >

Re: [virt-tools-list] [virt-bootstrap] [PATCH v5 05/11] Add support for setting root passowrd in qcow2

2017-07-24 Thread Cedric Bosdonnat
On Mon, 2017-07-24 at 09:14 +0100, Radostin Stoyanov wrote: > For containers bootstrapped in qcow2 format use the tool 'virt-edit' > to insert the hashed root password in the shadow file of the last layer > --- >  src/virtBootstrap/utils.py  | 26 +- >  

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Marc-André Lureau
Hi - Original Message - > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > otherwise msi generation fails with: > Couldn't find file > $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/mingw/bin/debug-helper.exe > --- > data/Makefile.am | 2 +- > 1 file

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Pavel Grunt
On Mon, 2017-07-24 at 10:17 +0200, Christophe Fergeau wrote: > On Mon, Jul 24, 2017 at 10:10:02AM +0200, Pavel Grunt wrote: > > Hi, > > > > On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote: > > > Hey, > > > > > > On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > > > >

[virt-tools-list] [virt-manager] [PATCH 5/5] pycodestyle: Do not use bare 'except:'

2017-07-24 Thread Radostin Stoyanov
A bare 'except:' catches all exceptions [1], including SystemExit, KeyboardInterrupt, and GeneratorExit (which is not an error and should not normally be caught by user code). In situations where you need to catch all “normal” errors, you can catch the base class for all normal exceptions,

[virt-tools-list] [virt-manager] [PATCH 2/5] create: Auto-generate fs path if not provided

2017-07-24 Thread Radostin Stoyanov
Use default place to store file systems of bootstraped containers. If the current user has effective UID 0 use: /var/lib/libvirt/filesystems/ otherwise use: ~/.local/share/libvirt/filesystems/ --- virtManager/create.py | 11 +++ 1 file changed, 11 insertions(+) diff --git

[virt-tools-list] [virt-manager] [PATCH 3/5] Remove unintentionally added '+'

2017-07-24 Thread Radostin Stoyanov
--- virtManager/create.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/create.py b/virtManager/create.py index cec44a6..10948cd 100644 --- a/virtManager/create.py +++ b/virtManager/create.py @@ -2617,7 +2617,7 @@ class vmmCreate(vmmGObjectUI): def

[virt-tools-list] [virt-manager] [PATCH 1/5] create: Stop if virt-bootstrap has failed

2017-07-24 Thread Radostin Stoyanov
Prevent container creation if virt-bootstrap has not finished successfully. --- virtManager/asyncjob.py | 3 +++ virtManager/create.py | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py index 3c96fdf..35347ca 100644 ---

[virt-tools-list] [virt-manager] [PATCH 0/5] Improvements

2017-07-24 Thread Radostin Stoyanov
Radostin Stoyanov (5): create: Stop if virt-bootstrap has failed create: Auto-generate fs path if not provided Remove unintentionally added '+' tests: Upgrade pep8 to pycodestyle pycodestyle: Do not use bare 'except:' HACKING.md | 2 +- setup.py |

[virt-tools-list] [virt-manager] [PATCH 4/5] tests: Upgrade pep8 to pycodestyle

2017-07-24 Thread Radostin Stoyanov
The PEP8 [1] project has been renamed to pycodestyle [2]. [1] https://github.com/codeclimate/pep8 [2] https://github.com/pycqa/pycodestyle --- HACKING.md| 2 +- setup.py | 8 tests/pep8.cfg| 15 --- tests/pycodestyle.cfg | 33

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Christophe Fergeau
On Mon, Jul 24, 2017 at 10:10:02AM +0200, Pavel Grunt wrote: > Hi, > > On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote: > > Hey, > > > > On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > > > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > > > >

[virt-tools-list] [virt-bootstrap] [PATCH v5 00/11] Unit tests

2017-07-24 Thread Radostin Stoyanov
Hi all, This patch series contains a the revised version of the last patch series along with a four new patches. The tests are revised to match the changes. Radostin Stoyanov (11): Add remapping ownership of files in rootfs tests: Add test suite DockerSource: Fix formula of download

[virt-tools-list] [virt-bootstrap] [PATCH v5 11/11] tests: Add unit tests for the "utils" module

2017-07-24 Thread Radostin Stoyanov
--- tests/test_utils.py | 702 1 file changed, 702 insertions(+) create mode 100644 tests/test_utils.py diff --git a/tests/test_utils.py b/tests/test_utils.py new file mode 100644 index 000..f1b31bd --- /dev/null +++ b/tests/test_utils.py

[virt-tools-list] [virt-bootstrap] [PATCH v5 09/11] tests: Add unit tests for FileSource

2017-07-24 Thread Radostin Stoyanov
--- tests/test_file_source.py | 174 ++ 1 file changed, 174 insertions(+) create mode 100644 tests/test_file_source.py diff --git a/tests/test_file_source.py b/tests/test_file_source.py new file mode 100644 index 000..6509078 --- /dev/null +++

[virt-tools-list] [virt-bootstrap] [PATCH v5 05/11] Add support for setting root passowrd in qcow2

2017-07-24 Thread Radostin Stoyanov
For containers bootstrapped in qcow2 format use the tool 'virt-edit' to insert the hashed root password in the shadow file of the last layer --- src/virtBootstrap/utils.py | 26 +- src/virtBootstrap/virt_bootstrap.py | 15 +++ 2 files changed, 32

[virt-tools-list] [virt-bootstrap] [PATCH v5 01/11] Add remapping ownership of files in rootfs

2017-07-24 Thread Radostin Stoyanov
When Libvirt creates LXC container with enabled user namespace the ownership of files in the container should be mapped to the specified target UID/GID. The implementation of the mapping is inspired by the tool uidmapshift:

[virt-tools-list] [virt-bootstrap] [PATCH v5 08/11] tests: Add unit tests for DockerSource

2017-07-24 Thread Radostin Stoyanov
--- tests/test_docker_source.py | 605 1 file changed, 605 insertions(+) create mode 100644 tests/test_docker_source.py diff --git a/tests/test_docker_source.py b/tests/test_docker_source.py new file mode 100644 index 000..7db0d87 --- /dev/null

[virt-tools-list] [virt-bootstrap] [PATCH v5 04/11] DockerSource: Show correct err msg on skopeo fail

2017-07-24 Thread Radostin Stoyanov
The first argument of CalledProcessError() must be the returncode not the command. --- src/virtBootstrap/sources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virtBootstrap/sources.py b/src/virtBootstrap/sources.py index 898993d..c44b2ed 100644 ---

[virt-tools-list] [virt-bootstrap] [PATCH v5 07/11] tests: Add unit tests for 'virt_bootstrap' module

2017-07-24 Thread Radostin Stoyanov
--- tests/__init__.py| 41 tests/test_virt_bootstrap.py | 467 +++ 2 files changed, 508 insertions(+) create mode 100644 tests/test_virt_bootstrap.py diff --git a/tests/__init__.py b/tests/__init__.py index e69de29..5e479c0 100644 ---

[virt-tools-list] [virt-bootstrap] [PATCH v5 10/11] tests: Add unit tests for "progress" module

2017-07-24 Thread Radostin Stoyanov
--- tests/test_progress.py | 115 + 1 file changed, 115 insertions(+) create mode 100644 tests/test_progress.py diff --git a/tests/test_progress.py b/tests/test_progress.py new file mode 100644 index 000..8c1d078 --- /dev/null +++

[virt-tools-list] [virt-bootstrap] [PATCH v5 03/11] DockerSource: Fix formula of download progress

2017-07-24 Thread Radostin Stoyanov
When downloading image with multiple layers, the download progress value of every following layer should not start from 0. If we have 10 layers, downloading each of them should increase the total download progress by 10%. Assuming that the download and extraction are 50/50 of the total work.

[virt-tools-list] [virt-bootstrap] [PATCH v5 06/11] Use 'tox' to test agains multiple Python versions

2017-07-24 Thread Radostin Stoyanov
'Tox' is tool which will check if the package installs correctly and all unit tests pass with different Python versions. --- tox.ini | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 tox.ini diff --git a/tox.ini b/tox.ini new file mode 100644 index

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Pavel Grunt
Hi, On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote: > Hey, > > On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > > > otherwise msi generation fails with: > > Couldn't find file

[virt-tools-list] [RFC] VM configuration templates

2017-07-24 Thread Cedric Bosdonnat
Hi all, While working on a special VM setup here, I was wondering about introducing some configuration templates in virt-manager. We could have a drop down list somewhere in the UI to select a template. Here is a list of possible templates we could propose: * 'Full host VM' expose as

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Christophe Fergeau
Hey, On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > otherwise msi generation fails with: > Couldn't find file > $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/mingw/bin/debug-helper.exe Looks like