Libvirt only supports built-in IDE controller so far, There is no
any case that needs us manually add an IDE controller, So remove
it from the controller list.
Signed-off-by: Lin Ma
---
virtManager/addhardware.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/virtManager/a
On 11/08/2017 01:23 AM, Andrew Wong wrote:
> ---
> virtinst/urlfetcher.py | 38 --
> 1 file changed, 32 insertions(+), 6 deletions(-)
>
Nice work! Seems to work in my minimal testing. Some comments below.
> diff --git a/virtinst/urlfetcher.py b/virtinst/urlfe
On 11/08/2017 01:23 AM, Andrew Wong wrote:
> _grabber() is used for both binary and text files.
> ---
> virtinst/urlfetcher.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py
> index 5dae424c..1288668a 100644
> --- a/virtins
On 11/06/2017 07:52 AM, Lin Ma wrote:
> When we change disk bus to 'scsi' or add scsi disks, virt-manager relies
> on libvirt's rules to create addresses. Sometimes it works, sometimes not,
> Espectially in multiple scsi controllers case, we can not exactly control
> which virtual disks attach to w
On 11/06/2017 07:52 AM, Lin Ma wrote:
> Because sata, usb and scsi use same device prefix: sd*, They will be
> included into occupied list while we add virtio-scsi disks, This is
> wrong and may cause adding additional virtio-scsi controller.
>
> How to reproduce:
> 1. fresh install a qemu guest.
On 11/06/2017 07:52 AM, Lin Ma wrote:
> when we add virtual disks on virtio-scsi bus, Because the redundant disk
> objects are passed to used_disks, It causes that virt-manager allows only
> 4 sd* devices per controller. virt-manager automatically adds more virtio
> scsi controllers for us if we ad
On Wed, Nov 22, 2017 at 04:21:49PM -0200, Eduardo Lima (Etrunko) wrote:
> - Use macros for paths instead of absolute paths.
> - Fix scope of enable_autotools macro to avoid warning during build.
> warning: Macro %enable_autotools defined but not used within scope
>
> Signed-off-by: Eduardo Lima
On 11/22/2017 07:40 AM, Lin Ma wrote:
>
>
Cole Robinson 2017/11/22 星期三 上午 6:28 >>>
>>On 11/06/2017 07:52 AM, Lin Ma wrote:
>>> It helps users to recognize controllers <-> disks mapping relationship.
>>>
>>> Signed-off-by: Lin Ma
>>> ---
>>> ui/details.ui | 48
> ++
- Use macros for paths instead of absolute paths.
- Fix scope of enable_autotools macro to avoid warning during build.
warning: Macro %enable_autotools defined but not used within scope
Signed-off-by: Eduardo Lima (Etrunko)
---
virt-viewer.spec.in | 23 ---
1 file changed,
Acked-by: Christophe Fergeau
On Wed, Nov 22, 2017 at 03:09:32PM -0200, Eduardo Lima (Etrunko) wrote:
> Similar to last commit, as noticed by reporter in bugzilla:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1477966
>
> Man page should reference spice-client, not spice-gtk.
>
> Signed-off-
On Wed, Nov 22, 2017 at 03:09:32PM -0200, Eduardo Lima (Etrunko) wrote:
> Similar to last commit, as noticed by reporter in bugzilla:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1477966
>
> Man page should reference spice-client, not spice-gtk.
>
> Signed-off-by: Eduardo Lima (Etrunko)
> --
Similar to last commit, as noticed by reporter in bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1477966
Man page should reference spice-client, not spice-gtk.
Signed-off-by: Eduardo Lima (Etrunko)
---
man/remote-viewer.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
On 11/21/2017 10:44 PM, Lin Ma wrote:
>
>
Cole Robinson 2017/11/22 星期三 上午 6:16 >>>
>>On 11/07/2017 05:34 AM, Lin Ma wrote:
>>> Signed-off-by: Lin Ma
>>> ---
>>> virtManager/addhardware.py | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/virtManager/addhardware.py b/virtMa
>>> Cole Robinson 2017/11/22 星期三 上午 6:28 >>>
>On 11/06/2017 07:52 AM, Lin Ma wrote:
>> It helps users to recognize controllers <-> disks mapping relationship.
>>
>> Signed-off-by: Lin Ma
>> ---
>> ui/details.ui | 48
>> virtManager/det
14 matches
Mail list logo
