Re: [virt-tools-list] [virt-manager] [PATCH 2/4] Output the qemu guest agent lifecycle events in debug mode

2018-06-29 Thread Lin Ma
On 06/27/2018 05:39 AM, Cole Robinson wrote: On 06/24/2018 11:46 PM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/connection.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/virtManager/connection.py b/virtManager/connection.py index 76e78c49..0b83bccf 100644 --- a

Re: [virt-tools-list] [virt-manager] [PATCH 3/4] ui: details: Add ui for showing the state of channel in next patch

2018-06-29 Thread Lin Ma
On 06/27/2018 05:38 AM, Cole Robinson wrote: On 06/24/2018 11:46 PM, Lin Ma wrote: Signed-off-by: Lin Ma --- ui/details.ui | 25 + virtManager/details.py | 1 + 2 files changed, 26 insertions(+) diff --git a/ui/details.ui b/ui/details.ui index 3018354b.

Re: [virt-tools-list] [virt-manager] [PATCH 1/4] libvirtenummap: Map state vals of agent event to libvirt enum names

2018-06-29 Thread Lin Ma
On 06/27/2018 05:37 AM, Cole Robinson wrote: On 06/24/2018 11:46 PM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/libvirtenummap.py | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/virtManager/libvirtenummap.py b/virtManager/libvirtenummap.py index

Re: [virt-tools-list] [virt-viewer v2] ovirt: Improve handling of g_strv_contains()

2018-06-29 Thread Eduardo Lima (Etrunko)
Acked-by: Eduardo Lima (Etrunko) On 29/06/18 05:13, Christophe Fergeau wrote: > The ovirt code uses g_strv_contains() with fallback code in > glib-compat.h when we are using a glib version where it's not available. > However, when we use a glib version where g_strv_contains is available, > we g

[virt-tools-list] [virt-viewer v2] ovirt: Improve handling of g_strv_contains()

2018-06-29 Thread Christophe Fergeau
The ovirt code uses g_strv_contains() with fallback code in glib-compat.h when we are using a glib version where it's not available. However, when we use a glib version where g_strv_contains is available, we get a compilation warning since we are compiling GLIB_VERSION_MAX_ALLOWED set to 2.38. Thi

Re: [virt-tools-list] [virt-viewer 2/4] spice: Stop using deprecated SpiceMainChannel API

2018-06-29 Thread Christophe Fergeau
On Thu, Jun 28, 2018 at 05:09:48PM -0300, Eduardo Lima (Etrunko) wrote: > On 14/06/18 13:01, Christophe Fergeau wrote: > > spice_main_set_display and spice_main_set_display_enabled have been > > superseded by spice_main_channel_update_display and > > spice_main_channel_update_display_enabled > > >

Re: [virt-tools-list] [virt-viewer 4/4] ovirt: Improve handling of g_strv_contains()

2018-06-29 Thread Christophe Fergeau
On Thu, Jun 28, 2018 at 04:45:01PM -0300, Eduardo Lima (Etrunko) wrote: > On 14/06/18 13:01, Christophe Fergeau wrote: > > The ovirt code uses g_strv_contains() with fallback code in > > glib-compat.h when we are using a glib version where it's not available. > > However, when we use a glib version