[virt-tools-list] [PATCH 1/2] Report gtk_accel_map_change_entry() failures

Signed-off-by: Paul Donohue --- src/virt-viewer-app.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 2a2..3a31bbb 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -1790,1

[virt-tools-list] [PATCH 0/2] Fixes for some hotkey issues in virt-viewer/remote-viewer

gtk_accel_map_change_entry() seems to reject lots of hotkey combinations, and virt-viewer silently ignores these rejections. This is very confusing for a user whose hotkeys simply aren't working. The first patch causes a message to be printed if gtk_accel_map_change_entry() fails, so the user

[virt-tools-list] [PATCH 2/2] Handle release-cursor hotkey in VNC/Spice instead of GTK

This avoids GTK accelerator conflicts, which allows the use of some hotkey sequences that are rejected by GTK. This also works around the fact that keyboard grabs are not released by spice_display_mouse_ungrab(). (See https://gitlab.freedesktop.org/spice/spice-gtk/issues/73 ) Signed-off-by: Paul

[virt-tools-list] [virt-manager PATCH v2] details: Use _disable_device_remove helper to set the remove tooltip

Signed-off-by: Lin Ma --- virtManager/details.py | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index 34bd35b3..e9ca5bda 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -2998,6 +2998,1

Re: [virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console &basic VM state

- Original Message - > From: "Marc-André Lureau" > To: "Xiaodai Wang" > Cc: "virt-tools-list" > Sent: Wednesday, August 1, 2018 9:46:47 PM > Subject: Re: [virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console > &basic VM state > > Hi > > On Wed, Aug 1, 2018 at 1:50 PM, Xiaodai

Re: [virt-tools-list] [PATCH 01/22] remote-viewer: add handling of spice+unix and spice+tls schemes

Acked-by: Jonathon Jongsma On Tue, 2018-07-31 at 15:24 +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > - spice+unix:// was added in spice-gtk v0.28 > - spice+tls:// was added in spice-gtk v0.35 > > This allows launchers to start remote-viewer when they encounter a > Sp

[virt-tools-list] Fwd: Virt-manager cuts off bottom of vm console

(My apologies to the list moderator... this initially bounced as I posted it from the wrong email acct) > I ssh into a physical machine running Ubuntu 18.04 to manage vm’s running > under kvm. To access the console on these machines or to build new machines > from an install iso I use the cons

Re: [virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

Thanks for the patch. We can simplify code here and make this mistake more obvious with a helper function. I'm pushing the attached commit to add a _disable_device_remove helper that takes only a tooltip as an argument, will save having to track can_remove. Please adapt patch #2 and this one to

Re: [virt-tools-list] [virt-manager PATCH 4/5] details: Fix the tooltip error on config-remove

On 07/18/2018 06:00 AM, Lin Ma wrote: The tooltip of config-remove will be changed after clicking the 'Keyboard' or 'Mouse' in details page, We need to restore it in the refresh_XXX_page functions. How to reproduce: 1. Click 'Keyboard' item in details page. 2. Observe the tooltip of the 'Remove'

[virt-tools-list] [PATCH 22/22] spice: hook into QMP port

From: Marc-André Lureau If the "org.qemu.monitor.qmp.0" port is available: - enable the VM UI - get and follow the VM state - send the requested VM actions This adds a json-glib dependency on spice-gtk display. If necessary, we could make it optional. Signed-off-by: Marc-André Lureau --- conf

Re: [virt-tools-list] [virt-viewer PATCH] Bump min spice to 0.35 and address deprecation warnings

On 30/07/18 05:05, Andrea Bolognani wrote: > On Fri, 2018-07-27 at 12:39 +0100, Daniel P. Berrangé wrote: >> Signed-off-by: Daniel P. Berrangé >> --- >> README.md | 2 +- >> configure.ac| 2 +- >> src/virt-viewer-display-spice.c | 2 +- >> src/virt-vie

[virt-tools-list] [PATCH 20/22] app: add "machine" UI

From: Marc-André Lureau Add a new "Machine" menu, which allows to Pause/Reset/Power Down a VM. The menu is only visible if "vm-ui" app property is set. When the application quits, it will also send a quit action to the VM. This is a similar behaviour/UI as qemu -display gtk. Signed-off-by: Ma

[virt-tools-list] [PATCH 12/22] display: ignore display that do not have toplevel window

From: Marc-André Lureau virt_viewer_display_get_preferred_monitor_geometry() may be called during application initialization (when the VTE console is being shown, virt_viewer_session_update_displays_geometry() is called when the visibility menu item is toggled). But the other displays may not yet

[virt-tools-list] [PATCH 10/22] Add a VirtViewerDisplayVte display kind

From: Marc-André Lureau This is not a graphical display, so the application will have to deal with it with care. You may argue that we need a large refactoring to introduce a more generic "console" object, that could be either graphical or textual. For now, this does work well enough for me. Si

[virt-tools-list] [PATCH 02/22] Remove class signal handlers

From: Marc-André Lureau We don't use class signal handlers, remove the extra pointers. g_signal_override_class_handler() could be used instead when needed. Signed-off-by: Marc-André Lureau --- src/virt-viewer-display.c | 10 +- src/virt-viewer-display.h | 8 src/virt-viewer-