Re: [virt-tools-list] [virt-viewer] app: Always add guest name comment

Acked-by: Christophe Fergeau On Thu, Aug 30, 2018 at 01:56:27PM +0200, Victor Toso wrote: > From: Victor Toso > > Even when the user adds comments, we should place the guest's name > unless it is present already. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1623756 > >

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

Hi, On Fri, Aug 31, 2018 at 01:18:31PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Aug 31, 2018 at 1:14 PM, Marc-André Lureau > wrote: > > Hi > > > > On Fri, Aug 31, 2018 at 8:32 AM, Victor Toso wrote: > >> Hi, > >> > >> On Tue, Jul 31, 2018 at 03:41:09PM +0200,

Re: [virt-tools-list] [PATCH 07/22] window: set sensitivity based on display capability

Hi On Fri, Aug 31, 2018 at 8:43 AM, Victor Toso wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:10PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau > > I take this is a preparatory patch for VTE, could you please add > some rationale in the commit log on why this was

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

Hi On Fri, Aug 31, 2018 at 8:32 AM, Victor Toso wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:09PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> A mere app::enable-accel notification shouldn't modify the >> sensitivity, which is handled for all menu items

[virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

Uses lease, agent and arp to try to get ipv4 and ipv6 address of given interface Lin Ma (2): domain: Add function interface_addresses to return ipv4 and ipv6 details: Show ipv4 and ipv6 address in details page of interface ui/details.ui | 79

[virt-tools-list] [virt-manager PATCH 1/2] domain: Add function interface_addresses to return ipv4 and ipv6

It returns a dict that consisting of ipv4 and ipv6 which only match the given mac, it returns None in exception. Signed-off-by: Lin Ma --- virtManager/domain.py | 27 +++ 1 file changed, 27 insertions(+) diff --git a/virtManager/domain.py b/virtManager/domain.py index

[virt-tools-list] [virt-manager PATCH 2/2] details: Show ipv4 and ipv6 address in details page of interface

If the interface's type is 'network', then code uses lease as one of parameters of interface_addresses to get ipv4 and ipv6 address. If the result is negative, then uses agent to try again, If the result is still negative, uses arp for final try. Signed-off-by: Lin Ma --- ui/details.ui

Re: [virt-tools-list] [PATCH 08/22] display: make klass->close() optional

Hi, On Tue, Jul 31, 2018 at 03:41:11PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spice and VTE display do not need to implement it. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display-spice.c | 8 >

Re: [virt-tools-list] [PATCH 08/22] display: make klass->close() optional

Hi, On Tue, Jul 31, 2018 at 03:41:11PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spice and VTE display do not need to implement it. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display-spice.c | 8 >

Re: [virt-tools-list] [PATCH 07/22] window: set sensitivity based on display capability

Hi, On Tue, Jul 31, 2018 at 03:41:10PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau I take this is a preparatory patch for VTE, could you please add some rationale in the commit log on why this was needed? > Signed-off-by: Marc-André Lureau > --- >

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

Hi, On Tue, Jul 31, 2018 at 03:41:09PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > A mere app::enable-accel notification shouldn't modify the > sensitivity, which is handled for all menu items elsewhere, leave the > current state untouched. > > Signed-off-by:

Re: [virt-tools-list] [PATCH 05/22] window: move default sensitivity in .ui

On Tue, Jul 31, 2018 at 03:41:08PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Instead of modifying it in object initialization. > > Signed-off-by: Marc-André Lureau > --- > src/resources/ui/virt-viewer.ui | 4 > src/virt-viewer-window.c| 5 - > 2

Re: [virt-tools-list] [PATCH 04/22] window: use virt_viewer_window_set_menus_sensitive()

Hi, On Tue, Jul 31, 2018 at 03:41:07PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > virt_viewer_window_set_menus_sensitive() is the common function to set > sensitivity on menu items. > > It was lacking "toolbar_send_key", so add it there too. > > Signed-off-by: