Re: [virt-tools-list] [vhostmd virtio PATCH v3 4/6] Add virtio functions

2018-11-14 Thread Jim Fehlig
On 11/12/18 8:12 AM, Michael Trapp wrote: At the vhostmd side virtio channels are Unix domain sockets from QEMU which are created during a VM start and removed when the VM is stopped. Basically this implementation - monitors a directory for new virtio channels (channel names contain VM UUID) - f

Re: [virt-tools-list] [vhostmd virtio PATCH v3 5/6] Activate virtio support in vhostmd

2018-11-14 Thread Jim Fehlig
On 11/12/18 8:13 AM, Michael Trapp wrote: Activate the virtio code and extend DTD/XML to support a virtio section for virtio related configuration and a new transport type virtio. --- README | 84 + vhostmd.changes | 5 +++ vhostmd

[virt-tools-list] [virt-manager] [RFC PATCH 6/9] virt-convert: Add auto complete support for the general options

2018-11-14 Thread Lin Ma
Signed-off-by: Lin Ma --- virt-convert | 4 1 file changed, 4 insertions(+) diff --git a/virt-convert b/virt-convert index 1b7b7963..204481e1 100755 --- a/virt-convert +++ b/virt-convert @@ -12,6 +12,8 @@ import sys +import argcomplete + from virtinst import cli from virtinst import

[virt-tools-list] [virt-manager] [RFC PATCH 4/9] virt-clone: Add auto complete support for the general options

2018-11-14 Thread Lin Ma
Signed-off-by: Lin Ma --- virt-clone | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virt-clone b/virt-clone index d1eedeea..7b805aa5 100755 --- a/virt-clone +++ b/virt-clone @@ -7,6 +7,7 @@ import argparse +import argcomplete import logging import sys @@ -138,6 +139,8 @@ def pars

[virt-tools-list] [virt-manager] [RFC PATCH 0/9] Tab completion in bash shell via the argcomplete

2018-11-14 Thread Lin Ma
Hi all, These draft patches add the tab completion in bash for virt-* utilities. We've been using the argparse to help parse handling, So I think that the argcomplete is a good option to deal with argument/sub-options completion in bash shell for virt-manager project. Argcomplete returns the comp

Re: [virt-tools-list] [virt-manager] [RFC PATCH 0/9] Tab completion in bash shell via the argcomplete

2018-11-14 Thread Lin Ma
On 11/14/18 4:12 PM, Lin Ma wrote: Hi all, These draft patches add the tab completion in bash for virt-* utilities. We've been using the argparse to help parse handling, So I think that the argcomplete is a good option to deal with argument/sub-options completion in bash shell for virt-manager

[virt-tools-list] [virt-manager] [RFC PATCH 3/9] virt-install: Add auto complete support for the general options

2018-11-14 Thread Lin Ma
With this patchset, the general options completion is available. ex: $ virt-install - ... --arch --check --cpu --dry-run -h --autostart --clock --cputune --events--help ... $ virt-install --a --arch --autostart Signed-off-by: Lin Ma --- virt-install | 3 +++ 1

[virt-tools-list] [virt-manager] [RFC PATCH 5/9] virt-xml: Add auto complete support for the general options

2018-11-14 Thread Lin Ma
Signed-off-by: Lin Ma --- virt-xml | 4 1 file changed, 4 insertions(+) diff --git a/virt-xml b/virt-xml index 39abd297..4a70206f 100755 --- a/virt-xml +++ b/virt-xml @@ -12,6 +12,8 @@ import os import re import sys +import argcomplete + import libvirt import virtinst @@ -393,6 +395

[virt-tools-list] [virt-manager] [RFC PATCH 8/9] Bash completion file

2018-11-14 Thread Lin Ma
The most of content of this file comes from the output of the command ' register-python-argcomplete $MY-SCRIPT', plus some changes. For the details about argcomplete, Please refer to https://pypi.org/project/argcomplete/ or https://github.com/kislyuk/argcomplete With this patchset, Users can use c

[virt-tools-list] [virt-manager] [RFC PATCH 9/9] setup.py: Install and link the bash completion scripts

2018-11-14 Thread Lin Ma
Signed-off-by: Lin Ma --- setup.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/setup.py b/setup.py index 658e6503..1c4b4340 100755 --- a/setup.py +++ b/setup.py @@ -273,6 +273,15 @@ class my_install_data(distutils.command.install_data.install_data): "share/gl

[virt-tools-list] [virt-manager] [RFC PATCH 2/9] cli: Add the generic completer function and validator function

2018-11-14 Thread Lin Ma
The patch adds the generic completer and validator, Further patches use them as completer/validator. The completer won't add already specified options to the list. Signed-off-by: Lin Ma --- virtinst/cli.py | 37 + 1 file changed, 37 insertions(+) diff --git a

[virt-tools-list] [virt-manager] [RFC PATCH 7/9] cli: Add auto complete support about sub options

2018-11-14 Thread Lin Ma
With this patchset, the sub options completion is available. ex: $ virt-install --disk ... bus=cache= format= path= serial= size= ... $ virt-install --disk path=test.qcow2,cache=none, ... bus=format= serial= size= ... $ virt-install --disk bu Then the sub option '

[virt-tools-list] [virt-manager] [RFC PATCH 1/9] Update docs to reflect the argcomplete dependency

2018-11-14 Thread Lin Ma
Signed-off-by: Lin Ma --- INSTALL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/INSTALL.md b/INSTALL.md index 983e32ce..efe73cf7 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -35,6 +35,7 @@ Minimum version requirements of major components: - libvirt-python >= 0.6.0 - pygobject3 >=